Date:   Fri, 3 Feb 2023 16:25:48 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <michael@walle.cc>
Subject: Re: [PATCH net-next v2] net: micrel: Add support for lan8841 PHY
Message-ID: <20230203152548.nqrewntwi2tyx4pz@soft-dev3-1>
References: <20230203122542.436305-1-horatiu.vultur@microchip.com>
 <Y90YrXHeyR6f26Px@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <Y90YrXHeyR6f26Px@lunn.ch>
Precedence: bulk

The 02/03/2023 15:22, Andrew Lunn wrote:

Hi Andrew,

> 
> > +{
> > +     char *rx_data_skews[4] = {"rxd0-skew-psec", "rxd1-skew-psec",
> > +                               "rxd2-skew-psec", "rxd3-skew-psec"};
> > +     char *tx_data_skews[4] = {"txd0-skew-psec", "txd1-skew-psec",
> > +                               "txd2-skew-psec", "txd3-skew-psec"};
> 
> Please take a read of
> Documentation/devicetree/bindings/net/micrel-ksz90x1.txt and then add
> a section which describes what these properties mean for this PHY,
> since nearly every microchip PHY has a different meaning :-(

I had a closer look at the datasheet of this PHY, and these properties
for lan8841 are the same for ksz9131, so actually I can reuse the
function 'ksz9131_config_init', to remove some of the duplicated code.

In this case maybe is enough to add the following change in
'micrel-ksz90x1.txt' not to create a totally new section.

---
diff --git a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
index df9e844dd6bc6..2681168777a1e 100644
--- a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
+++ b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
@@ -158,6 +158,7 @@ KSZ9031:
         no link will be established.

 KSZ9131:
+LAN8841:

   All skew control options are specified in picoseconds. The increment
   step is 100ps. Unlike KSZ9031, the values represent picoseccond delays.

---

> 
>       Andrew

-- 
/Horatiu