Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <4e5a447b-1796-513c-135a-f9e9c870d88a@roeck-us.net>
Date:   Fri, 3 Feb 2023 07:51:17 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Gaosheng Cui <cuigaosheng1@huawei.com>
Cc:     stable@vger.kernel.org, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com,
        f.fainelli@gmail.com, sudipm.mukherjee@gmail.com,
        srw@sladewatkins.net, rwarsow@gmx.de
References: <20230203101015.263854890@linuxfoundation.org>
 <CA+G9fYvd8D3LfxPg2afZXKFC3WNHrhyE7c3fFLViaG4WhJeHVg@mail.gmail.com>
 <5ed630fd-8bd7-4b80-9fa8-a3dab2eb0447@linaro.org>
From:   Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 4.19 00/80] 4.19.272-rc1 review
In-Reply-To: <5ed630fd-8bd7-4b80-9fa8-a3dab2eb0447@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/3/23 04:28, Krzysztof Kozlowski wrote:
> On 03/02/2023 12:04, Naresh Kamboju wrote:
>> On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>>>
>>> This is the start of the stable review cycle for the 4.19.272 release.
>>> There are 80 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>>          https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc1.gz
>>> or in the git tree and branch at:
>>>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
>> Following patch caused build error on arm,
>>
>>> Gaosheng Cui <cuigaosheng1@huawei.com>
>>>      memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
>>
>> drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe':
>> drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of
>> function 'devm_clk_get_enabled'
>> [-Werror=implicit-function-declaration]
>>    297 |  clk = devm_clk_get_enabled(&pdev->dev, NULL);
>>        |        ^~~~~~~~~~~~~~~~~~~~
> 
> Already reported:
> https://lore.kernel.org/all/202302020048.ZsmUJDHo-lkp@intel.com/
> 

I don't usually check if release candidate reports have been reported already.
If I know about it, I may add a reference to the report, but typically I still
report it.

Personally I find it discouraging to get those "already reported" e-mails.
To me it sounds like "hey, you didn't do your job properly". It should not matter
if a problem was already reported or not, and I find it valuable if it is
reported multiple times because it gives an indication of the level of test
coverage. I would find it better if people would use something like "Also
reported:" instead. But then maybe I am just oversensitive, who knows.

Anyway, yes, I noticed this problem as well (and probably overlooked it
in my previous report to Greg - sorry for that).

Thanks,
Guenter