Date:   Fri, 3 Feb 2023 17:35:47 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc:     michal.simek@xilinx.com, michal.simek@amd.com,
        devicetree@vger.kernel.org, andrew@lunn.ch, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, git@amd.com, srinivas.goud@amd.com,
        shubhrajyoti.datta@amd.com, manion05gk@gmail.com,
        Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Subject: Re: [PATCH V4 4/9] i2c: xiic: Add wait for FIFO empty in send_tx
Message-ID: <Y9034/vvjBehZXF5@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Manikanta Guntupalli <manikanta.guntupalli@amd.com>,
        michal.simek@xilinx.com, michal.simek@amd.com,
        devicetree@vger.kernel.org, andrew@lunn.ch, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, git@amd.com, srinivas.goud@amd.com,
        shubhrajyoti.datta@amd.com, manion05gk@gmail.com,
        Raviteja Narayanam <raviteja.narayanam@xilinx.com>
References: <1675330898-563-1-git-send-email-manikanta.guntupalli@amd.com>
 <1675330898-563-5-git-send-email-manikanta.guntupalli@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pAsRdv62yj1l9JQI"
Content-Disposition: inline
In-Reply-To: <1675330898-563-5-git-send-email-manikanta.guntupalli@amd.com>
Precedence: bulk


--pAsRdv62yj1l9JQI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 02, 2023 at 03:11:33PM +0530, Manikanta Guntupalli wrote:
> From: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
>=20
> If the tx_half_empty interrupt comes first instead of tx_empty,
> STOP bit is generated even before all the bytes are transmitted
> out on the bus.
> STOP bit should be sent only after all the bytes in the FIFO are
> transmitted out of the FIFO. So wait until FIFO is empty before sending
> the STOP bit.
>=20
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> Acked-by: Michal Simek <michal.simek@amd.com>

Applied to for-next, thanks!


--pAsRdv62yj1l9JQI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmPdN+MACgkQFA3kzBSg
KbYFRxAArxOL34lU5Ic30/HXV4AsFAxSpnwqr3FlKjW6eQpkVo+kYhMpalfQ94w1
YZvBk5JQUSTaFRjza1sE8lQVnFiTQEhuH4pW4PgdOZ48TXE9DQy4PoTtzMmISMf9
URwkYwk9Ls2tJCyM9kjKQdA+uNDMq07MYuPpFUpY7/fE1t8D9uA4jNdXGndaje3Y
CLdxOkPHHdu28PsjAEr3EdDho2CB0LUD1rqc4Hfn5aulkzxcMdddqaHNaVzeP3Kb
PkyrrZn/gMSuZZzTr4rATUz9bRBgTuRC5+tEc5VARR0ftZuw2WbmSGZ2xdmNxvI8
6v9Gr9ta3MgCbh/NuxMVCCyTPqycwjiVTGNhOcXt+2gttdp7i/5DUn98cnHsLd5H
dqKqY8tPUNE23hKGGfsMgVE+CNQVv/kEF2e5LGXg9ilIUONZ+dPZsRiHYCdJZ9VJ
4uMCUZ3o8YpEimZxjSCksVjpSBcgMqrVclbEjaAletPDs0sc1qkoZH9Bv+ABt7hx
VIEthHXYhY8P7IgAZ97mpRx5KOI27VRed7wAeitU/3enJ9g+YxCCEn7Ui1y7EYP+
nunMAjXol07vqkX2sej1DeXkDnYg8O0eFE1MZX8d6p/+5ybkr9XQN1OnE6SnBVrE
MoT6Cu49rJiIWp/qy254mYOD7YScGLNEMYTqIx/7mUAaJIHePQ0=
=ejvd
-----END PGP SIGNATURE-----

--pAsRdv62yj1l9JQI--