Date:   Fri, 3 Feb 2023 17:37:43 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc:     michal.simek@xilinx.com, michal.simek@amd.com,
        devicetree@vger.kernel.org, andrew@lunn.ch, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, git@amd.com, srinivas.goud@amd.com,
        shubhrajyoti.datta@amd.com, manion05gk@gmail.com,
        Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Subject: Re: [PATCH V4 5/9] i2c: xiic: Add smbus_block_read functionality
Message-ID: <Y904V8zdCKDFxtR3@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Manikanta Guntupalli <manikanta.guntupalli@amd.com>,
        michal.simek@xilinx.com, michal.simek@amd.com,
        devicetree@vger.kernel.org, andrew@lunn.ch, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, git@amd.com, srinivas.goud@amd.com,
        shubhrajyoti.datta@amd.com, manion05gk@gmail.com,
        Raviteja Narayanam <raviteja.narayanam@xilinx.com>
References: <1675330898-563-1-git-send-email-manikanta.guntupalli@amd.com>
 <1675330898-563-6-git-send-email-manikanta.guntupalli@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="REmZzdpqahJJ1gqK"
Content-Disposition: inline
In-Reply-To: <1675330898-563-6-git-send-email-manikanta.guntupalli@amd.com>
Precedence: bulk


--REmZzdpqahJJ1gqK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 02, 2023 at 03:11:34PM +0530, Manikanta Guntupalli wrote:
> From: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
>=20
> smbus_block_read is added to xiic driver to read from few sensors
> which support this command. Since the number of bytes to read is not
> known prior to transfer, xiic standard mode is being used for low level
> control of IP.
>=20
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> Acked-by: Michal Simek <michal.simek@amd.com>

Applied to for-next, thanks!

> -	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> +	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | I2C_FUNC_SMBUS_BLOCK_DATA;

Note: Since you implemented I2C_M_RECV_LEN anyhow, you get the emulated
I2C_FUNC_SMBUS_BLOCK_PROC_CALL basically for free, so you could also use
I2C_FUNC_SMBUS_EMUL_ALL here.

If you'd like this, please send an incremental patch.


--REmZzdpqahJJ1gqK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmPdOFYACgkQFA3kzBSg
KbaDaA//Yq0UOuaVYq4VArqrqfGs+W/4qmgRccjYbdWjLcx77XAadAlJiWJ/YQAH
525PAd5ziSDB6B3VNKu6BZIXaLzYuYxbE3qLZjjro28r4Bl0oJA9SCjH8T19K4AW
D4o+aePktMjRC9yJ+iagGQPcP7NgfozMbT0w7uho0KqV8WU3xVDOOEAJ7k1qxTjU
lg7quCuXm33+fou1MjEgsUq2iRCfxJfyQaShEk+YgANTEP4A+9Vqg4SMGyp/SBcg
Y3suJZIBczR1of6V/XN7ufL4nV+FRZizGFAyNO/SHYLg5k0xd9/wMAtGv3XcE6HJ
7JM2ghVUWQ7lgo0cSdqghTfpJT3zVxTOdqq7XBF4qXhrztz8ZDOEXzBwRzB71bpY
awmRRLHe2lZRYKYqc3tOKUEQXceE9Sg0lDc7jVZqwtw1kVt1dwmVdjdwilraGuib
t5lzXcNEctOE+e/0eT5kwpzWWB4eC3ZndZbM63FixY3sc37Mhjwh0WSXUoz/n5pX
dkZdwY/pKlG+5BHiXf+mry7HrNrD8sX5xqhIbZBofF88xBJmRlgFILk3p4DEox3e
lhBs7u1Dvgb04JphTWpd+2JUO7KXM8RijjZ081AijMsHyUSRgdtBhnsXA2rtJBzb
XQCWQp4yNFuEOy3QR2dIKhH2IWIzhJoXGSshdtyF9tjzBYQvshc=
=wNvz
-----END PGP SIGNATURE-----

--REmZzdpqahJJ1gqK--