Message-ID: <de935b11-f5b7-9217-b73c-aef32c19c3c7@linuxfoundation.org>
Date:   Fri, 3 Feb 2023 09:56:51 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] selftests/ftrace: Fix bash specific "==" operator
Content-Language: en-US
To:     Steven Rostedt <rostedt@goodmis.org>,
        "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc:     Shuah Khan <shuah@kernel.org>, Yipeng Zou <zouyipeng@huawei.com>,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <167434397083.3069767.14730152459198287532.stgit@devnote3>
 <20230124191637.0b2b8785@gandalf.local.home>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20230124191637.0b2b8785@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/24/23 17:16, Steven Rostedt wrote:
> On Sun, 22 Jan 2023 08:32:50 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> 
>> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>>
>> Since commit a1d6cd88c897 ("selftests/ftrace: event_triggers: wait
>> longer for test_event_enable") introduced bash specific "=="
>> comparation operator, that test will fail when we run it on a
>> posix-shell. `checkbashisms` warned it as below.
>>
>> possible bashism in ftrace/func_event_triggers.tc line 45 (should be 'b = a'):
>>          if [ "$e" == $val ]; then
>>
>> This replaces it with "=".
>>
>> Fixes: a1d6cd88c897 ("selftests/ftrace: event_triggers: wait longer for test_event_enable")
>> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> Shuah,
> 
> Care to pull this through your tree?
> 

Yes. Will appear shortly in linux-kselftest next.

thanks,
-- Shuah