Date:   Fri, 3 Feb 2023 17:58:04 +0100
From:   Henning Schild <henning.schild@siemens.com>
To:     Lee Jones <lee@kernel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the
 GPIO providing driver
Message-ID: <20230203175804.2560dd21@md1za8fc.ad001.siemens.net>
In-Reply-To: <Y9y+yOa1gxy3h+rG@google.com>
References: <20221007153323.1326-1-henning.schild@siemens.com>
        <Y8mv8PzL1UsP9gNh@google.com>
        <20230202205704.12a5fbff@md1za8fc.ad001.siemens.net>
        <Y9y+yOa1gxy3h+rG@google.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qYHGCVBuohsXQ/KluWnPMretvkvD9ywz14RZfEl7lS/SM/+s360ZafQ0my25?=
 =?us-ascii?Q?s2wvHWCr/9QNsx6NvsbiP+TVodfbSXl7kQzIucwW5b4mZgrPtMCFvA00Yrjt?=
 =?us-ascii?Q?3JB1PKO5pO4FC3pww7lsrK3LsbK0hmNphKvTThXZ78hBFGPGzu0/AFL+OzlH?=
 =?us-ascii?Q?SlglFuzZd0tidQ5KdGrbHOHotC3ajmZRIelS/ZuUJVf71UjJEysOxfGBoeIo?=
 =?us-ascii?Q?uCCZk0m3WCBeLID5GgzMpjOU5Tc3/fI27XMe3t46Wv/48YvASQ5oIHYZgS1j?=
 =?us-ascii?Q?sOt0W6nM1LqxV4QRXMGchNH9PKcOfgCARq4mrlhWJztJwOk8zpUzSUWFz18g?=
 =?us-ascii?Q?5DYQlu9SCDekPohAr5lGPJDU9kzwDyaQgM20c6G3/uj0lASzUOzZEz67n8jI?=
 =?us-ascii?Q?g9eI3AA9ac6orZBNNDXCcK98pqOdFuEjr9cZJkTupgrBN1LewUlEMV2E96ae?=
 =?us-ascii?Q?DvQsPbr2l9MYDkLEvykWYhUIPd8hBrsoyLSpefkdHUyHnwd+O577DHSTq353?=
 =?us-ascii?Q?O9v8GK8t3+wWTokHPY9UWzxcGLVPKntMeCAAqttzpOkweFVbYC7AurgnZOjD?=
 =?us-ascii?Q?k2rW4jGYycFkPdrvNiPKFC2XuJRifBqNxKcgpcV3H4RoOp02GOvh28KH3HP4?=
 =?us-ascii?Q?zoc6QYA5+salBb8/vbsNYLvpD9akmhfXWlJpPoSQ3sIzbeirDOnro33wrjcc?=
 =?us-ascii?Q?mTnu53hNP8HhEdMsrWqkQe6jqARCZ91076uHPueh4FfMQtbUTZZWHkgivKXr?=
 =?us-ascii?Q?ZjfIIBbQXGy1U+sGXa0DfKb3n1MFC9yhXqhTKyFSWOYDCPiHDenQELcmZOEZ?=
 =?us-ascii?Q?rvgkNgA3p/zOqSGFU+sFiAr82+37fSR7ZJy8IHw5HxzDQbW6PWYW0B5my4rx?=
 =?us-ascii?Q?S0xZ5EWGAvHEWLZ1WApZ+pfrtoNxGKOPSY5cxcnpNUik36FBqVbsrt98ynWu?=
 =?us-ascii?Q?zDElTXA6KZtDZWwp2i5A20fCOUd2pj7eIq0qg9+D4F65xwZ4+ZMsBUrkjneI?=
 =?us-ascii?Q?ynW2q8UHXz1XuZOW8pLuAtDxQGMv9bExI36/1y4FDoUSrbSDmbvGqfj5JRjN?=
 =?us-ascii?Q?QGfNHFQ7j6m5zTwcztnXWqFHbyYjnBTCl1I0ypf4QL4OdEtnTi/3nI790c77?=
 =?us-ascii?Q?yTWgKLtMQRc10om/Y3CeayjcaZxbQnWDFB8hfOm3RqVoKUoZf7pvu2c29nUw?=
 =?us-ascii?Q?aCoPPiAR3XBZAinUer39bWjKwyGODX+U0XEWC9KNi5Xb6M7U7IISzOl+viSX?=
 =?us-ascii?Q?lyeUCHO/g5lx3kxmQde4f/EV2sjo8a99P2WfIyH5uwwg2jA7/SP8dUgLRRyz?=
 =?us-ascii?Q?uNGRClPOEajc8O8GeQNdVQudvun8YuAFfRP0mb7nkS543SnYZfyeWzw57kKj?=
 =?us-ascii?Q?QqFppzppOAhGv5OeuxkO8XvzgQib1BxuGQW/T5sg8KVD6n6TZ0Lrsrwfwhbl?=
 =?us-ascii?Q?Qhu+Cs84OnfJMsSRsoR22IBzcOcxs1ueHchuLtfcuCzMVRdNtBdP4/Wfi0Q3?=
 =?us-ascii?Q?23RGlB8DoRBns+eaI/iHIOHRrSXvdezhq8Vzl1Q9rltthypHui3e5ySq1gMO?=
 =?us-ascii?Q?iUJFO+gGkfIktbu+kYIjL1FksDnJnHqK0dS9glgGGao6jhol5BpA07Mi469S?=
 =?us-ascii?Q?yw=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd4e5cce-75b3-4938-bd3d-08db0607d522
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 16:58:11.6230
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JqLojECr2pcBSh5WonCQBfk4WIL8D15Mz1Y6S1QcgaklruocGwHS9oa+mCiua4WHy0upbxdaOGkJxThRqCBuAOr5cICP+ZaNfk2jSsU9tI8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR10MB7776
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Fri, 3 Feb 2023 07:59:04 +0000
schrieb Lee Jones <lee@kernel.org>:

> On Thu, 02 Feb 2023, Henning Schild wrote:
> 
> > Am Thu, 19 Jan 2023 21:02:40 +0000
> > schrieb Lee Jones <lee@kernel.org>:
> >   
> > > On Fri, 07 Oct 2022, Henning Schild wrote:
> > >   
> > > > If we register a "leds-gpio" platform device for GPIO pins that
> > > > do not exist we get a -EPROBE_DEFER and the probe will be tried
> > > > again later. If there is no driver to provide that pin we will
> > > > poll forever and also create a lot of log messages.
> > > > 
> > > > So check if that GPIO driver is configured, if so it will come
> > > > up eventually. If not, we exit our probe function early and do
> > > > not even bother registering the "leds-gpio". This method was
> > > > chosen over "Kconfig depends" since this way we can add support
> > > > for more devices and GPIO backends more easily without
> > > > "depends":ing on all GPIO backends.
> > > > 
> > > > Fixes: a6c80bec3c93 ("leds: simatic-ipc-leds-gpio: Add GPIO
> > > > version of Siemens driver") Reviewed-by: Andy Shevchenko
> > > > <andy.shevchenko@gmail.com> Signed-off-by: Henning Schild
> > > > <henning.schild@siemens.com> ---
> > > >  drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 ++
> > > >  1 file changed, 2 insertions(+)    
> > > 
> > > FYI: I'm going to try my best not to take another one like this.  
> > 
> > You will not have to. I now understood how to improve on that as i
> > am adding more variants needing more gpio controller drivers.
> >   
> > > Please try to improve the whole situation for you next submission.
> > > 
> > > Applied, thanks.  
> > 
> > I hope this is still in the branches for a merge. It should be
> > applied. It does fix a problem but using a wrong pattern, but a
> > pattern that is already in use.  
> 
> What makes you think it's not applied?

Because i had that other one potentially replacing it so it was maybe
called off. Good to know it was not stopped.

Henning

>  
> > So this will fix 6.1 and above in the short term.
> > 
> > In the long term i will restructure to individual drivers which
> > have a clear dependency chain in Kconfig. I will use inheritance to
> > arrive at minimal code duplication and will use Kconfig switch
> > default inheritance to ease configuration.
> > 
> > Such restructuring patches will have to be written first, but they
> > will come. Either stand-alone or together with the next machine.  
> 
> That's fine.  Whatever suits.
>