Message-ID: <a7c193b7-894a-c891-071c-f405e394421b@intel.com>
Date:   Fri, 3 Feb 2023 10:24:38 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH v6 4/5] selftests/resctrl: Cleanup properly when an error
 occurs in CAT test
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230131054655.396270-1-tan.shaopeng@jp.fujitsu.com>
 <20230131054655.396270-5-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230131054655.396270-5-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVJOa0pHUFplc0VBTC9DT3VCUXdOS2FzOGJFeDVXK29DSTdHMUlmb3RrL2gy?=
 =?utf-8?B?T0xROVdXSU1saDRXS1h2bHhBdzV6emVxV1hvR25xL2pvZFRURDVSZVk1ZXdP?=
 =?utf-8?B?K1pmU1VBZVluVTdKTUhxQkxqS2VVVjNGSk1QOEw0cGpBQlZnWWVTK2dHQ0hv?=
 =?utf-8?B?Mi9jMXdlaERMNWU0ZkZuajFPTDlpL0J4bFQzdzVyMmZvV1NKa3JKMStMNm5F?=
 =?utf-8?B?VENJQTRlV3ovM202UElUOTZtaEk5TCtvb2tWeVBESXpvRE9PcW9OMmxJOERn?=
 =?utf-8?B?V2pGN3h5VmhxMytFVi84dEpFYVZ2YXRzYmlTTDhEMDFxSEhMMUV0c05VWVdi?=
 =?utf-8?B?aElsNzgyS2VxODU1WVBYQkZ0MVhPZ3NBck5pQWZkdnE4dVNlQ3dNNjZWNmdU?=
 =?utf-8?B?RHdIZG5Denc1NGF6WkFpaFV3K1N6SGthL0p3ZC9ZMWJZNHFSVGRKclJhZmZw?=
 =?utf-8?B?UXp0Rk94MjR4Mnl3eHdXblBzMlVYcW9Kd2pETXhXd0dNUnVzazY1K0RMU2hH?=
 =?utf-8?B?dU5zVnlidVBLT1JWYVZNT1gxaUNpVmhVZzQzMnFBZzlTSGMxN3M4WTdNRkJZ?=
 =?utf-8?B?cUlFTFcrZU0xaWYwWGxYdWt4Nld1V1ZZM0RLTHZ1eXhzUzdhL2h5UDlGRWVt?=
 =?utf-8?B?c2JiSXZZeGR1aC9wSERGUmJzKzJNZDkrZUp2TzhVWW92VGo4WisvbXVFc1pR?=
 =?utf-8?B?NWU1dUI3QXlORnlUWnAybDZxcm05S0JFWGt5VWNnOWdKMVhTaHdEcytSSFBo?=
 =?utf-8?B?R3l5U1FsZ3h4NWt0VDV0U01aekJsMC9rNk56QVBjN1JmWTVpYUtCeVVrV1Bk?=
 =?utf-8?B?aDZ5SXZnRWs3c3Z3SnFLUkhiTkJqSkhMQnZIOE01M25PNHp5aGNIcjl5NGxh?=
 =?utf-8?B?KzBqbUJpZG4rb0o2SThJbGNMTGNkZXVOTjZNNmdkbU4xNE81M20rdDhRMzk2?=
 =?utf-8?B?VnhpWlczN0ljc0UrMW0vYUQzTnZUNU1rc1EzSHgyS3hxK1N5R0JsQytPZjg3?=
 =?utf-8?B?dUdpRmxja3ZSYmQrVkhxS2VLbGdwa3N0ay80QmVpNTQzR2RlUmtoYVJxeUUy?=
 =?utf-8?B?N3NqMkRKU0p3MEZxdEFDOEJJbU9LcTBmK2pRZDlsNy9JMnFPcVRDMVgxTlor?=
 =?utf-8?B?bC9MbSsxSU80SUpvUEIyV1J5WEcrZytaanpEWWVrN3JYT1ZreDNhcVhIWTNS?=
 =?utf-8?B?NDlIdjFWcmZuYU5RVHhNSWhHVHpPV1pQMktwZ2ZmZXc1dzc5dVlUOW4wNTRt?=
 =?utf-8?B?Z3ZtaWNXVXRvOGtnSHI5NW5JdEJiMCtGZE13K3BpLzE4OTRqWjdRRVlQQ0lU?=
 =?utf-8?B?Um1yVTJtbUYvSzZCUHN6RXg2UmQ4NFRQRnRDbHQxRm5uWFRPb1JScXVyZUgx?=
 =?utf-8?B?WW5DYkVTTGozak5aRmlFbHRoN001eS9RWUJDYkFIZE4zakRDYWZaS1FjWGx0?=
 =?utf-8?B?Rnd3cTlEVkVwSTI1eXgwa00wOXBrTWZ3Z2VXamdKMS9EME1GcUJkZlFKY1Nt?=
 =?utf-8?B?c1ZhU05wMWRFRFdZM01TWUE3TjVZaXpMdmJrdnBXNUJwMlJybnZ5QTJrYURr?=
 =?utf-8?B?RXJsZGZKbSt3RVFZRlMxeXZJZURiVVJQM0Z2dCtqR0lMMnNPUzE4a3YxNWJ5?=
 =?utf-8?B?MGZ6ZXNyL1hvTzdSc0lxekYrZ3owekJvSjBHNHJDSWgrUUY5OVRIZUZRMEhU?=
 =?utf-8?B?TTlZakZLWXVBa3dUc25YeFYwcEtIREE2K2xCYzJhTmJMVmFGeUo5VzRSRmRI?=
 =?utf-8?B?enRrWlhRKzVZRGpVZGM0d2V3OHdsSVU1cEtYWFhJSG5BRjA4Q1NCLzFhOGYx?=
 =?utf-8?B?bGQwVVdTRXVncDFzYkN2WjRkY21WaEJ6OWVhbGUxZElGaHJUbmdONU54UEN4?=
 =?utf-8?B?L2NTYnk0a0FLRjhmNE9VWVpia3g2Si9DdFUvdXZXZCtBb3doa1M4MjdEYWdq?=
 =?utf-8?B?c2ZkR2NSQ05RQ25jcjVuME9SS2MxbXdPTTh4WmRkVUVzbUpwRXBlZTFPWmR4?=
 =?utf-8?B?YWVISVVnZ2Y2Vy96NnZqb1RzUEtFZDhQVWk3TEpabmFPNFY5aTRBRS9XZlpU?=
 =?utf-8?B?S1oyNFVrS1RZQS85UlVBMFQzd1J5Qm01S01TYS9hbVRJRURDZ0E1empoS1Nw?=
 =?utf-8?B?UXFOZ3Nxd2lPQjBoamlmY2xnTmRBbHJyeUVtczNmSzF3a0c4NVhsNWxiWi9j?=
 =?utf-8?B?blE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bb3b3d0-2807-4e36-fd74-08db0613ea96
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 18:24:41.5778
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PLoCgHWdadzuMptVK0SAPIxt5MRe5s86R/mwLbvGVU9sSIQq5UNbTGs0btI3apLAfm60bD8grvcFElUshOhswFK/U9ZDxFuUkFceAQH0zao=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7053
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng,

On 1/30/2023 9:46 PM, Shaopeng Tan wrote:
> After creating a child process with fork() in CAT test, if an error
> occurs or a signal such as SIGINT is received, the parent process will
> be terminated immediately, and therefor the child process will not
> be killed and also resctrlfs is not unmounted.
> 
> There is a signal handler registered in CMT/MBM/MBA tests, which kills
> child process, unmount resctrlfs, cleanups result files, etc., if a
> signal such as SIGINT is received.
> 
> Commonize the signal handler registered for CMT/MBM/MBA tests and reuse
> it in CAT too.
> 
> To reuse the signal handler, make the child process in CAT wait to be
> killed by parent process in any case (an error occurred or a signal was
> received), and when killing child process use global bm_pid instead of
> local bm_pid.
> 
> Also, since the MBA/MBA/CMT/CAT are run in order, unregister the signal
> handler at the end of each test so that the signal handler cannot be
> inherited by other tests.
> 

Great changelog.

...

> @@ -181,28 +180,31 @@ int cat_perf_miss_val(int cpu_no, int n, char *cache_type)
>  		strcpy(param.filename, RESULT_FILE_NAME1);
>  		param.num_of_runs = 0;
>  		param.cpu_no = sibling_cpu_no;
> +	} else {
> +		ret = signal_handler_register();
> +		if (ret) {
> +			kill(bm_pid, SIGKILL);
> +			goto out;
> +		}
>  	}
>  
>  	remove(param.filename);
>  
>  	ret = cat_val(&param);
> -	if (ret)
> -		return ret;
> -
> -	ret = check_results(&param);
> -	if (ret)
> -		return ret;
> +	if (ret == 0)
> +		ret = check_results(&param);
>  
>  	if (bm_pid == 0) {
>  		/* Tell parent that child is ready */
>  		close(pipefd[0]);
>  		pipe_message = 1;
>  		if (write(pipefd[1], &pipe_message, sizeof(pipe_message)) <
> -		    sizeof(pipe_message)) {
> -			close(pipefd[1]);
> +		    sizeof(pipe_message))
> +			/*
> +			 * Just print the error message.
> +			 * Let while(1) run and wait for itself to be killed.
> +			 */
>  			perror("# failed signaling parent process");
> -			return errno;
> -		}
>  
>  		close(pipefd[1]);
>  		while (1)
> @@ -222,9 +224,11 @@ int cat_perf_miss_val(int cpu_no, int n, char *cache_type)
>  		kill(bm_pid, SIGKILL);
>  	}
>  
> +	signal_handler_unregister();

I expected the code to be symmetrical but found that the signal
handler is registered by parent, but unregistered by both the parent
and the child.  Could signal_handler_unregister() be moved to the
parent portion of the "if" statement above? 

...

> --- a/tools/testing/selftests/resctrl/resctrl_val.c
> +++ b/tools/testing/selftests/resctrl/resctrl_val.c
> @@ -476,6 +476,45 @@ void ctrlc_handler(int signum, siginfo_t *info, void *ptr)
>  	exit(EXIT_SUCCESS);
>  }
>  
> +/*
> + * Register CTRL-C handler for parent, as it has to kill
> + * child process before exiting
> + */
> +int signal_handler_register(void)
> +{
> +	struct sigaction sigact;
> +	int ret = 0;
> +
> +	sigact.sa_sigaction = ctrlc_handler;
> +	sigemptyset(&sigact.sa_mask);
> +	sigact.sa_flags = SA_SIGINFO;
> +	if (sigaction(SIGINT, &sigact, NULL) ||
> +	    sigaction(SIGTERM, &sigact, NULL) ||
> +	    sigaction(SIGHUP, &sigact, NULL)) {
> +		perror("# sigaction");
> +		ret = -1;
> +	}
> +	return ret;
> +}
> +
> +/*
> + * Reset signal handler to SIG_DFL.
> + * Non-Vaule return because the caller should keep

Typo in "Non-Vaule"

> + * the error code of other path even if sigaction fails.
> + */
> +void signal_handler_unregister(void)
> +{
> +	struct sigaction sigact;
> +
> +	sigact.sa_handler = SIG_DFL;
> +	sigemptyset(&sigact.sa_mask);
> +	if (sigaction(SIGINT, &sigact, NULL) ||
> +	    sigaction(SIGTERM, &sigact, NULL) ||
> +	    sigaction(SIGHUP, &sigact, NULL)) {
> +		perror("# sigaction");
> +	}
> +}
> +
>  /*
>   * print_results_bw:	the memory bandwidth results are stored in a file
>   * @filename:		file that stores the results
> @@ -671,39 +710,28 @@ int resctrl_val(char **benchmark_cmd, struct resctrl_val_param *param)
>  
>  	ksft_print_msg("Benchmark PID: %d\n", bm_pid);
>  
> -	/*
> -	 * Register CTRL-C handler for parent, as it has to kill benchmark
> -	 * before exiting
> -	 */
> -	sigact.sa_sigaction = ctrlc_handler;
> -	sigemptyset(&sigact.sa_mask);
> -	sigact.sa_flags = SA_SIGINFO;
> -	if (sigaction(SIGINT, &sigact, NULL) ||
> -	    sigaction(SIGTERM, &sigact, NULL) ||
> -	    sigaction(SIGHUP, &sigact, NULL)) {
> -		perror("# sigaction");
> -		ret = errno;
> -		goto out;
> -	}
> +	ret = signal_handler_register();
> +	if (ret)
> +		goto out1;

Please do not use generic "out1" and "out2" goto labels. Could
you please change them to reflect what is done at that exit?
You could keep "out" but "out2" could be renamed to "unregister"
or something more appropriate.

...

> @@ -761,7 +789,9 @@ int resctrl_val(char **benchmark_cmd, struct resctrl_val_param *param)
>  		}
>  	}
>  
> -out:
> +out2:
> +	signal_handler_unregister();
> +out1:
>  	kill(bm_pid, SIGKILL);
>  	umount_resctrlfs();
>  

Thank you

Reinette