Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5616EC05027
	for <linux-kernel@archiver.kernel.org>; Fri,  3 Feb 2023 19:08:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233471AbjBCTI3 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 3 Feb 2023 14:08:29 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52008 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231614AbjBCTI0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Feb 2023 14:08:26 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E667126EC;
        Fri,  3 Feb 2023 11:08:03 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id B7E8AB82B96;
        Fri,  3 Feb 2023 19:08:01 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDFC9C433D2;
        Fri,  3 Feb 2023 19:07:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1675451280;
        bh=exUGZp02UwWrWGS125EwO1UlkTdwsf72x2iNszlxB0M=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=t9D43HmBVK6XE7CcBQxpK5CIHgtII8+JNAJQQtiNuGc7A78VKthJ81skMvDe7mids
         aFY67t4OxR6YKdHT32aGF5szRyhpRGc3QV1HvWQ0/jH788Jn+7ax/NjdjI9xpGgMs3
         p+aIk12ePmABPbsAkTpm8P1wq09ZiCUxRn8aUcITr9Fw0XQzkspR6/lgukscj/6Vbx
         D4Pk5ER7B3faI7AV7xMvtEAdJ/KR4+W9LjBdctunVPewdjO0HFw99Jzp2xhCz3yIUa
         FZmFX3Gq3BesECYLpDFKYg3EnIkas1uU6ZTC1NGFBKCfYmF173jB3+YfaE4G4BaGuR
         ya+TVQBwBw1Zw==
Date:   Fri, 3 Feb 2023 11:07:58 -0800
From:   Eric Biggers <ebiggers@kernel.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Guenter Roeck <linux@roeck-us.net>, stable@vger.kernel.org,
        patches@lists.linux.dev, linux-kernel@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com,
        f.fainelli@gmail.com, sudipm.mukherjee@gmail.com,
        srw@sladewatkins.net, rwarsow@gmx.de
Subject: Re: [PATCH 5.4 000/134] 5.4.231-rc1 review
Message-ID: <Y91bjnIuQRvVqpO7@sol.localdomain>
References: <20230203101023.832083974@linuxfoundation.org>
 <20230203155619.GA3176223@roeck-us.net>
 <Y906Hz3UWYxoxYdD@kroah.com>
 <20230203171826.GA1500930@roeck-us.net>
 <Y91YWzopMMGF1Lgh@sol.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y91YWzopMMGF1Lgh@sol.localdomain>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 03, 2023 at 10:54:21AM -0800, Eric Biggers wrote:
> On Fri, Feb 03, 2023 at 09:18:26AM -0800, Guenter Roeck wrote:
> > On Fri, Feb 03, 2023 at 05:45:19PM +0100, Greg Kroah-Hartman wrote:
> > > On Fri, Feb 03, 2023 at 07:56:19AM -0800, Guenter Roeck wrote:
> > > > On Fri, Feb 03, 2023 at 11:11:45AM +0100, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 5.4.231 release.
> > > > > There are 134 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > > 
> > > > > Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000.
> > > > > Anything received after that time might be too late.
> > > > > 
> > > > 
> > > > Building ia64:defconfig ... failed
> > > > --------------
> > > > Error log:
> > > > <stdin>:1511:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > > > arch/ia64/kernel/mca_drv.c: In function 'mca_handler_bh':
> > > > arch/ia64/kernel/mca_drv.c:179:9: error: implicit declaration of function 'make_task_dead'
> > > > 
> > > > Caused by "exit: Add and use make_task_dead.". Did that really have to be backported ?
> > > 
> > > Yup, it does!
> > > 
> > > Eric, any help with this?
> > > 
> > 
> > Adding "#include <linux/sched/task.h>" to the affected file would probably
> > be the easy fix. I did a quick check, and it works.
> > 
> > Note that the same problem is seen in v4.14.y and v4.19.y. Later
> > kernels don't have the problem.
> > 
> 
> This problem arises because <linux/mm.h> transitively includes
> <linux/sched/task.h> in 5.10 and later, but not in 5.4 and earlier.
> 
> Greg, any preference for how to handle this situation?
> 
> Just add '#include <linux/sched/task.h>' to the affected .c file (and hope there
> are no more affected .c files in the other arch directories) and call it a day?
> 
> Or should we backport the transitive inclusion (i.e., the #include added by
> commit 80fbaf1c3f29)?  Or move the declaration of make_task_dead() into
> <linux/kernel.h> so that it's next to do_exit()?

One question: do *all* the arches actually get built as part of the testing for
each stable release?  If so, we can just add the #include to the .c files that
need it.  If not, then it would be safer to take one of the other approaches.

- Eric