Date:   Sat, 4 Feb 2023 05:19:09 +0800
From:   kernel test robot <lkp@intel.com>
To:     Victor Hassan <victor@allwinnertech.com>, keescook@chromium.org
Cc:     oe-kbuild-all@lists.linux.dev, tony.luck@intel.com,
        gpiccoli@igalia.com, linux-hardening@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pstore/blk: Export a method to implemente panic_write()
Message-ID: <202302040515.tdCoWcUS-lkp@intel.com>
References: <20230203113515.93540-1-victor@allwinnertech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230203113515.93540-1-victor@allwinnertech.com>
Precedence: bulk

Hi Victor,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kees/for-next/pstore]
[also build test ERROR on kees/for-next/kspp linus/master v6.2-rc6 next-20230203]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Victor-Hassan/pstore-blk-Export-a-method-to-implemente-panic_write/20230203-193548
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
patch link:    https://lore.kernel.org/r/20230203113515.93540-1-victor%40allwinnertech.com
patch subject: [PATCH] pstore/blk: Export a method to implemente panic_write()
config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20230204/202302040515.tdCoWcUS-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/368e42ba015da6c7bdd201b8fdb669e936307cbb
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Victor-Hassan/pstore-blk-Export-a-method-to-implemente-panic_write/20230203-193548
        git checkout 368e42ba015da6c7bdd201b8fdb669e936307cbb
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/ fs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/mtd/mtdpstore.c:7:
>> include/linux/pstore_blk.h:32:41: error: unknown type name 'pstore_blk_notifier_type'
      32 | typedef int (*pstore_blk_notifier_fn_t)(pstore_blk_notifier_type type,
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/pstore_blk.h:37:9: error: unknown type name 'pstore_blk_notifier_fn_t'
      37 |         pstore_blk_notifier_fn_t notifier_call;
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
--
   In file included from fs/pstore/blk.c:16:
>> include/linux/pstore_blk.h:32:41: error: unknown type name 'pstore_blk_notifier_type'
      32 | typedef int (*pstore_blk_notifier_fn_t)(pstore_blk_notifier_type type,
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/pstore_blk.h:37:9: error: unknown type name 'pstore_blk_notifier_fn_t'
      37 |         pstore_blk_notifier_fn_t notifier_call;
         |         ^~~~~~~~~~~~~~~~~~~~~~~~
   fs/pstore/blk.c: In function 'pstore_blk_panic_notifier_call':
>> fs/pstore/blk.c:114:23: error: called object is not a function or function pointer
     114 |                 ret = pbn->notifier_call(action, data);
         |                       ^~~


vim +/pstore_blk_notifier_type +32 include/linux/pstore_blk.h

    31	
  > 32	typedef	int (*pstore_blk_notifier_fn_t)(pstore_blk_notifier_type type,
    33			struct pstore_device_info *dev);
    34	
    35	struct pstore_blk_notifier {
    36		struct notifier_block nb;
  > 37		pstore_blk_notifier_fn_t notifier_call;
    38	};
    39	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests