Date:   Fri, 3 Feb 2023 21:30:14 +0000
From:   Oliver Upton <oliver.upton@linux.dev>
To:     Sean Christopherson <seanjc@google.com>
Cc:     shahuang@redhat.com, kvm@vger.kernel.org,
        Marc Zyngier <maz@kernel.org>,
        James Morse <james.morse@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Zenghui Yu <yuzenghui@huawei.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Shuah Khan <shuah@kernel.org>,
        David Matlack <dmatlack@google.com>,
        "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" 
        <kvmarm@lists.linux.dev>,
        "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" 
        <kvmarm@lists.cs.columbia.edu>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: selftests: Remove redundant setbuf()
Message-ID: <Y9185pzirL1Bqo20@google.com>
References: <20230203061038.277655-1-shahuang@redhat.com>
 <Y91VV+WWrakREsN6@google.com>
 <Y91XSZaRyqJjsg8o@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y91XSZaRyqJjsg8o@google.com>
Precedence: bulk

On Fri, Feb 03, 2023 at 06:49:45PM +0000, Oliver Upton wrote:
> On Fri, Feb 03, 2023 at 06:41:27PM +0000, Sean Christopherson wrote:
> > On Fri, Feb 03, 2023, shahuang@redhat.com wrote:
> > > From: Shaoqin Huang <shahuang@redhat.com>
> > > 
> > > Since setbuf(stdout, NULL) has been called in kvm_util.c with
> > > __attribute((constructor)). Selftests no need to setup it in their own
> > > code.
> > > 
> > > Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
> > > ---
> > 
> > Reviewed-by: Sean Christopherson <seanjc@google.com>
> 
> Thanks!
> 
> > Oliver/Marc, want to grab this one?  I doubt there will be conflicts, but IIRC
> > there are a handful of in-flight changes for aarch64/page_fault_test.c.
> 
> That is indeed the plan.

Now fully caffeinated I see that this was poking at an x86 selftest too.
Thanks for reviewing it, I'll grab the patch today.

-- 
Thanks,
Oliver