Date:   Sat, 4 Feb 2023 03:34:39 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v1 net-next] net: mscc: ocelot: un-export unused regmap
 symbols
Message-ID: <20230204013439.4vfag2kbrwpwvnpr@skbuf>
References: <20230204001211.1764672-1-colin.foster@in-advantage.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230204001211.1764672-1-colin.foster@in-advantage.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kdX4IaQhBoBA9iGexaWisKbkLu6+zRCTwhXYW+wFeIo2hw1IoxL7CNDOj03j?=
 =?us-ascii?Q?MZJP1Dw3/hD7b+olcnM8pPES8CL5xG5rksQZqvvtQ1W2EGMElAGgE4FuiW18?=
 =?us-ascii?Q?oWswxiOSKmhnZgbjUkgK0hstz0HFTGL3rZjtOHz1OEqtYBWd8b7OLbm2lRk4?=
 =?us-ascii?Q?lM5I1o+ZIMgdrqlF7bKsqwv1R0WeRavFbOi3yPqeTGD0Q52i+WOSSNN1aOe4?=
 =?us-ascii?Q?jMcDRVI5WMU0JZ/iB8V49GgKg9c4MzwFozeOVWoKBTche/ZgYqs/BbvUpa1O?=
 =?us-ascii?Q?W1qR4q6PrXy6uM4z2kA+d3K2hPY4aWdLVVoB6HxKqmp5fKI28j5qdqZxZdaY?=
 =?us-ascii?Q?jzVwrZeXS+VI5kJmCskcKH/Jb1SeJaPURxOX1RgeD9ZRQrrfevxtdaRdCq9i?=
 =?us-ascii?Q?eBANTKSkJG7EPNEsIrM7wlv9HLryo5zDih0ulofcHBw7IlFwL8p7f5CNt9je?=
 =?us-ascii?Q?dyheIs9dZt3ojJnXSH0p3p7BR5zHcpYxPTedy7mRM29LeJF1sKHYdNrZgBuH?=
 =?us-ascii?Q?mZut0QiHp2yPk3FaRHK71jjBBjtBB6VHyLzgYgFLRQPxJexPyIBVmjDG+QyS?=
 =?us-ascii?Q?Z4r8roYS6MdyG8l7Kqbf4lEqU9xnq9tkuCdYlgsV2PtgYVamF2p9CrYc26Tl?=
 =?us-ascii?Q?TFIXNwisPDIa8a2Faado82qZw1kVkG12x01Hz7V48ZyYDVRclEe+GjbDqptX?=
 =?us-ascii?Q?kjH96WKEpG4MsEg67yTxBSReC0D6xLunKv4dkX1Afc+3X+Ga3mTgSGV/yw7U?=
 =?us-ascii?Q?Rm18vryLhVwxbE7SlB+9RPgqRDc930mwIAsEahdag6q9JRVmyBJan4ljE5cR?=
 =?us-ascii?Q?52Xinva+k7zMLZmSe5/Ms52KtV7AQtTdiZjNs5BhYfAA5rvNvphftBRotC7l?=
 =?us-ascii?Q?VTw15yyRYNXZWfCMM+dYUHkzENwHV7gEI/46T//fgf6AL1qgOkx2OUvjsuV/?=
 =?us-ascii?Q?Wf3GkoSjBEhFzNX7BvNp/wg1AZnoXb00O5jZk/VgafX7tiVpeg3tqLS3oSl8?=
 =?us-ascii?Q?9BHuBK0MCIwcEZYRF6PB1XuKU4fbCLsgyEJMDUJHwcIddNTO2EssBR2e6rn6?=
 =?us-ascii?Q?1cYjv4XIj2u1gvM3AsCPRfjbYKfxxVgv5j8I520JZPknMsowBpGjITSI8Af3?=
 =?us-ascii?Q?RQE3U9jIffiCSWSIYRgMWz+Gr2phTRrE80NjmqaEZAAnkyuptQr2Ct0f5qB5?=
 =?us-ascii?Q?rHmXDP9flEugUxbS7skNa5q4vY4klGYobkMWXVz2nW/VgAd/muBAp4SzqFkd?=
 =?us-ascii?Q?RuV+3AZHLvvKFzCbTctJnbExVBdam75WL1e2RnK84uz8YP/wluvh60wAdZ1n?=
 =?us-ascii?Q?tLFqtZ2Bh86doDVuh3gmq/0fk9a1qtA0MTbD+SH2W7MDRdrp81L9y3oiM0WJ?=
 =?us-ascii?Q?VkHqEnfHTbcRhrGgpgPEr9DZGe6okrFwZQ5Yu7/7YU9XzgGrNQzLsEUORSe/?=
 =?us-ascii?Q?PnLx01vKzSTMtWgg7KuvGc4iASFHFo+5Xk9+xQASeO9mobSI811xddFkBexw?=
 =?us-ascii?Q?DOFMy6d9EIw0Ccu/v8SH5rUeuqgo80F+9Tkl2qw3yu9bbS5vliEpetA1AtqU?=
 =?us-ascii?Q?rGeqTDBHwR/z1+4IbPNVsqS673Bd3RE9bUThHzQwaaL2Gg8X9lkRi5rMVzWF?=
 =?us-ascii?Q?Ag=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 454e1d72-9a00-41a4-60ca-08db064ffd4f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 01:34:42.9765
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 13u3wfndRuPgv0AjyEja+yJbWBrEk+TCoCCbi/KIwKlrloeYj4wvkDxsFAHNzqqrbIkhIIrHaL9PbWrC9RGD2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8121
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 03, 2023 at 04:12:11PM -0800, Colin Foster wrote:
> There are no external users of the vsc7514_*_regmap[] symbols. They were
> exported in commit 32ecd22ba60b ("net: mscc: ocelot: split register
> definitions to a separate file") with the intention of being used, but the
> actual structure used in commit 2efaca411c96 ("net: mscc: ocelot: expose
> vsc7514_regmap definition") ended up being all that was needed.
> 
> Bury these unnecessary symbols.
> 
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---

These can be unexported too:

extern const struct vcap_field vsc7514_vcap_es0_keys[];
extern const struct vcap_field vsc7514_vcap_es0_actions[];
extern const struct vcap_field vsc7514_vcap_is1_keys[];
extern const struct vcap_field vsc7514_vcap_is1_actions[];
extern const struct vcap_field vsc7514_vcap_is2_keys[];
extern const struct vcap_field vsc7514_vcap_is2_actions[];

I guess we make exceptions for the 24 hour reposting rule when the patch
has been reviewed?