From:   "Liu, Yi L" <yi.l.liu@intel.com>
To:     Matthew Rosato <mjrosato@linux.ibm.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "farman@linux.ibm.com" <farman@linux.ibm.com>,
        "pmorel@linux.ibm.com" <pmorel@linux.ibm.com>,
        "borntraeger@linux.ibm.com" <borntraeger@linux.ibm.com>,
        "frankja@linux.ibm.com" <frankja@linux.ibm.com>,
        "imbrenda@linux.ibm.com" <imbrenda@linux.ibm.com>,
        "david@redhat.com" <david@redhat.com>,
        "akrowiak@linux.ibm.com" <akrowiak@linux.ibm.com>,
        "jjherne@linux.ibm.com" <jjherne@linux.ibm.com>,
        "pasic@linux.ibm.com" <pasic@linux.ibm.com>,
        "zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 2/2] vfio: no need to pass kvm pointer during device
 open
Thread-Topic: [PATCH v4 2/2] vfio: no need to pass kvm pointer during device
 open
Thread-Index: AQHZOBmTn221w5MAG0K+5msUC0tdgK6+Uf8g
Date:   Sat, 4 Feb 2023 06:23:51 +0000
Message-ID: <DS0PR11MB7529C0AF0C079748413999C3C3D49@DS0PR11MB7529.namprd11.prod.outlook.com>
References: <20230203215027.151988-1-mjrosato@linux.ibm.com>
 <20230203215027.151988-3-mjrosato@linux.ibm.com>
In-Reply-To: <20230203215027.151988-3-mjrosato@linux.ibm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fR0yqHQWolRJ8LLZWjuWE7Gik6BxsVh4zRLXEg6zDrrBkANfXOLYspNARB2r?=
 =?us-ascii?Q?Q94KZ5JSOYYyocj3ZeaLyvX4J8HvZJJ9t4xH2EVAk3k80uX7P3WUI9GIAQjl?=
 =?us-ascii?Q?Mz321hmbnLrlApugeqHVyTVUCMSktTEinQLKlqHkAeRBDjW0h7odHKDW7v/v?=
 =?us-ascii?Q?X4V0wB6+sK/Oy7QACbDCKquiRCOw602v9vpysFToRewJN7WclnZNZpNR7kyH?=
 =?us-ascii?Q?7oSxQtKjkOJCL6c/zrX3J9XXpzRsURUQtp5RGOQvUiycbe5MPq3BTp/P/pQQ?=
 =?us-ascii?Q?rrhGCWMqhQIddE7Ow/hLo8IGeKDOF9vnE/aBkzHlOYRk6HQGoyHjbjAcvXHq?=
 =?us-ascii?Q?gQ7HqFLtdYf4ew2XYCH46i/qYirWuH35uTZNsQGKdxQVCIQPBWu1Jrg/NOfH?=
 =?us-ascii?Q?+Lhd9GzelWf6z+9QucGM4PowOwGcF7UlZfkFfcV5h0GI4X5leWSKtN9P6ipY?=
 =?us-ascii?Q?cKyDXwqf0Z5mUXY/qVJNFH7HMT5npX+TUCuk43yiGgkf/kC+NWUB0JL1ZaRK?=
 =?us-ascii?Q?2yf3bSu3xUllIvzjUbMcBICZFIs1YhFxqFkeV4mbrbzZrPBft5olweb5+MD5?=
 =?us-ascii?Q?c3aChKCnFXtMyEghHmQPCIB+i7GSJ/x+s+Mq9J4aDnmEjit5UHamB8oTt0B7?=
 =?us-ascii?Q?9+ywU8tqyG+o3GJ7Rm6o2D3bLT7qZTMa32onMed23v624HaD9d/6YWWY3F06?=
 =?us-ascii?Q?+OkUHRZEPeIlIWbCOrGr4XHoWTW2HEufJb6cGKrXoy0rTiZVdJfhJ9oV8YU0?=
 =?us-ascii?Q?XHgxnyMK7a0SizD2io6c95kR/kDsnOpJCAr54sBDDXzq6zzUoANfGZwCg/+X?=
 =?us-ascii?Q?fNx/BYk90ryEY2sHXsGZP7FKCxaqO6NKD4EM92PDfgIZirq/Aih2xvFnEdi6?=
 =?us-ascii?Q?+at3q8Z8NXNOwFUJMt7P3rhTB2isreSjATrbL/xgn5kuyV3qwMpFtwW+/ms3?=
 =?us-ascii?Q?8kkYBRT2Tf0tIJ0Gxazw2cUMDqsza1jWz2HfRZ9fiSaIQdX+y4ad+ZxTyRWD?=
 =?us-ascii?Q?s5PFWsiaKyCbey7csHfuCrhZrhkTPun/4hClDYMCdUrdqbYyqrv53mcz5B/D?=
 =?us-ascii?Q?OykUdvKiQl2M6eo8Fp/NUp6JxTe58P+JZuaxUAbm1bJrk93IrVI3h1xT8GrM?=
 =?us-ascii?Q?xxDjcFbc8hymtgP5daVnmUniPK9ytKnraG90s5XbjP1gyFjuBfGS52jUbY1d?=
 =?us-ascii?Q?0ZV7mtjz1NR3kQ6e9dwmM8TzNEjtPJuoliRPcQtmmS+eOlI1r9RJIUBe3SSH?=
 =?us-ascii?Q?UL4rATggLOGc31L532ye324toRBa2wEUxx/XA+lJ2yFEBiveTnpEZ0N5nCdv?=
 =?us-ascii?Q?JkB7chkRQRAxwrLj+BIQ0MVBxwsMq3Qkbk8ABnsIzcc2xqwcQ7gyQ0HBkBtS?=
 =?us-ascii?Q?hbvUmNKKh3+G1uCFPgsh8IAnXRGp7gHg4vCdf5hxyRTQUnAAH0/LYERqpS4B?=
 =?us-ascii?Q?FouVMrgil1gFcOn2F+3Bg4b3uZyoFjYBIYM1pnRjs4cxrt4jdOnZXRY0ZIv2?=
 =?us-ascii?Q?XooQ4H3B4OAuP5txu5nBJ1XwcnZuaI8yOc4XQwOyd2Obs8VxCa4m7F5Az8Cu?=
 =?us-ascii?Q?ItnDFM9HCueYNepR23EFl3ku1PTOGtKPhE+4FhYF?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd61d9ea-c9b6-4752-e366-08db0678625c
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2023 06:23:51.8685
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8OucVwq0R8zIwRIR2dGt8Z+j4VSVu0gExEZcoiZHyLvusgKYIZ306eKOy2DHvkNzwd1rpD07mIKlEupg6Ef3zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6315
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Matthew Rosato <mjrosato@linux.ibm.com>
> Sent: Saturday, February 4, 2023 5:50 AM
>=20
> Nothing uses this value during vfio_device_open anymore so it's safe
> to remove it.
>=20
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
>  drivers/vfio/group.c     | 2 +-
>  drivers/vfio/vfio.h      | 3 +--
>  drivers/vfio/vfio_main.c | 7 +++----
>  3 files changed, 5 insertions(+), 7 deletions(-)

Reviewed-by: Yi Liu <yi.l.liu@intel.com>

Regards,
Yi Liu

> diff --git a/drivers/vfio/group.c b/drivers/vfio/group.c
> index 98621ac082f0..0e9036e2b9c4 100644
> --- a/drivers/vfio/group.c
> +++ b/drivers/vfio/group.c
> @@ -187,7 +187,7 @@ static int vfio_device_group_open(struct vfio_device
> *device)
>  	if (device->open_count =3D=3D 0)
>  		vfio_device_group_get_kvm_safe(device);
>=20
> -	ret =3D vfio_device_open(device, device->group->iommufd, device-
> >kvm);
> +	ret =3D vfio_device_open(device, device->group->iommufd);
>=20
>  	if (device->open_count =3D=3D 0)
>  		vfio_device_put_kvm(device);
> diff --git a/drivers/vfio/vfio.h b/drivers/vfio/vfio.h
> index 24d6cd285945..4f39ab549a80 100644
> --- a/drivers/vfio/vfio.h
> +++ b/drivers/vfio/vfio.h
> @@ -18,8 +18,7 @@ struct vfio_container;
>=20
>  void vfio_device_put_registration(struct vfio_device *device);
>  bool vfio_device_try_get_registration(struct vfio_device *device);
> -int vfio_device_open(struct vfio_device *device,
> -		     struct iommufd_ctx *iommufd, struct kvm *kvm);
> +int vfio_device_open(struct vfio_device *device, struct iommufd_ctx
> *iommufd);
>  void vfio_device_close(struct vfio_device *device,
>  		       struct iommufd_ctx *iommufd);
>=20
> diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c
> index 28c47cd6a6b5..3a597e799918 100644
> --- a/drivers/vfio/vfio_main.c
> +++ b/drivers/vfio/vfio_main.c
> @@ -397,7 +397,7 @@ static bool vfio_assert_device_open(struct
> vfio_device *device)
>  }
>=20
>  static int vfio_device_first_open(struct vfio_device *device,
> -				  struct iommufd_ctx *iommufd, struct kvm
> *kvm)
> +				  struct iommufd_ctx *iommufd)
>  {
>  	int ret;
>=20
> @@ -444,8 +444,7 @@ static void vfio_device_last_close(struct vfio_device
> *device,
>  	module_put(device->dev->driver->owner);
>  }
>=20
> -int vfio_device_open(struct vfio_device *device,
> -		     struct iommufd_ctx *iommufd, struct kvm *kvm)
> +int vfio_device_open(struct vfio_device *device, struct iommufd_ctx
> *iommufd)
>  {
>  	int ret =3D 0;
>=20
> @@ -453,7 +452,7 @@ int vfio_device_open(struct vfio_device *device,
>=20
>  	device->open_count++;
>  	if (device->open_count =3D=3D 1) {
> -		ret =3D vfio_device_first_open(device, iommufd, kvm);
> +		ret =3D vfio_device_first_open(device, iommufd);
>  		if (ret)
>  			device->open_count--;
>  	}
> --
> 2.39.1