Date:   Sat, 4 Feb 2023 11:58:07 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jan Kara <jack@suse.cz>,
        Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [RFC PATCH 3/3] nls: Replace default nls table by correct
 iso8859-1 table
Message-ID: <20230204105807.jdd2rrrzf37hns6h@pali>
References: <20221226144301.16382-1-pali@kernel.org>
 <20221226144301.16382-4-pali@kernel.org>
 <87v8leu4iy.fsf@mail.parknet.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87v8leu4iy.fsf@mail.parknet.co.jp>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Tuesday 10 January 2023 18:23:33 OGAWA Hirofumi wrote:
> Pali Rohár <pali@kernel.org> writes:
> 
> [...]
> 
> > -static struct nls_table default_table = {
> > -	.charset	= "default",
> > +static struct nls_table iso8859_1_table = {
> > +	.charset	= "iso8859-1",
> >  	.uni2char	= uni2char,
> >  	.char2uni	= char2uni,
> >  	.charset2lower	= charset2lower,
> >  	.charset2upper	= charset2upper,
> >  };
> 
> iocharset=default was gone with this (user visible) change? (nobody
> notice it though)
> 
> > -/* Returns a simple default translation table */
> > +/* Returns a default translation table */
> >  struct nls_table *load_nls_default(void)
> >  {
> >  	struct nls_table *default_nls;
> > @@ -537,9 +419,22 @@ struct nls_table *load_nls_default(void)
> >  	if (default_nls != NULL)
> >  		return default_nls;
> >  	else
> > -		return &default_table;
> > +		return &iso8859_1_table;
> > +}
> > +
> > +static int __init init_nls(void)
> > +{
> > +	return register_nls(&iso8859_1_table);
> >  }
> >  
> > +static void __exit exit_nls(void)
> > +{
> > +	unregister_nls(&iso8859_1_table);
> > +}
> > +
> > +module_init(init_nls)
> > +module_exit(exit_nls)
> 
> [...]
> 
> Do we need to merge nls_iso8859-1.c to nls_base.c?
> 
> 	obj-$(CONFIG_NLS)		+= nls_iso8859-1.o nls_base.o
> 
> Something like this (untested), maybe cleaner.
> 
> Thanks.
> -- 
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

I will look at it.