Date:   Sat, 4 Feb 2023 13:46:03 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Daniel Machon <daniel.machon@microchip.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, lars.povlsen@microchip.com,
        Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com,
        joe@perches.com, richardcochran@gmail.com, casper.casan@gmail.com,
        horatiu.vultur@microchip.com, shangxiaojing@huawei.com,
        rmk+kernel@armlinux.org.uk, nhuck@google.com, error27@gmail.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 09/10] net: microchip: sparx5: initialize PSFP
Message-ID: <Y95Ti6oI2gC7bA8Z@corigine.com>
References: <20230202104355.1612823-1-daniel.machon@microchip.com>
 <20230202104355.1612823-10-daniel.machon@microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230202104355.1612823-10-daniel.machon@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gxYcuRkri4yEed7sNoEEr4EUnO4R0NVna6qjN7ADxylWvy1CqHsUgdqPqrcA?=
 =?us-ascii?Q?alWl8OCCR3vUD5srzujYiu/PDAUZ1wsp1zASyY5zwKwnaKMg8M9Ka0bXYUQP?=
 =?us-ascii?Q?bHAPxNtAPJShHISdMLmXpgX4rImfy8SFByTOtKHFaJtfyl4PZXE89Akr+ONz?=
 =?us-ascii?Q?y1VMetQyvNCs6r1dL8oZYLCiSTgZDMeTsRAWOimV2qVz96qtFXTYHnozJ7BK?=
 =?us-ascii?Q?84IP9vd0xnRBl/ZUhaHejxdjjvPSxcSgxr5fokUxXxAU6ergL28+AzQ6c3tk?=
 =?us-ascii?Q?ZiW1SXo2YzQ4epxQzkbH9eXIShr04oI7+lDLnVt143ISnuBTiaxs+nJK75OR?=
 =?us-ascii?Q?4lo8CbBpAniDtKw2R2LuH0c/35zDegJCo8v2j/Pz0f3wkoDjfpv65Lb2JfFZ?=
 =?us-ascii?Q?sTSiF2+DW2p2Qix07xcQTP0C6NA6B04uwFC+EMdqfeUEpeaT6Mlakv3EoHaF?=
 =?us-ascii?Q?8Hj6SCLTl2jrz3OkjW28TwYkuTbUhyxd6lzaj045c0aIiMih3NlIvrq/LtlI?=
 =?us-ascii?Q?35uiSIapf2b13Bx1lFwbCeTs1GHuWriC6tIsFl09bZalIFw+o5Jzaoy3J+0p?=
 =?us-ascii?Q?fqnbTfzl4Cw3irbOCdsInIgedbgW9K00mTYcElUqf2d3XhMf6TyiaQ1J5fxt?=
 =?us-ascii?Q?OWs+rd1xXBLpdSQtsheKY6OWCjrLYvZ+hhZdTO0DX/OV+zFErWeiafCqhFTh?=
 =?us-ascii?Q?u/50nn8y2dq787wAFxWNjF3SxZFLM6QTxpM1kPAxrVi9uhau6XXv7XAW2l9H?=
 =?us-ascii?Q?MsX5Tj+ph682n1XC+iknaDQIFsmuCX+H7XEzHOEfeX4EPEgWlghxRAhfjfis?=
 =?us-ascii?Q?+pbUq6MOm9LngiVhzKo3/BObZ7EU2WUMCrfL57ILsSFkmofSt//ojDNbtK6v?=
 =?us-ascii?Q?ENDiW3wB9l/M56IxtWgCrF3FZv8SxIbkTxSCeAKSeiH5kVrNc2vyfeS8wFrE?=
 =?us-ascii?Q?1XJuzFvlOQvi8JrPjJQ803Vcl/0P8ogHTBm96DDWMBCYd3vUbgGX+J6FlKG/?=
 =?us-ascii?Q?/20t6Toug8iUHwQQ90iwWrOW2sPWCuDVZGA2yXA3WgzwERgScn0oamvaHHpJ?=
 =?us-ascii?Q?5/7z6696JCNEXjCmgBre6nM6sT6Txgm9rCVZVkek3PNsuJaw4+foxZ9US5SA?=
 =?us-ascii?Q?t4KcjmtIrL4iLvWPzHo+EVjq4TCaGMC37kxje5FceYRaYRnUYuyTpjj/o8E7?=
 =?us-ascii?Q?3lk3eF+4LX35ZLfGhadimCmylkg2vgR/Zcazc2+aZSwjlYUQ9m+NaYWWe8c4?=
 =?us-ascii?Q?RQPp2sH2JVjwSiMaohPsc7lyYpsjYlF88egy+eWfFJzQaRq8ahlO8UUcSNsy?=
 =?us-ascii?Q?XZE4kD3ducTqSD2Sw9KpRsjFznBXE8K14tc6P+uyG7QA+mRhD7LDdP9Lahri?=
 =?us-ascii?Q?Myehs1+VrrNtNiEOmPBBeufalscbyck+DFPyqDflRH8EZRzWc15m9mtO7zAD?=
 =?us-ascii?Q?eSVPgjdTt56m9EyN4MWeuwWjJarpbCdlO9my2wuEcG5z9qvYOQFP7wxb9nRc?=
 =?us-ascii?Q?VBRZxqWqPxLKUIuWT8XTWcGN9WZttb9KLmGJ0oSCOtM5FKFby1LBDjR3aqiE?=
 =?us-ascii?Q?4QdkKc+c7XyeFOZxgtzqWgLTxgNDjR+W/4hJnq1CI/9d8Fb7CbqpFSafUds4?=
 =?us-ascii?Q?7zl/wH+yBhH/mi+axJyvde1z61u0jgYVHyIHx2zpmoimx2nXC25dvfSaG6bn?=
 =?us-ascii?Q?jK6P+w=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4a244d9-8946-4cdf-8e68-08db06adce37
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 12:46:16.4568
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V5wfNLtJbVaLW4MfchAGCbcd8dtqf0HY7dUDW/+jOIINqDfa4f2HtB6N0sDLjBfxdywACaNy5yedcgnX1Djp3sgc2SbuvalQxiP/5aI/uDw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5454
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 02, 2023 at 11:43:54AM +0100, Daniel Machon wrote:
> Initialize the SDLB's, stream gates and stream filters.
> 
> Signed-off-by: Daniel Machon <daniel.machon@microchip.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

> ---
>  .../ethernet/microchip/sparx5/sparx5_main.h    |  3 +++
>  .../ethernet/microchip/sparx5/sparx5_psfp.c    | 18 ++++++++++++++++++
>  .../net/ethernet/microchip/sparx5/sparx5_qos.c |  2 ++
>  3 files changed, 23 insertions(+)
> 
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
> index cffed893fb7b..72e7928912eb 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
> @@ -456,6 +456,7 @@ int sparx5_sdlb_group_del(struct sparx5 *sparx5, u32 group, u32 idx);
>  
>  void sparx5_sdlb_group_init(struct sparx5 *sparx5, u64 max_rate, u32 min_burst,
>  			    u32 frame_size, u32 idx);
> +

nit: This hunk appears to belong in patch 4/9
     No need to respin because of this, afaic.

>  /* sparx5_police.c */
>  enum {
>  	/* More policer types will be added later */

...