Date:   Sat, 4 Feb 2023 13:53:24 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Daniel Machon <daniel.machon@microchip.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, lars.povlsen@microchip.com,
        Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com,
        joe@perches.com, richardcochran@gmail.com, casper.casan@gmail.com,
        horatiu.vultur@microchip.com, shangxiaojing@huawei.com,
        rmk+kernel@armlinux.org.uk, nhuck@google.com, error27@gmail.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 03/10] net: microchip: sparx5: add support for
 Service Dual Leacky Buckets
Message-ID: <Y95VRJWV4NfSDYUR@corigine.com>
References: <20230202104355.1612823-1-daniel.machon@microchip.com>
 <20230202104355.1612823-4-daniel.machon@microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230202104355.1612823-4-daniel.machon@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cFxo0ZnIUP8Y6WjDTVGw9mXSfSWzmVgSYp0EyzloIbZcgna1lN1E5T+4AIcg?=
 =?us-ascii?Q?KyCNFUo/V52GulCilz5JSlroTKwxYXHrAA/9qDP7ueQcQi9W6A85w0UBU7q0?=
 =?us-ascii?Q?Hqd2O+i8nHmAS/wHsS6V4wdV+571evGBCqRjYEFsqzC/vBh0XaquZiMy2Sto?=
 =?us-ascii?Q?jp1nH8TxNkXMULRYp2FnjOJavKq8XaF+km/6kTi7PmoDrv165jOINslkwE00?=
 =?us-ascii?Q?efDj4pC0waM8TKAytPhLV2iF4/DcE9892O0Tq7s9wV8gSO7Rx7JRp4/hv1+2?=
 =?us-ascii?Q?OWVzXopEgBYHqDx5D6X4Eb46pzLAYEphaf9zEIv3qqIpydUrHw+aypHXRrlk?=
 =?us-ascii?Q?xYqGO6b3Jrf0NyKkqTJpZnlmwnu3eEOUwgQUnd6sZH7SnqJRa9qrfDA9Lif6?=
 =?us-ascii?Q?gB2Mkfn6a2LcUAYzBuT9Dos19UwZXvzbOEuBkzvGllEwYVDmy1Rzem7Kv86l?=
 =?us-ascii?Q?/+DyeWkUAFy4Up2zIntEo5oAAiYiulRo92ci+khfyb22r+c2zEXOur3I9RX9?=
 =?us-ascii?Q?B6vNDPewDOvk9kQaZo2sEV31ZyN6HUC6iZLuwBCq+HI72yu9y7puxGWcw61A?=
 =?us-ascii?Q?VGDcG9J0YXpEpT1ipyAd2yhOaxdt1K53y7q5XrNdV4KGancQHwiduToe44Yw?=
 =?us-ascii?Q?EPpj7ej1jSHWtG6YXz0j4QK4wOyYfz5fdn/Fj6da4srsP0Oiz9XLUN/Xy6MS?=
 =?us-ascii?Q?1NKNKeyhksxumr37OTF+il+aaZ/N1A8XjHFmb3AVwAHfskCQlKHWk7OTIJ22?=
 =?us-ascii?Q?coT65vrVOlf7zr1QqzcRay0nQ1NMMTDWYDcKtWETK3SviXpMUUXII4FVhdBM?=
 =?us-ascii?Q?yzqAcR9t5c6nxp5Tkg/qPip2J5e5d6ifSkty1ik8kfDshe3g9fUAXphKH8fV?=
 =?us-ascii?Q?0SYC1lGFCM5b4so2UWz3MKW8djpMsYWtFgZoO0CFqKwmkzQHVZdDQG1Z9tO3?=
 =?us-ascii?Q?V9HCLhla946/7P1xWwikJcARl3wFQ8M6H+wvGWs4I9TTO3ME9hOz8Brv4MSu?=
 =?us-ascii?Q?hJnwDXLW2VOgu87bNwgPeitH8VzBbZJnTZMTgK9OhzWUX6G4VVArJYCtTfgn?=
 =?us-ascii?Q?RS3vGAdVfmlUokCDdWLhjxjYwvA9XWThqoCGLD4NoW//nfHamgmcOzeg5Uf4?=
 =?us-ascii?Q?Uwc/J+APc5q+Vn3mJ0JznWBlwQwz/XnztlS3CY+NkBesEEcvKsUIGQEzidpo?=
 =?us-ascii?Q?EdA3eMgTwJ3kaB0F07cX3e2fukmME7WjbxgRU4pT+WAxc3Jwt1m/LIEKikne?=
 =?us-ascii?Q?zExzarhTEEmw7IlHfAmyhC6RRFq215cCHD/oI9xgdZ6c2em3bUP1zMKY3JJQ?=
 =?us-ascii?Q?hCdnCEnjvwT/hK1lpiHFgsmySOhlEJTIJNtgL4xMFE4RRIeDDSjc0dm4RnKe?=
 =?us-ascii?Q?rtVZ/zsiM5RQ6ffPC7rW1t0EqTId73hcZ3pI7Af11FA0IS38cIEmlSoqq6ES?=
 =?us-ascii?Q?zfVZLuWiZ55ioLqCeoiu995Ty6YHshGtydyYTu5JFdXXDXCOcSgYteWw7LTm?=
 =?us-ascii?Q?Es09pVJZJKLO9p+/TLLjsqyl9GWXEWG+/zM84qiEMjdS0hjrQRnJ7F8ffBPn?=
 =?us-ascii?Q?SXnZciAaiF2z8aurxXKfWgky5Lzxzz1dJAzd1ZTvTeKIX6RvxK9NAeogs1Ga?=
 =?us-ascii?Q?VYL54ZZQzCLB/Ob6V2vwcBhnnYb5fuaRgrN0Gz9lRGVw9jOFB+yhUna4fmKZ?=
 =?us-ascii?Q?P+whFA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e93276fd-8cdd-41a9-128e-08db06aed17d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 12:53:31.5673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TRVmdNg1s+J7rZbFhvySJv96cWPzcGfz/wNrHvCLFpYVw0x2LUzXqVuia+GY/zTk66NP9dUto/BBUCa4mkTDUxYh53fz0/hwiGWPfEUz64k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB5140
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 02, 2023 at 11:43:48AM +0100, Daniel Machon wrote:
> Add support for Service Dual Leacky Buckets (SDLB), used to implement
> PSFP flow-meters. Buckets are linked together in a leak chain of a leak
> group. Leak groups a preconfigured to serve buckets within a certain
> rate interval.
> 
> Signed-off-by: Daniel Machon <daniel.machon@microchip.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

...

> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_sdlb.c b/drivers/net/ethernet/microchip/sparx5/sparx5_sdlb.c
> new file mode 100644
> index 000000000000..f5267218caeb
> --- /dev/null
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_sdlb.c

...

> +static u32 sparx5_sdlb_group_get_next(struct sparx5 *sparx5, u32 group,
> +				      u32 lb)
> +{
> +	u32 val;
> +
> +	val = spx5_rd(sparx5, ANA_AC_SDLB_XLB_NEXT(lb));
> +
> +	return ANA_AC_SDLB_XLB_NEXT_LBSET_NEXT_GET(val);
> +}

...

> +static u32 sparx5_sdlb_group_get_last(struct sparx5 *sparx5, u32 group)
> +{
> +	u32 itr, next;
> +
> +	itr = sparx5_sdlb_group_get_first(sparx5, group);
> +
> +	for (;;) {

Unbounded loops like this give me some apprehension.
Will they always terminate?

> +		next = sparx5_sdlb_group_get_next(sparx5, group, itr);
> +		if (itr == next)
> +			return itr;
> +
> +		itr = next;
> +	}
> +}

...

> +static int sparx5_sdlb_group_get_adjacent(struct sparx5 *sparx5, u32 group,
> +					  u32 idx, u32 *prev, u32 *next,
> +					  u32 *first)
> +{
> +	u32 itr;
> +
> +	*first = sparx5_sdlb_group_get_first(sparx5, group);
> +	*prev = *first;
> +	*next = *first;
> +	itr = *first;
> +
> +	for (;;) {
> +		*next = sparx5_sdlb_group_get_next(sparx5, group, itr);
> +
> +		if (itr == idx)
> +			return 0; /* Found it */
> +
> +		if (itr == *next)
> +			return -EINVAL; /* Was not found */
> +
> +		*prev = itr;
> +		itr = *next;
> +	}
> +}
> +
> +static int sparx5_sdlb_group_get_count(struct sparx5 *sparx5, u32 group)
> +{
> +	u32 itr, next;
> +	int count = 0;
> +
> +	itr = sparx5_sdlb_group_get_first(sparx5, group);
> +
> +	for (;;) {
> +		next = sparx5_sdlb_group_get_next(sparx5, group, itr);
> +		if (itr == next)
> +			return count;
> +
> +		itr = next;
> +		count++;
> +	}
> +}

...

> +int sparx5_sdlb_group_get_by_index(struct sparx5 *sparx5, u32 idx, u32 *group)
> +{
> +	u32 itr, next;
> +	int i;
> +
> +	for (i = 0; i < SPX5_SDLB_GROUP_CNT; i++) {
> +		if (sparx5_sdlb_group_is_empty(sparx5, i))
> +			continue;
> +
> +		itr = sparx5_sdlb_group_get_first(sparx5, i);
> +
> +		for (;;) {
> +			next = sparx5_sdlb_group_get_next(sparx5, i, itr);
> +
> +			if (itr == idx) {
> +				*group = i;
> +				return 0; /* Found it */
> +			}
> +			if (itr == next)
> +				break; /* Was not found */
> +
> +			itr = next;
> +		}
> +	}
> +
> +	return -EINVAL;
> +}

...