Date:   Sat, 4 Feb 2023 14:28:21 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Eddy Tao <taoyuan_eddy@hotmail.com>
Cc:     netdev@vger.kernel.org, Pravin B Shelar <pshelar@ovn.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, dev@openvswitch.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v7 1/1] net:openvswitch:reduce cpu_used_mask
 memory
Message-ID: <Y95ddddYhqkR7b1o@corigine.com>
References: <OS3P286MB22957550350801F37FB56DFFF5D79@OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <OS3P286MB22957550350801F37FB56DFFF5D79@OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sr4wasDoIBGdJTemOAM5rYjl+QnrNIp+poitxGAGK44S0ZuhLUoecs7bLncU?=
 =?us-ascii?Q?wTYZzexk4Vbn2+qt25f+LrNvI+6JrryfrBQSjTIFiHYAu23HUTdIuUZHn2by?=
 =?us-ascii?Q?MLkfITZbyGemF1YHjZTZUdOEMPYpO5i4DQVzG+i0fCNVOKYekNbHTVXY0jVR?=
 =?us-ascii?Q?GVfBYAlDj/x2NPT3NVmonC5rZfzFNDzzy32EBcYIczDBnHeE2TlUa72ZylqH?=
 =?us-ascii?Q?+ets6LxeZTJ3dRkBW8VCQTNMGe31suV9IEbjEPnYAP9MH7H9rKI4qndf9ej1?=
 =?us-ascii?Q?LQpPu5Z5YSzQwthDmPRfmXOxfVZp+Cns9FVqnvX5jgIR5/j+4YhS+2w7drzU?=
 =?us-ascii?Q?NGPvjaVD+D70j4qU8A+eryTNZZiVoHrYYji3WXeMVH6GpGE/uIwxj/lmu1oJ?=
 =?us-ascii?Q?suJqV280sy6cF3C91Bt/SHXU6COjoKPanTbHOVJoQqgW4v0fSuggQQReuQiJ?=
 =?us-ascii?Q?Q8Ayjz1lwk+cq052EIETk+QaYvWCc/wkSbnEywIEPNhWd6H7Y5xGcil8F4wX?=
 =?us-ascii?Q?EEU8+ks7GchAzpENEIYejqqKBI6z7YzRxOgwCNlQn82CfoVDExo0/lN5uFux?=
 =?us-ascii?Q?dZkaDCsDjGy9afh+VmhQ15WeMwXUUh8O0ZI9R0R9Yayf7mDprQHc5i3cqbvp?=
 =?us-ascii?Q?5zG1ZbSG5DbhYQfIcYYfm9PpRZbmGzwVQrXmPFxEuMWxu4FCM/Qj4zjRkHre?=
 =?us-ascii?Q?hkzBtWSdhfuXtdZIT97v2Rq3O+rE5n4Sw/2p3H2rYCgTOXeAeRcEDpK8oRfz?=
 =?us-ascii?Q?LMBWRwUp7xjImRjBDQGeTB2KX7O5MzH7GciH4+l5t573DKgUfOH1svUWn53i?=
 =?us-ascii?Q?rX/aUrQ3TKmfMtqe2IP8X+871CO4xmvYlVRhS6GOCB4ETSH+RrGoHj1SEcS8?=
 =?us-ascii?Q?CN4rATt8Fd6DV9GJUVVvkz/j9ZPMav/94t7Peo1kK2quPVIGQjpdRgJRVNQ0?=
 =?us-ascii?Q?W29hPjDkfTh+f1TBbvCKlixrwhg+4A17cmpOnHOdR4cFUoNdpOPSh1gBtFi0?=
 =?us-ascii?Q?Tk1XUKKv02cFfI8B8UxcieZ2KxF8N7UOzQMXAJSG+11W00/PyeBtOgINVdoK?=
 =?us-ascii?Q?qceWddxbG7LI3b8/5XrzyPKNtmwyJPILhNR2k2B9PSj7zXRoHuMFQXNAys40?=
 =?us-ascii?Q?exCQhSmWvobh4ZPwdXvljb1vjNlVtyWaE9exon8KA9vVTidxFls36kZNoJOi?=
 =?us-ascii?Q?QRoU9vYs3Gv29BYDEGyQw9qt74G1nWBqQaVhhIvx0om/hRtj2RXI2g9Hi4br?=
 =?us-ascii?Q?RpRkv+zAsZi1U43ZG0euMp1J82C6n3BhNwKYttm6mACx4V2AQNDpvmLFUJYV?=
 =?us-ascii?Q?rOw3uvUiv8DDDCKyOC0fuY5L7wsq+4BmbguhmKAvdCnPJOKPJmNiGu7zdqZv?=
 =?us-ascii?Q?ckyVbcEgaaTZnI8H5lUL5+g6cuyEgj1Ga2jq2HWivzfG5RuJAr6mMRg/saPO?=
 =?us-ascii?Q?p+7VvB+IOtzTe+jZY7yEIGcW9m/ZhK9oXNu9t/m7WQso06DSB5APAYf6N5Wb?=
 =?us-ascii?Q?TRpoEXdgM/bkxw+CfLiURiiO4mT4gBN/M0hhSun6keKr3FwZptEGoIxnxaAd?=
 =?us-ascii?Q?tytdRC88utDSZiM762YBn2QqERY3UNRHpB/vKPXBlT/j9mltrTpNOJ06E+1o?=
 =?us-ascii?Q?Tk0nNCaMmK0eqwex/AG3gCX1aoSskVUkfz/OiCOQmrcEClqlPqBgm+zqs90r?=
 =?us-ascii?Q?KHZwww=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8100967a-c728-43f6-7bd3-08db06b3b32c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 13:28:27.9725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rN+zno3FSEoB4oxa/ikIrOIzSrSySxCkbD5YmGjDWpwwEG7qQBZiRVK0i4JX6JdwlI2bd37Q69RnUAeXQYCUDzKsCYMMpAZjxxyBdNh6b4g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3675
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 03, 2023 at 11:42:45PM +0800, Eddy Tao wrote:
> Use actual CPU number instead of hardcoded value to decide the size
> of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason.
> 
> 'struct cpumask cpu_used_mask' is embedded in struct sw_flow.
> Its size is hardcoded to CONFIG_NR_CPUS bits, which can be
> 8192 by default, it costs memory and slows down ovs_flow_alloc
> 
> To address this:
>  Redefine cpu_used_mask to pointer.
>  Append cpumask_size() bytes after 'stat' to hold cpumask.
>  Initialization cpu_used_mask right after stats_last_writer.
> 
> APIs like cpumask_next and cpumask_set_cpu never access bits
> beyond cpu count, cpumask_size() bytes of memory is enough
> 
> Signed-off-by: Eddy Tao <taoyuan_eddy@hotmail.com>

nit: I think the correct prefix for the patch subject is 'openvswitch:'
     And there should be a space after the prefix.

[PATCH net-next v8 1/1] openvswitch: reduce cpu_used_mask