Message-ID: <OS3P286MB2295A2F3A8B58054ECD87D8CF5D49@OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM>
Date:   Sat, 4 Feb 2023 22:47:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH net-next v7 1/1] net:openvswitch:reduce cpu_used_mask
 memory
To:     Simon Horman <simon.horman@corigine.com>
Cc:     netdev@vger.kernel.org, Pravin B Shelar <pshelar@ovn.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, dev@openvswitch.org,
        linux-kernel@vger.kernel.org
References: <OS3P286MB22957550350801F37FB56DFFF5D79@OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM>
 <Y95ddddYhqkR7b1o@corigine.com>
Content-Language: en-US
From:   Eddy Tao <taoyuan_eddy@hotmail.com>
In-Reply-To: <Y95ddddYhqkR7b1o@corigine.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: OS3P286MB2295:EE_|OS3P286MB2165:EE_
X-MS-Office365-Filtering-Correlation-Id: f6bb1575-a837-4049-b73d-08db06beb225
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kv78iYxasOruSKxeTJguyLrZrQt9ftRpi5qBbQdKpO3GBuFZW3HcBJpiB3ed4LSVmCrAIZwQgXAOPFxtbSN/l2LkAzhh5IFP0E+F3XdTQcYiC3mfMt8klehs/C7ScI8RtUyUyZbqnkM8Q4wJsIKUCu7NAcYku51eCipkM5/krGAOkCClHE5gTCdoGKJ/zXBLu5xfFIHTo/1Qq6leltoD0R+x8BolywVG7XmThWvvHS1aAxc0UKPY3Wb/ATEtvlH4TccCF7gMbGq9W0IBaA1eGJCtMhCpDakdlv/ar6SPcSJNuHQWcMUUcZCLj90Z84JAPVxOZ363gyqYETr53IAlqXc2qPzjSSW+eJ9Vq2nhUH1fgCxq3qypi5kfNirh6dfJ73CdP7n7Cle8YHnbcpOAWYsW0+STcIwBq8BofI84XCuc5qekPQsK+rkatBQwhOkY5IO+Q3iywOnfIA5rEECkwQiqXsbkjcOJ4Wy714xjPX1naTjRXw5x+mr5egBs5q5ZcM7e1bwmJogjqXRHML3pv3QgC0MQajgDNxSriQygWA+O7QvmhfI8LebdpRDs3JDrLESJ1x4HMmcttrzHSEhLfT7MeOoCFGfpXrjGSQz+B1LyV4i0wO5NvKbXGE7ZsP4hvjnlsUbsAjfVSI6vMkjvDQ==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mmw3K01NaEdrNlBWNmd6TnJnVXRlK1RoYTVTaUVid3dQYVdvMTRTTUdaRnhU?=
 =?utf-8?B?eXk2QlpHT1R1dTZ2VFhUTUc0bFN0dTl6dXROM0MwdDhZV1BTQnR2Vm9mOXE5?=
 =?utf-8?B?bmcxTUF1aU1lOERIZ0RKcmhyMEdGK3hJTVRWUjYvUXRaOHRlQVVvcjRsalJo?=
 =?utf-8?B?WU5SSktETENqT0N5eUxodzl6Z1M3Y1FDU2N4M0JhUjhlUDRXQjRGMzBRSVBS?=
 =?utf-8?B?UktyTDc0WDNYZGN6TGY2WktKSHNXYitKTDd1WUhuNldCUVFmS1B2OG5CQlJZ?=
 =?utf-8?B?bHphQTdNd0Vkbk1xV2twWlhLK21sVmlMWXdlUi9wZDhYZ3FrNG5HbnNmdDRz?=
 =?utf-8?B?TDZzV2wzTzFqSGJidHFkSG1XSkx0RGZUczFjTVBud0dZa3dLcy9uT2pkbVBF?=
 =?utf-8?B?QXRDZ1VMdWdFL1JCamZyVmFIcElZaTFIdEFaNkNYZ0lxcEZRczUyaVpCQ2pO?=
 =?utf-8?B?dms4L2VrZUF2Nm54NHNrQVpJTHZneHhYMVNETmtQOFdkZGtubTlGMW5xRUlE?=
 =?utf-8?B?em9nMmRrZDNGNWtJcStYbkVoeDVjbWlCa1ErUkhDdGZaYUlHaFV3cEtwNmVI?=
 =?utf-8?B?TzRKSVpoRmJ6eHFhV1pQWTFPQ0NLN1FTWHRHMGl4K0hrVnltY3J4YldrKzBh?=
 =?utf-8?B?angxV1cyR21pLzZqU1lGRkYyY1JwN1p1emlYVWJkMVM1WWVWYm0zTFdUUjQv?=
 =?utf-8?B?d3E3TWovcnNrY1hlTk8rL3dRa25iRlc1RllsYWVoVWdGb3M5ZW9yTDYyeWFi?=
 =?utf-8?B?ZVhMZVZsdTZ0YW81K3czSWc3TWRwbkRkOWVYRGNiVkZjY3FtWEZGWmhaQk15?=
 =?utf-8?B?NWFvTGNBZUx3VDBqK2xVTkx5dUI3OHBRNFAxeG1ic1FsWDh0SW1Gb3lzdzcx?=
 =?utf-8?B?d3EvcWpMTnBjSVJqVlUwTUZrSytMYlJQK0RFOTVPYmpLNDhYSlBzN1JhQ3JL?=
 =?utf-8?B?dFhsYWhtTTlNc2hUS2xhd2hiQjlpUXhCSGtnWlV2dTlTb0dhZFFNOG9LUi8z?=
 =?utf-8?B?VEFtTDF3dE5tMTQzZ3pXRlZYL3c4UTZwRlZDRXJ1cjI0WHZZaHF2aGkvWjdn?=
 =?utf-8?B?NWFwYlJZR3ZickFNY1pSZFhCd0xYS0duWTNnRlZiQzY0SWFURDlGOXFUNWVS?=
 =?utf-8?B?QTVTeUxWYlVUb1RzNklWVExNR2g2UHVrbHhxYUt3NUlNaVF5bU9IRzRyeDVp?=
 =?utf-8?B?K2dvdTZiak9SYStoVTZ5b3RkeFNuMGxHTC9uWkt1UnlWTTBjaEo1WmdFSEtY?=
 =?utf-8?B?UDRHSmRacmxrMElNZkk0ZCtQZDMra2gxSHZwNDFET0d1dlJYSFlPYThQeS95?=
 =?utf-8?B?M05yNWNxRGZHRVFHdlV3QU9UOHFnbXpBbjNzbmRKMGFBaG9aNUlVTXlsdWUw?=
 =?utf-8?B?dzdoZVowblUwZ05JK0FBaHVxSzJuVEh6S2dLRGhDSUZnOEIxL25WWC83QjVy?=
 =?utf-8?B?YkVacWx0MU9NY3NweFJaMDZvbzgwVGNFMXVhYXIwRGl4V0pvRFU4MWx2VGpH?=
 =?utf-8?B?bjltbG5JcE1ObE5FTjIrUi9hRlN0amo4UWtTdlRVY2dGOGtObkxrQVkrTWo3?=
 =?utf-8?B?VzRaM0pnWHFmeCsrTFdseC94cWtvdjIrWnRHclh4Qm5NRmJjVUVYbVV3a0Yw?=
 =?utf-8?B?UEQyQ1JJZU9FV25kMjVncHJiUTNZMXdyYWNaOTR4LzZKenQrVkptS3F5UzZy?=
 =?utf-8?B?YUhSV1QrVlVtc09Gd0RhazU2RnJWZHBORVBhWnQvbXlhMUFLekk1NkF3PT0=?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: f6bb1575-a837-4049-b73d-08db06beb225
X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 14:47:10.8082
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3P286MB2165
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Simon:

     Thank you for the time on the review.

and i looked into net folder and get various results

'net:', 'net: gre:', 'net: bridge:', 'net: thunderx', 'net: sock', 'net: 
genetlink', and there is also examples as you suggested like 'devlink:'

similarly, in other folders i see similar inconsistency, mm folder is an 
example.

I turned below links and did not find item regarding to the prefix 
definition

Link: https://docs.kernel.org/process/maintainer-netdev.html

Link: 
https://docs.kernel.org/process/submitting-patches.html#submittingpatches

Going through the git log in file net/openvswitch/flow.c, the 'net: 
openvswitch: ' prefix were used in previous commits.


I think the fix contained 'net' keep the prefix from name collision and 
better keeps it consistent with its neighbors in the same file

And yes, there should be a blank space after the colon, i miss it, will 
update the revision, after we nail down the wording of the prefix.


Thanks

eddy

On 2023/2/4 21:28, Simon Horman wrote:
> nit: I think the correct prefix for the patch subject is 'openvswitch:'
>       And there should be a space after the prefix.
>
> [PATCH net-next v8 1/1] openvswitch: reduce cpu_used_mask