From:   Alexander Lobakin <alobakin@mailbox.org>
To:     Tiezhu Yang <yangtiezhu@loongson.cn>
Cc:     Alexander Lobakin <alobakin@mailbox.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Remove CONFIG_MIPS check in Makefile
Date:   Sat,  4 Feb 2023 15:56:41 +0100
Message-Id: <20230204145641.66417-1-alobakin@mailbox.org>
In-Reply-To: <1675328702-8328-1-git-send-email-yangtiezhu@loongson.cn>
References: <1675328702-8328-1-git-send-email-yangtiezhu@loongson.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

From: Tiezhu Yang <yangtiezhu@loongson.cn>
Date: Thu,  2 Feb 2023 17:05:02 +0800

> CONFIG_MIPS is set as y by default in Kconfig, no need to check
> it in Makefile.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>  arch/mips/Makefile | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index 490dea0..6ed41c8b 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -316,11 +316,9 @@ KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
>  
>  KBUILD_LDFLAGS		+= -m $(ld-emul)
>  
> -ifdef CONFIG_MIPS
>  CHECKFLAGS += $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -x c /dev/null | \
>  	grep -E -vw '__GNUC_(MINOR_|PATCHLEVEL_)?_' | \
>  	sed -e "s/^\#define /-D'/" -e "s/ /'='/" -e "s/$$/'/" -e 's/\$$/&&/g')
> -endif

When you run `make clean/mrproper/distclean`, .config is not read. Thus,
this block may actually provoke errors when cleaning, that's why it's
guarded.
At least it was like that a couple years ago, can't say for sure if
these guards are needed, but better recheck.

>  
>  OBJCOPYFLAGS		+= --remove-section=.reginfo
>  
> -- 
> 2.1.0

Thanks,
Olek