Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7C8C61DA4 for ; Sat, 4 Feb 2023 16:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232299AbjBDQXO (ORCPT ); Sat, 4 Feb 2023 11:23:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231862AbjBDQXL (ORCPT ); Sat, 4 Feb 2023 11:23:11 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16FF615552; Sat, 4 Feb 2023 08:23:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F062BB80AEC; Sat, 4 Feb 2023 16:23:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70506C433EF; Sat, 4 Feb 2023 16:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675527786; bh=GW1ACmXKBNrpKVcgej0zSNr6jh0aqwGGlnfV1C4ghAY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=pSoTIYf0iREhh6mkf+z07L0TFNOBOEeRJfTsVFMjwrTSVUCNw+JYLBzG4avN7WFuk lYAFX1DxLDStHq57p/ZnovAo35FDbMoezbaAYFMDIKV9erAXBN+6D+1K98EcYDJ+PT o0g382x4E96BW4NbIj2bAQnFGL77IKankPqdJObPKF/UqPhyh0PV3PjMZXiLi89Ibn 793v+PW3fhfb2JRPQuQLls+itHkVjBjsmW7gJOuKsQX7R2M/sP3Aw/WVRkIepM/SSG Ho2q9kDAB6q1lCo08+Cw3sEanI7FfaPCgqTNvLsZJ0S0PptsnfETVpf4U6k0VetsuB 8uayRn7y0GcYA== Date: Sat, 4 Feb 2023 10:23:05 -0600 From: Bjorn Helgaas To: Lukas Wunner Cc: Helge Deller , Zeno Davatz , Thomas Zimmermann , Javier Martinez Canillas , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH] Revert "fbdev: Remove conflicting devices on PCI bus" Message-ID: <20230204162305.GA2098741@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230204085018.GA31758@wunner.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 04, 2023 at 09:50:18AM +0100, Lukas Wunner wrote: > On Fri, Feb 03, 2023 at 05:09:09PM -0600, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > This reverts commit 145eed48de278007f646b908fd70ac59d24ed81a. > > > > Zeno Davatz reported that 145eed48de27 ("fbdev: Remove conflicting devices > > on PCI bus") caused a console hang. The machine was actually still usable > > via ssh, etc., but there was no activity on the console. > > > > Reverting 145eed48de27 for the nvidiafb on that system fixed the problem. > > > > Revert 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus") since > > we don't know what caused the problem. > > > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=216859 > > Shouldn't that rather be: > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216859 > Fixes: 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus") > Cc: stable@vger.kernel.org # v6.1+ Yes, of course, thank you, Lukas!