Date:   Sat, 4 Feb 2023 18:12:26 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next] net: lan966x: Add support for TC flower filter
 statistics
Message-ID: <Y96R+oEaZijtdaFH@corigine.com>
References: <20230203135349.547933-1-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230203135349.547933-1-horatiu.vultur@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7nE/VaPSLE8L/mAHXMg/OVhvYEKGle1PxIDqgLtQBi5rfOGfK2OsCyjs9Xwq?=
 =?us-ascii?Q?CwpITpRPVW5vonJxQApUgmY3OcTGDpBNRvJUrD4q4nP+ekGWmwhMvsEiRfsa?=
 =?us-ascii?Q?KaqkpxNp/g2myq7kSE/6K21dV0UsD4x3FF5fXsupZGxu1k6P4MmBHLUj+GBg?=
 =?us-ascii?Q?AePpqniAgdhSQN9xSyvrcoIHMRXl3PZNJjqy/ycNNP83zLDL/egRaIol8hmc?=
 =?us-ascii?Q?lQluv4YjulcZlT+8/tAgEP15D8ntR2MqWSdT7SW+mMUakDEoIYdyXkReSNdm?=
 =?us-ascii?Q?aY5KM3I5A0BaFrSXvSx7l1H/HacIc8BhGHangfYQh1sxYQPixinjlMCtH4D0?=
 =?us-ascii?Q?L/GtsAgucn6lU7hNHnFztwjFwI/1R0K7UOzY0cAKveR7OjrqE3ADaAnPX9vM?=
 =?us-ascii?Q?MCJmWMlW2VIA4u0BPjN9Di+EdZ+05jjqbTNz/KpdLytLeRFgQkBVEBVQS1Ht?=
 =?us-ascii?Q?MvG7+PLMUPUvBRJ/xVbTks8tcqfyPvryGXYgz8DPaMpAgK4LrfAB828861x2?=
 =?us-ascii?Q?b7FQy20GvJPBTPG/eKjm3qGs0IswsKznXo0dwSTIg8qSqOQJvS/B4MEWGUDr?=
 =?us-ascii?Q?X0EpNjNGL6GQki+fkt5mlbSx4b1lG3Yj/ByIzBVEqqEra1RxKL6+BQ5N5tVk?=
 =?us-ascii?Q?S0IWELQN043e60RIZxelGmalrc4AdQqemYRsAMftq+r07fbgUUTzvAPbzDY6?=
 =?us-ascii?Q?alvU4AwxQveuPzdPy2yDEhZVFp0opeLhuXkw/PKPgUx1OItQhPm+jOmrR7Jc?=
 =?us-ascii?Q?Vz/KoIOscw4K84GbAi9j4RJ/pSYdBd+cIad8Lnyfe0YGCNJvKjJuNYNw14hD?=
 =?us-ascii?Q?EwfTtXlxU8M01nbEZ6CfhxE2wB2wEo/IQNm+Wu3dziYQbMsB7gQ2wZohelPp?=
 =?us-ascii?Q?l3U6mcNp0D8jxChJAwfoxh5yEWSAYwkWa0P6EII7CGc+aNiXHq/EcT4DkjHO?=
 =?us-ascii?Q?RDsriyuzEWgf+//uFSJVqV07FtiMIspjY3G767UcFVq303jkQamtbfAmvl4h?=
 =?us-ascii?Q?28XOLvCXzSotPWiwdSAX3GZJIPxMbMOQ5n9VD8l8RahmF1HnSCUMaFNMx4Dp?=
 =?us-ascii?Q?PFmM3FtK+pgRipk5ViK8zd8Kqn249CvQgI5eAMBWvqYGAS2dHn2FIw3uq4fU?=
 =?us-ascii?Q?0XFJo0b4EY2FXrKo8VXMnxi5E7Axfnn0x6oKyDGKh4q/OhEUs0plO0lsD6q4?=
 =?us-ascii?Q?LfQ/+ZEtnMpsrSflFx2BHV9Q5d50sIjhcgtLXm2mY0zo4rsFV2+QosgMGI0w?=
 =?us-ascii?Q?zwlKL13BKief55HyGnQNvD3MFhhviscPjp4RpsCvdY+Q6F5AqI3zcAEW77ed?=
 =?us-ascii?Q?z/g4xpotVK0cHyjS3eLj8ilhqsRfwr2hPBiHqXFbTGvHVYOqkbRYKj+jiDZF?=
 =?us-ascii?Q?PfEHj9P+x7U7lJb0sY3nWY81MgUGkkYxQeeUD3bCFcPBmdwjPa/ber663oF8?=
 =?us-ascii?Q?g5eKgZl/O0zjHak7RrdqOip26f/Y4lZFNDIjBxvJJazD8jx4mw3ZKJSCZqYn?=
 =?us-ascii?Q?Wb2DEbHKUUIt3ow5TFUxCU0xbDz/sK3Ems8cNijcAsy8I7pZil/pBtdh5UKZ?=
 =?us-ascii?Q?c79eaFARRuIy8KLotPtO25NzKX/ZiB37W28/zwU4EvPGfJuIdHS4ZSmjSf/4?=
 =?us-ascii?Q?wtLuIgcOAqtaFVv0dVkVlrAev+PiZPxTpUqCu8e7T0Oz6+RGKX6xNdG5yMEh?=
 =?us-ascii?Q?5gxy+w=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef9c8ec3-5123-45b3-c218-08db06d300d3
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 17:12:32.7612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NgKeqsILhPyDgUYe1GNGy62O+V68MGm4RwpnIE+Ybvj9CaUb8YxTUdICqD0WhCCmeK/ntURKKG7Jck0aD4kvEK8zbiv4UnZvysih9WZOtho=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB4604
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 03, 2023 at 02:53:49PM +0100, Horatiu Vultur wrote:
> Add flower filter packet statistics. This will just read the TCAM
> counter of the rule, which mention how many packages were hit by this
> rule.

I am curious to know how HW stats only updating the packet count
interacts with SW stats also incrementing other values, such as the byte
count.

> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
>  .../microchip/lan966x/lan966x_tc_flower.c     | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
> index 88c655d6318fa..aac3d7c87f1d5 100644
> --- a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
> +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
> @@ -234,6 +234,26 @@ static int lan966x_tc_flower_del(struct lan966x_port *port,
>  	return err;
>  }
>  
> +static int lan966x_tc_flower_stats(struct lan966x_port *port,
> +				   struct flow_cls_offload *f,
> +				   struct vcap_admin *admin)
> +{
> +	struct vcap_counter count;
> +	int err;
> +
> +	memset(&count, 0, sizeof(count));

nit: As was pointed out to me recently it's simpler to declare
     count as follows and skip the memset entirely.
     No need to respin for this!

     struct vcap_counter count = {};

> +
> +	err = vcap_get_rule_count_by_cookie(port->lan966x->vcap_ctrl,
> +					    &count, f->cookie);
> +	if (err)
> +		return err;
> +
> +	flow_stats_update(&f->stats, 0x0, count.value, 0, 0,
> +			  FLOW_ACTION_HW_STATS_IMMEDIATE);
> +
> +	return err;
> +}
> +
>  int lan966x_tc_flower(struct lan966x_port *port,
>  		      struct flow_cls_offload *f,
>  		      bool ingress)
> @@ -252,6 +272,8 @@ int lan966x_tc_flower(struct lan966x_port *port,
>  		return lan966x_tc_flower_add(port, f, admin, ingress);
>  	case FLOW_CLS_DESTROY:
>  		return lan966x_tc_flower_del(port, f, admin);
> +	case FLOW_CLS_STATS:
> +		return lan966x_tc_flower_stats(port, f, admin);
>  	default:
>  		return -EOPNOTSUPP;
>  	}
> -- 

Also, not strictly related, but could you consider, as a favour to
reviewers, fixing the driver so that the following doesn't fail:

$ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
  DESCEND objtool
  CALL    scripts/checksyscalls.sh
  CC      drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
In file included from drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c:3:
drivers/net/ethernet/microchip/lan966x/lan966x_main.h:18:10: fatal error: vcap_api.h: No such file or directory
   18 | #include <vcap_api.h>
      |          ^~~~~~~~~~~~
compilation terminated.