Date:   Sat, 4 Feb 2023 09:44:10 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v1 net-next] net: mscc: ocelot: un-export unused regmap
 symbols
Message-ID: <Y96ZahikcXqYbOnf@MSI.localdomain>
References: <20230204001211.1764672-1-colin.foster@in-advantage.com>
 <20230204013439.4vfag2kbrwpwvnpr@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230204013439.4vfag2kbrwpwvnpr@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vuMG0wy3YRA3YNrrBOR5XW0coG4zpKYsVZooQejIApf/eTRElvQd3BD9YMYN?=
 =?us-ascii?Q?upDOZk6qazBaYEFBYrkVYTGtJD3PZOUqs+5H6qNvuAw/KEUp7kRXqaYNBrkZ?=
 =?us-ascii?Q?P2peDE5XOCz1YOa37VjtBKeR1accPYhQ7PI1ZPzPlkycVklf0OgbtcWXbYzA?=
 =?us-ascii?Q?7NzLtQfTVwoZbx/OCYHFIRkEhzIIlNgkZX/xoMaQkUJriV44euKsax7krjnc?=
 =?us-ascii?Q?FlGb6kzt+Ans8YS+733zQdK4EVQeVaeJ9ZtLHfR05m0dUTBtWPDx021Neo2B?=
 =?us-ascii?Q?e+rATD/rf2PvNVubqjs9RzFlSsoY5Yjf9E6VzfUP1d+tlhPadCAwdS/AJWqd?=
 =?us-ascii?Q?2EU8c05tk5bx9H/C/mRUlxaOj2LUcWsSDqGCEu3znweCK4iuKKIW0Y5ggxZa?=
 =?us-ascii?Q?oJLq4Q6Y3ZgmjPg+5Fw37aKG4lNZfpw4nu7IhwOeA3eY9uU98ItyFcueEBEi?=
 =?us-ascii?Q?iTuHgJcAdN9uZLUTmnngDV4RVS3LL/yio9OuclKw4B75LyY5w47add+07OVq?=
 =?us-ascii?Q?dTTO/DG10jjfv5T8iq1fGYOtbO+GRahBpN6Mr2UScUmkZ71nEhd9BzrVgY8Z?=
 =?us-ascii?Q?f+kDWqD+oUzrqUM6Ypsbb6TkMSoa1fDHTu+xA/AqHl1TsDsiKNCQnqZbMAY9?=
 =?us-ascii?Q?E4ldykxxmmxhNpjepY0LCrlgTT7Daf/CnROXWJxnTjoD58kcCTrdax8i3of+?=
 =?us-ascii?Q?84A8LIHlL9O87YJh3f0brOaGMGPlXEFseSRTI2e0VJc1BH2e+e9+VHb7VRGQ?=
 =?us-ascii?Q?/H2cU7CHAWAGP2WAvFv3i9XhXyEiU+GhhBGXVkSwaXR+eKwOJNstdNjVbXR4?=
 =?us-ascii?Q?wuUm8KAhPR6NwvTslOfwFWfW5N+xlmJzxqulrI72D+f91fbPeWR6Agp3k6gM?=
 =?us-ascii?Q?7P64YCpM9T+aBs8/n+2AEd4mSnpR0NNk/zBAYSk3SWaJpRbTvdF2aNJqDgFi?=
 =?us-ascii?Q?3OIt9RaFU8AUTHR6avJJBmAl6Zc2Lk75w21M9tg4keVjskGaDldSN2f9nLOC?=
 =?us-ascii?Q?ZEMlf6KJGpQ1q5tdM4PoIvweYheYMTe4S1O4Jwq63JndY37omrDRt2EN9u0h?=
 =?us-ascii?Q?cQC/d1ZhkmUxwmUcSOavb2rj4ckyeff0LR9IXj4D8xQe7z9OkdX1QsNyIV4c?=
 =?us-ascii?Q?AE6mmfJaoVNNZnsNDolfzZKyRrqWyFsMQ/ecV+ub2pHEn8lHFsdS9DwMf9I2?=
 =?us-ascii?Q?DzwjWXTS/YkTaSx+4vMVWMPBP5AKS9fNCsDyBuT+9pnbQ6Sl4hHBwSYdUQjo?=
 =?us-ascii?Q?Q0UZy8EovUVYn2xtKJgBWXUdnSsIpCgSE9q/QFNFviOFmG4wlL05aAg1tkNW?=
 =?us-ascii?Q?+k3CA2SMsrc10uiraSjhvSpuYR+c9XEkenLWDRmXDcvIFVm+1l7EkPcBnitl?=
 =?us-ascii?Q?Ubdg4GQSXmc0iWRq2jiqEHLMjDWXCydYU/WY3O8p7EiHFBRB7mLqtE6OTq5u?=
 =?us-ascii?Q?S+0FMU/jcXsseNu64iKRmryS/vbWt23DBg6qKGtl3pOoBW5yIMC2tKS02feH?=
 =?us-ascii?Q?LEr9gNhvZ+RqJymhQ0fAtCd6jrbvPIseo8pKHpUFrXSM1dCVhSObo/wCxz1A?=
 =?us-ascii?Q?12TNnvWm8Iwh1hk5lOTGcD+MjsVTRIELmN2QEveWmXyzCqQoGyO9olyl17eP?=
 =?us-ascii?Q?Mb8IxsnhNpQubs6aMuOTnBc=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8fe098d-3355-4045-369f-08db06d772be
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 17:44:21.8360
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8Oh9H5T8xF/q+0Wf+M24tdExPxVXhn/wjntkI6+wX4QubuKcrq+2K0pKIxTZFx0tuXimGQ+hpCfkm+QELYPk2kOK/aOyTWX0gunyc5M5G7A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5953
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 04, 2023 at 03:34:39AM +0200, Vladimir Oltean wrote:
> On Fri, Feb 03, 2023 at 04:12:11PM -0800, Colin Foster wrote:
> > There are no external users of the vsc7514_*_regmap[] symbols. They were
> > exported in commit 32ecd22ba60b ("net: mscc: ocelot: split register
> > definitions to a separate file") with the intention of being used, but the
> > actual structure used in commit 2efaca411c96 ("net: mscc: ocelot: expose
> > vsc7514_regmap definition") ended up being all that was needed.
> > 
> > Bury these unnecessary symbols.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > ---
> 
> These can be unexported too:
> 
> extern const struct vcap_field vsc7514_vcap_es0_keys[];
> extern const struct vcap_field vsc7514_vcap_es0_actions[];
> extern const struct vcap_field vsc7514_vcap_is1_keys[];
> extern const struct vcap_field vsc7514_vcap_is1_actions[];
> extern const struct vcap_field vsc7514_vcap_is2_keys[];
> extern const struct vcap_field vsc7514_vcap_is2_actions[];

I was as positive as I could have been that I'd grepped (grept?) and saw
those used in Seville, Felix, and ocelot_ext yesterday. I'll fix this
up, and thanks for checking!

> 
> I guess we make exceptions for the 24 hour reposting rule when the patch
> has been reviewed?