Message-ID: <45360170-f132-3204-1e99-ed78c73641c4@amd.com>
Date:   Sun, 5 Feb 2023 00:02:07 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH V2 3/3] sched/numa: Reset the accessing PID information
 periodically
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>, rppt@kernel.org,
        Bharata B Rao <bharata@amd.com>,
        Disha Talreja <dishaa.talreja@amd.com>
References: <cover.1675159422.git.raghavendra.kt@amd.com>
 <b0f273113fedffb02f9b1358c88813ff355a81d6.1675159422.git.raghavendra.kt@amd.com>
 <Y9zxkGf50bqkucum@hirez.programming.kicks-ass.net>
From:   Raghavendra K T <raghavendra.kt@amd.com>
In-Reply-To: <Y9zxkGf50bqkucum@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anZ6SFRNZFlST01TYzNra0dLajhJbnJ6aitPdkY5bTNJcGRxVmM4MmFaMEN5?=
 =?utf-8?B?Qmd2NFc5UnNqM0w4S3lVcFN4MnNhK1M3Z3gvdkswNkIrTUYzMlhvSURNOEFl?=
 =?utf-8?B?ZHJzdDFPaldiTTEzK3VCL3hScW1GZTM5UFMydGt0Y0RkT0lsVHgrSTZrZnhG?=
 =?utf-8?B?aTVqWitwQVdtZUo2TzdvU3U4dUZLR0diTGFBNUM0RzU0QzFwTXc0NU04d0ow?=
 =?utf-8?B?RGhVYVNQZGxpWDNDdmo4Z3VCaTNIdEE3enJiVjVtVlFCTmJRb1d4M1FKV1NE?=
 =?utf-8?B?RHlJVzE1dWFqUWNNeGdYbklwR2tqb3ByUkh5VWJMY3Y4TUM3ZUJHbStVMGlZ?=
 =?utf-8?B?NDZxcEhHRFlrY0pRK2RySFZ2NjhzbGZFZDVtNDhzSUxrTEVyR2RFZzFwbWZG?=
 =?utf-8?B?Nk4wMzdBTkI4SysrNXk1ZjNSMWJKcFpLcndJTUhQYU9RdXlqZW4yRm5PWkN3?=
 =?utf-8?B?NVNXMnM1N2ZvcmJaV2RsdjFoNEU5QVNGY3p6WTFyVWhzUy9talkzMnV4TTR3?=
 =?utf-8?B?NlZqU3lFUUpPUkxOb2VWa1dVb3BmSmJqTjVBNTh6ZDI0UEprNzlBZTZ1cW9L?=
 =?utf-8?B?bm1kWmdtdG9TclkyNCs2OUpZZ3N3RGZtRkJRWk04QjF6SFR0eUdHNUtEWWNx?=
 =?utf-8?B?dGZ3YU5SQ0tLWEJTaEZPNFd2ZUIvZWg2ayt2R1NnTnNyMGs2Vk5KWU1IRHlt?=
 =?utf-8?B?QkdYRStJZnRESXZOZDZBc1ZGWmRXbEgwRzlCSXZWVTJjbjRSTDcyaXZJcENQ?=
 =?utf-8?B?NkxKcXdmT3hNdXBMV25OZG1rYnNBWHM1RVpXUE41WWNGbW40UjBDeU9HMkRB?=
 =?utf-8?B?ZHMxcnZGWjdVdkdkU0huaTB3bTcrQkFIbXFzelZKOTFlVkdiWXdUdWdudG02?=
 =?utf-8?B?KzlLZ1RzM0lGYm1HdXY3RzVEb1RtWitBZ1FnZ044S1pzQ2Q3TlZQRTQ0Zk5n?=
 =?utf-8?B?UGpKMVphdEdCK2JuczRKMGdKS0w5YWtpMkZYTG1NbnBtNDIvVEJVZTlPWjF1?=
 =?utf-8?B?aTBnd2RBdDlmUnVzZVRHUHJuKy9OUlUrbUowVVdveE4wTHZlZmtROG5Lb3ht?=
 =?utf-8?B?ZHdKckwyaHMxMWFPRWZyN2xWMWRTeVBRZ0ExWnVtMWtyYjNsVmQ0NEtzUEMw?=
 =?utf-8?B?dHByWUtidUhPc2kxME02dGduU0xxN2pHWmtyRVdmbGpKN0gzTVVrWnZUa25O?=
 =?utf-8?B?V3dUWmVPeG9yZmRSdjRQczNRbytpZGNtRGdRMDRqV3JFZzJVR3Z5Q2hqRkhO?=
 =?utf-8?B?VU1zdnNkNjlhMEpwbk1oUmZkVVJCWmtxT3BOVmx2ald6d0ZiSDVaeDdSUitQ?=
 =?utf-8?B?ajhnNG9DU3MwOHFuN0JHNXdZRnJtQ1Izdk9wbXdNSHU4V3dvSjFSNWhIOWFD?=
 =?utf-8?B?ZG1Xc3NrSi9FZHVVbTRldUNha1c0ak5nVUltbDhoQWN2b2Y0dWYzR0x6b2Z1?=
 =?utf-8?B?SDkxUVQxQ2UrbDAwajBSSll3alZiLzNCbTB6NDQ0RkIzeWUzbVY0L2xtR1Nw?=
 =?utf-8?B?OEdEYVpkQWhIMzRQWkR2ODFHQndOUEFILzMrbjRYZHFuVUtoMEczbi92eXVt?=
 =?utf-8?B?TzdVWWNYY1RlQjh2OSsyRlhHM0NDdzFOT3ozZVVJNlVBZEhPMk11dTVkaGRw?=
 =?utf-8?B?WG9hN0FrRGowUkxTQWVrVHUyMDY2WjJ2MFdRNmJha2dPQTE1RHJsNDhTTENj?=
 =?utf-8?B?OXhEN3JWTUczdXVUNnBrTkxxVzBnWUpRVFJra1dOcW9vbDBsTUdSemp6WXdH?=
 =?utf-8?B?R2pzQ0FPdi80L0NYZXpjby9WSGxVdHhxbSs2TnVjLzJ4NUdoUGY0WnB0SnRF?=
 =?utf-8?B?RlBpSlc0QTV6dkY5T2JvTHVsNDBQeDVvbVpQcUxWcnJaZWpLRitLZUg5WDJs?=
 =?utf-8?B?WWtZTENHM1FYVmFXMGFsYis1RjdlRXcxbWhVa3NoU2VJeWZ6ZmJjM2dvTUVo?=
 =?utf-8?B?ZngyYkNDSXFraXduZ1R0TVpTVjlyUkVER3dvc01GMWpRdFBza25CWVovVGN2?=
 =?utf-8?B?QXVseU9VT1Bpdm10bTR5WXlNRUlqZlJhZ3dSZGVnNmxVV1RjdWt4aG9RSFl0?=
 =?utf-8?B?WTRhc3dva2xBcHJNZ2tJdVRxd0lGdmlFS2JnWTEzVW1Yd05xbWtORTd3emxB?=
 =?utf-8?Q?olmNkRa3JJ5IujluAn1t5FI0a?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61b2ab35-04af-4cd7-1d20-08db06de260b
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3008.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 18:32:19.7419
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lof5ZMV/Ud2MiY0WCQ56W4jP9NBljj4RLHt7xqPQAJ01uiJyx8vGH9cPSnzR8Yp4Rt19y7WWt5/F3bDERcl/RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6809
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/3/2023 5:05 PM, Peter Zijlstra wrote:
> On Wed, Feb 01, 2023 at 01:32:22PM +0530, Raghavendra K T wrote:
> 
>> 2) Maintain duplicate list of accessing PIDs to keep track of history of access. and switch/reset. use OR operation during iteration
>>
>>   Two lists of PIDs maintained. At regular interval old list is reset and we make current list as old list
>> At any point of time tracking of PIDs accessing VMA is determined by ORing list1 and list2
>>
>> accessing_pids_list1 <-  current list
>> accessing_pids_list2 <-  old list
> 
> ( I'm not sure why you think this part of the email doesn't need to be
>    nicely wrapped at 76 chars.. )
> 

Sorry.. copy pasted from my "idea" notes then word wrap fooled me..

> This seems simple enough to me and can be trivially extended to N if
> needed.
>  > The typical implementation would looks something like:
> 
> 	unsigned long pids[N];
> 	unsigned int pid_idx;
> 
> set:
> 	unsigned long *pids = numab->pids + pid_idx;
> 	if (!__test_bit(bit, pids))
> 		__set_bit(bit, pids);
> 
> test:
> 	unsigned long pids = 0;
> 	for (int i = 0; i < N; i++)
> 		pids |= numab->pids[i];
> 	return __test_bit(bit, &pids);
> 
> rotate:
> 	idx = READ_ONCE(numab->pid_idx);
> 	WRITE_ONCE(numab->pid_idx, (idx + 1) % N);
> 	numab->pids[idx] = 0;
> 
> Note the actual rotate can be simplified to ^1 for N:=2.

Thanks good idea. This will be very helpful when we want to
differentiate accessing PIDs in more granular way. Perhaps we can go
with N=2 and stick to below simplification of your code above?

something like:

unsigned long pids[2]

// Assume pids[1] has latest detail always
set:
if (!__test_bit(bit, pids[1])
	__set_bit(bit, pids[1])

test:
unsigned long pids = pids[0] | pids[1];
return __test_bit(bit, &pids);

rotate:
pids[0] = pids[1];
pids[1] = 0;