Date:   Sun, 5 Feb 2023 02:06:32 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Lee Jones <lee@kernel.org>
Cc:     Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv6 05/11] mfd: rk808: split into core and i2c
Message-ID: <20230205010632.wt5m3a7w7k62w6se@mercury.elektranox.org>
References: <20230127181244.160887-1-sebastian.reichel@collabora.com>
 <20230127181244.160887-6-sebastian.reichel@collabora.com>
 <Y95jJYlqDayiaMP1@google.com>
 <Y95lSpUaOnbSAOIC@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qwl6y6rrtwcef27f"
Content-Disposition: inline
In-Reply-To: <Y95lSpUaOnbSAOIC@google.com>
Precedence: bulk


--qwl6y6rrtwcef27f
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Lee,

On Sat, Feb 04, 2023 at 02:01:46PM +0000, Lee Jones wrote:
> On Sat, 04 Feb 2023, Lee Jones wrote:
> > On Fri, 27 Jan 2023, Sebastian Reichel wrote:
> > > Split rk808 into a core and an i2c part in preperation for
> > > SPI support.
> > >=20
> > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > > ---
> > >  drivers/clk/Kconfig                   |   2 +-
> > >  drivers/input/misc/Kconfig            |   2 +-
> > >  drivers/mfd/Kconfig                   |   7 +-
> > >  drivers/mfd/Makefile                  |   3 +-
> > >  drivers/mfd/{rk808.c =3D> rk8xx-core.c} | 209 +++++-----------------=
----
> > >  drivers/mfd/rk8xx-i2c.c               | 200 ++++++++++++++++++++++++
> > >  drivers/pinctrl/Kconfig               |   2 +-
> > >  drivers/power/supply/Kconfig          |   2 +-
> > >  drivers/regulator/Kconfig             |   2 +-
> > >  drivers/rtc/Kconfig                   |   2 +-
> > >  include/linux/mfd/rk808.h             |   6 +
> > >  sound/soc/codecs/Kconfig              |   2 +-
> > >  12 files changed, 256 insertions(+), 183 deletions(-)
> > >  rename drivers/mfd/{rk808.c =3D> rk8xx-core.c} (76%)
> > >  create mode 100644 drivers/mfd/rk8xx-i2c.c
> >=20
> > Looks like you completely ignored (no response / no action) my review of
> > v4.  This submission is therefore not getting one!  All comments can be
> > superimposed from v4.
>=20
> s/v4/v5/

not sure what you are talking about. I dropped the PM wrappers and
added a new patch moving the driver to use OF match. There were no
other comments as far as I can tell. Did I miss a second mail with
more comments?

-- Sebastian

--qwl6y6rrtwcef27f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmPfAQsACgkQ2O7X88g7
+prcPQ//eszrU24MFC5Y+5iGOaGdQNIx5ftzeIJNJBwYVllRJ12qns5IJavJb3bO
j2KePqz80vwBzjQjtaFrid3dDUp+5Kip6spWCbu1mD0zPCj9xNUmWdFn78oZJRvN
U9VYMRqeGBEmh4F/2dXaDd1KpZ+Yv042fCi0er5X2LMi0OE2RtlaE62l4XTKTCB7
Kzzj/5Hv0DicX/Ecoq2ys7OcCWy7wG9hilyGYABZCWtAICoGCVMtLA8DwO+YNcDL
wg0RRRJGkUrIZ91MIFDSxsYiElqil5tNaEhqBg+XfEzjEZeZEJR/Bw59rTNvBvIn
DqkpT0C6e1kxn5aoaExjwMPmxRx9spq71V8EAQ71ZL9HIQNmQPXiyhmXMJUVuW1p
gHctZpXTwQpvqoy18NtoQ/6ZWTuNwUHqhn3z16SND0x5Uekp95zuN3YJvBrn4YIf
niEwpVUWnCUmrMAxxp9Cue5TaRpLPHk9WzWxaX5cIykOKrS0eN2NBINipTTEItZs
/2mntr82tvbsBQwQCYSWsmf0X7/4oA4IfF06M/xXKwsbQNlA6vBgKpffA1kxgKPR
8jHLlDUKVFB+RNvCiHRMkE4WBUlpliZqyRq1te8TS9Knhbz0Jj0fnbpn+G8Hu+wg
TswdQcjKJjAOHrJ3n7w+yHMUH9T3rooo+cTbf3HxO4Qn7Wrqp2o=
=x1Im
-----END PGP SIGNATURE-----

--qwl6y6rrtwcef27f--