Message-ID: <14bbde0d-6f4c-9615-0fff-ca68e81c073c@nvidia.com>
Date:   Sun, 5 Feb 2023 09:26:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] vdpa/mlx5: Directly assign memory key
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     jasowang@redhat.com, si-wei.liu@oracle.com,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <20230202125718.1013961-1-elic@nvidia.com>
 <20230202123132-mutt-send-email-mst@kernel.org>
Content-Language: en-US
From:   Eli Cohen <elic@nvidia.com>
In-Reply-To: <20230202123132-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aU9odDJSNzVPNXU3dVRIRXZFQW1TanJ2SGhZbUVrR2JENmNYdmwrU04rZjFl?=
 =?utf-8?B?VUUydVFUaFFSN3AxcHB1NUVwVXdWendIZ0FWbVRhSkJpNTE1RTVlanNrM053?=
 =?utf-8?B?T2pFSk1kOGozTHgwRGx3ZlFWdVM0RVgzd0dXdzY1cEdWaTR0YzZ2bjRLcVB3?=
 =?utf-8?B?alYzZURtcnc2NUtjRGl6N044a1JiMGVvZG81WjNGQjN5cE16UkM0dWRKVzR3?=
 =?utf-8?B?TTA1aHZ3NVduYlJNeHpFMG1oa3JjQnNDYlhRZzZjK2dMM3dPOW5HQUZXem1j?=
 =?utf-8?B?Slc3QVdYZFp4OGFKdmt3S1c1Qk1lRkY2L3RjaWo1YlgyTm9rZ3U3WUJxelV0?=
 =?utf-8?B?RTExbGVmKzNsVEhEc2JqaWhsWkNCUDZ4SWs0dG16RlA4dVduRnZ3cjJ6RUhQ?=
 =?utf-8?B?d1RoY2swN3VOMGJDZHdyZU5zM0pRVHo5cmk3b0pEOWVML1dmbHVTdkFOVndz?=
 =?utf-8?B?K1FTSHhjZStZOHcrTmlOekVKaGNmNk9IUVRvUjZlSTV6eGNPOHdXQXNuWUc2?=
 =?utf-8?B?OFVOMnJCdWs2aFNjdHN1b2xkcHYzSXBTUEtYM0NiNVNzMzZCSzFsL2c2RlJq?=
 =?utf-8?B?NGtqcCtvRmhweCtmY0huZEhaSHFJeVV3NEMzSUNKOW5qcjl1T2h6TWUvK1hl?=
 =?utf-8?B?bEY0YnhFb0N5eWRnd042ZCsvREtmWW50T3hnSUZiVTRLQ200azlnOXRCcWNV?=
 =?utf-8?B?ekJ5NjB3Z1BGdk5qWlFSK3kwbzFEWEZUWVpFbU9NM1lRT2V5NitvK2FkZjA3?=
 =?utf-8?B?Sm1oWHlLVzFtaTQ2a09qcVFzSDlhSDdWRDZpR0R0cXdMaG9JUzhLcnU0ODMz?=
 =?utf-8?B?QWZtL0tjdWpOUzNjVGJtVyt2U0kydXVaSUVkQzhjM3M0NTZzc0t5bFR3SGlI?=
 =?utf-8?B?L2k2SWo2b0h2YnkyWFVVU1ZhWTJYS0xhMVhUTTR1SmtlblE0SEVDbWhLM3Aw?=
 =?utf-8?B?QkNnOUFzQ2QzSlhseXIxcmg2N1MyRlJIaTRYcWRWVkV6Wmo0TUk2THN3Rzlj?=
 =?utf-8?B?NHI5VWZCQ3J3WndQYnBZNXJRcThTNEZ3VjBCdzE0SFNMZCt2aExjNzM2UXha?=
 =?utf-8?B?bXFOWEo5T2Q1R0U5bTdjYUh6YnBneFdDcUpBTDVLbXNjaCtZL1c5STRwUSs2?=
 =?utf-8?B?Q0pCZzJLU3FrQXBWa1Z2MXNsdmp1aDNQc0x3Z29SQkhYc0tqb29CTFZoaVFQ?=
 =?utf-8?B?Nkp3NUZSSWh5YmpaWEgvQ25aMUNaWGNSbTh1dkRjaG4rWG5ub0hIQzlkL3Nk?=
 =?utf-8?B?R0NmNFIvTkJiYnNsSDFwaW1aL01YdU9aRFYzejBDQXV0bGZzL0JFUmZBWDN5?=
 =?utf-8?B?QzQxOHd3SVkvNGp5V2RYTDRXTTVGUUluUmZuZlFUM0pob0EwUWt2bG9yODBB?=
 =?utf-8?B?UUFLTU9ucFhSUkU3MC93VG03SnJFNys1NnNtTUhvMHQzdXFOYkhRSWVvTmlU?=
 =?utf-8?B?RXpRV1JlcjdNZW1NdTY0emtPN3IzOHZ5WGdwSFdyaFBuWVhxZXVibFd2SVhp?=
 =?utf-8?B?OHhxYXJnaGFuRzQ0aFh6VFF5YUZnRzI3SWxqR3VJTTJmT0xuSTVyTVp4VTND?=
 =?utf-8?B?Mk1pNzBjckF1T3A5ZHVxOWZDclBPWGhOZUQwdlNzajVEdDF0bU1RYklFUEFI?=
 =?utf-8?B?RGlmOVREZlJnYXVDUXo4RVF1SjRNazQ1K2hUejNDSEpwV3ludTV4TWVJTm5W?=
 =?utf-8?B?Q3FybDdwZFBkMWFIRUhBQ0ZJZ1phaWJlRW1tSDk5Mm0xT1JhMWNLWTdGeENz?=
 =?utf-8?B?SVFBUTZhVHZDZVRlN1J1OFFTSVMrRG9sT2lUclozQVJCbHFQbllqaGNaaHI1?=
 =?utf-8?B?ckpCVVRUTFM1NUJkelRmM01obHJNM0ZIeTNlaHo4S1JxOVZnMzJJMTJFRytr?=
 =?utf-8?B?S0w1RmhMZEExa1pJZjJ4cUpQVkxoSkh1SGxLSDZ6aldocWF2bmpCSndtMDAz?=
 =?utf-8?B?N055RmQ4ditCV01LelM2MTBid21TUU9PRUl5ODdBZGFYcld0Wlk0ZnlSVG83?=
 =?utf-8?B?dmhFQnJSQmJTdEVNZnNnVTM1YWNTQUtOSDduQlpoc1crZ0xRQ1VlUUJjWXhh?=
 =?utf-8?B?QXdiRi81QTY3Rm1ta3VuNXNYZmZEMjd6SHpURkl2RVNoaFpKYjUwMWRJR2tO?=
 =?utf-8?Q?DJDRk/nPoQdbMDtmtUzF/ukuN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ffbd4bd5-ce18-42dc-339e-08db074a4ae7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5401.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2023 07:26:27.2771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U8an3dxh1QD/cnCWarC3u1Jrzs6TEZaIPLTD0IUpizTqjDOiLkyMcv5ridr9DcyL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4335
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 02/02/2023 19:32, Michael S. Tsirkin wrote:
> On Thu, Feb 02, 2023 at 02:57:18PM +0200, Eli Cohen wrote:
>> When creating a memory key, the key value should be assigned to the
>> passed pointer and not or'ed to.
>>
>> This fix has is required but had no real impact so far.
> I don't get what this sentence says. Both grammar and general meaning
> elude me.

And I can't blame you for that.

Re-sending...

>
>> Fixes: 29064bfdabd5 ("vdpa/mlx5: Add support library for mlx5 VDPA implementation")
>> Signed-off-by: Eli Cohen <elic@nvidia.com>
>> ---
>>   drivers/vdpa/mlx5/core/resources.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/vdpa/mlx5/core/resources.c b/drivers/vdpa/mlx5/core/resources.c
>> index 9800f9bec225..45ad41287a31 100644
>> --- a/drivers/vdpa/mlx5/core/resources.c
>> +++ b/drivers/vdpa/mlx5/core/resources.c
>> @@ -213,7 +213,7 @@ int mlx5_vdpa_create_mkey(struct mlx5_vdpa_dev *mvdev, u32 *mkey, u32 *in,
>>   		return err;
>>   
>>   	mkey_index = MLX5_GET(create_mkey_out, lout, mkey_index);
>> -	*mkey |= mlx5_idx_to_mkey(mkey_index);
>> +	*mkey = mlx5_idx_to_mkey(mkey_index);
>>   	return 0;
>>   }
>>   
>> -- 
>> 2.38.1