From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Tom Rix <trix@redhat.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "artur.bujdoso@gmail.com" <artur.bujdoso@gmail.com>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        "colin.i.king@gmail.com" <colin.i.king@gmail.com>,
        "tmaimon77@gmail.com" <tmaimon77@gmail.com>
CC:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
Thread-Topic: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
Thread-Index: AQHZOQdWwDzUIKP5+kGb2XowdjuQpq7ACmZg
Date:   Sun, 5 Feb 2023 08:52:17 +0000
Message-ID: <OS0PR01MB592285E3E3B9AA7FD8C291A286D59@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20230205021227.3017634-1-trix@redhat.com>
In-Reply-To: <20230205021227.3017634-1-trix@redhat.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tpQ+PorPmBrOxvkxlNBL1vgRw3PKdhdKXA0XJWncJ6HAAslq85hAjSu0iJve?=
 =?us-ascii?Q?2FCrQ8GMEg/jgURL2bKAMhabfaaCabEZlwJ6OD3EqWw4fgYoadX7S8vvOoI2?=
 =?us-ascii?Q?hw2w0SopRTIPq3JMIyQgBTy1AXx6+WIng/quQpklz8T7vgkBqCrlyO/OspSc?=
 =?us-ascii?Q?hcZO1RShfyjNsfRAjA+h0sSvkXj1zEV0DFkTbsda+XfR/g3VktwXKWuNMzyr?=
 =?us-ascii?Q?2kMmLA/HVd8RxWwk77QibMRLZNB3aVDSL8yOvRC9dTUakflzgRVy20u1aSP9?=
 =?us-ascii?Q?uJpsPUb2czM6A9gj23VeGkwpC0tVYfS3kMhrBhCgP/tR9Sm0F0MO/dYyaHNL?=
 =?us-ascii?Q?L0m/ze/lg6Hdu1XFsm6qJ03p/pPQ+oyQk+Xqx3NOWn7SfO7yT4NQYUObVviH?=
 =?us-ascii?Q?RhehhS0kvuhTjnGYbXGHv6u02QtSip9E36GInnKg2sVyLnmfBJNh/w5hSc58?=
 =?us-ascii?Q?SGr43TXz54bGMdTBDv6wSt9QMEZheZJI0Wo8wCT2Pi0T+AvZAmv0/UyT6/HA?=
 =?us-ascii?Q?LbFcGLzw/v4XSjPt/Q3gNR/KlMcBksM83vc2x23ny1FmfSGcUeHVaoizHefy?=
 =?us-ascii?Q?58NiwC8XNGP/ZNksGMqswfqAhXDvq6QSnIJG65cRK9r3OSmR0IvWUy/o5Of6?=
 =?us-ascii?Q?6HRjRCUB1UqQafbLROsirqipj5zhKCITK4QwGEhheD4ucMY15odOacA/PuTd?=
 =?us-ascii?Q?r/d0rl4K7U+4gQyOmZInCGom75yszBv9ZK8S7wpmfLdAw8JrnRFLwW807YlE?=
 =?us-ascii?Q?wdCBDUqFnOIUqcyZqfX8DrgjL1XqmRaHYPk2SgMEwFw7rfsEzaYlKnf0ZPd6?=
 =?us-ascii?Q?XdFBQNOPcjkT5JmTTxoGZsXLw0CAAW6rv56va5A0rvHJCZRdLecPBb2qyvgu?=
 =?us-ascii?Q?foZpirIryin9diRqzvPb/6cDUdjoMyM/kftmeXJpm7MRECjAMejlUUo7/G9H?=
 =?us-ascii?Q?UlMY4b9g4xspcvIKhEPUZaYo7nus5tW7SB1BcMBbPgQL7ZN2A1hgxvRjfbTn?=
 =?us-ascii?Q?8/HfYmkP5Tjyvqr7UqM66yQXkA7N5O3zgWN0OBxOov9GJ6AQsdbA5zj4qynh?=
 =?us-ascii?Q?tG1WDTr1aZwFLlioaG7qelwjB3P7rnsgJfaJZ8hwcivqOjc0+vFv6B0v93DT?=
 =?us-ascii?Q?zIqQEMxJdXUXAlS0REOI7CAZNGeP4/+LlWz76JKagaHhHCHB/Cc0M+I42STv?=
 =?us-ascii?Q?27b9pXq6iNxp2gBPIZgN0vH9QmWbpk/PifjMRtAuGtMDT+09i2LoMixXmR+i?=
 =?us-ascii?Q?RXfiOxpoOtZ/lFtYlr6teej+YAuPxygwa+SoEW3J6Jgue3bWnjgv3u08qifj?=
 =?us-ascii?Q?cna6K8lYFzxRcqDaD+ZJ3bgxpyehxCeLphKidXQGBazULWzOjFXHEYUP0ow0?=
 =?us-ascii?Q?6SZN6L2Js3RbHB1eAlveseyyw9AYY1h+4XEyW6si6IrOzsrd7PLDDYvJ89ca?=
 =?us-ascii?Q?nIyfHXqwh/d+1PlYMYoy+LHdOqAKq8Iz9aAq/hmukBeoabGph+AEpKbv7CVG?=
 =?us-ascii?Q?Fh4LoNZk2IoC5NmEn19nSmchSPXSSfKZu/6zej3UdPoSXOFksLlt93gWfGVk?=
 =?us-ascii?Q?9+B2/VSIygMDCWJJp7Q34NjbpSBI7N/26nL06jUvzbm6cwkKo/6FuFlYF5LA?=
 =?us-ascii?Q?Qg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73feb726-d164-421d-8f99-08db075648c2
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2023 08:52:17.1880
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ETvQtsrjCUWigfHa9tql+uw7NsrLtdXIw56nO/UHuWdjRKAH7S2kaewRCZegOcn+Heb2h4Q1jZixDT5DlUAc8E3YNc7QFgpEkLxvBivS3kg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB9332
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tom,

Thanks for the patch.

Arnd send a patch for refactoring the USB_XHCI_RZV2M KConfig dependencies r=
elated to USB_GADGET on [1] and
is in usb-next. Do you see this issue after applying[1]?

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?=
h=3Dusb-next&id=3Dec5499d338ece9db9b7590649d3cfcc4d7f9603d

Cheers,
Biju

> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Sunday, February 5, 2023 2:12 AM
> To: gregkh@linuxfoundation.org; arnd@arndb.de; linus.walleij@linaro.org;
> artur.bujdoso@gmail.com; miquel.raynal@bootlin.com; colin.i.king@gmail.co=
m;
> Biju Das <biju.das.jz@bp.renesas.com>; tmaimon77@gmail.com
> Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Tom Rix
> <trix@redhat.com>
> Subject: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
>=20
> A rand config causes this link error
> ld: drivers/usb/host/xhci-rzv2m.o: in function `xhci_rzv2m_init_quirk':
> xhci-rzv2m.c:(.text+0x13): undefined reference to `rzv2m_usb3drd_reset'
>=20
> xhci_rzv2m_init_quirk build is controlled by USB_XHCI_RZV2M
> rzv2m_usb3drd_reset build is controlled by USB_RZV2M_USB3DRD
>=20
> USE_XHCI_RZV2M does select USB_RZV2M_USB3DRD, but USB_RZV2M_USB3DRD depen=
ds
> on USB_GADGET, so now does USE_XHCI_RZV2M.
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/usb/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index
> 2b80ce9587c1..2dd9e95a5b86 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -100,6 +100,7 @@ config USB_XHCI_RZV2M
>  	tristate "xHCI support for Renesas RZ/V2M SoC"
>  	depends on USB_XHCI_PLATFORM
>  	depends on ARCH_R9A09G011 || COMPILE_TEST
> +	depends on USB_GADGET
>  	select USB_RZV2M_USB3DRD
>  	help
>  	  Say 'Y' to enable the support for the xHCI host controller
> --
> 2.27.0