Date:   Sun, 5 Feb 2023 05:22:40 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc:     wuqiang <wuqiang.matt@bytedance.com>, davem@davemloft.net,
        anil.s.keshavamurthy@intel.com, naveen.n.rao@linux.ibm.com,
        peterz@infradead.org, akpm@linux-foundation.org,
        sander@svanheule.net, ebiggers@google.com,
        dan.j.williams@intel.com, jpoimboe@kernel.org,
        linux-kernel@vger.kernel.org, lkp@intel.com, mattwu@163.com
Subject: Re: [PATCH v8 0/5] lib,kprobes: kretprobe scalability improvement
Message-ID: <20230205052240.4581ef09@rorschach.local.home>
In-Reply-To: <20221229235220.4044edccae7c9d39798af8e9@kernel.org>
References: <20221218050310.1338630-1-wuqiang.matt@bytedance.com>
        <20221229235220.4044edccae7c9d39798af8e9@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 29 Dec 2022 23:52:20 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> Hi Matt,
> 
> Sorry, I missed to commented v7 patch. Anyway, please read
> my comments on previous version.
> 
> On Sun, 18 Dec 2022 13:03:05 +0800
> wuqiang <wuqiang.matt@bytedance.com> wrote:
> 
> > This patch series introduces a scalable and lockless ring-array based
> > object pool and replaces the original freelist (a LIFO queue based on
> > singly linked list) to improve scalability of kretprobed routines.
> > 
> > v8:
> >   1) objpool: refcount added for objpool lifecycle management  
> 
> At least this update part looks good to me.
> (But I think this may be useful only for kretprobe/rethook
> use cases...)
> 

Masami,

Were there other updates you expected from this series?

-- Steve