MIME-Version: 1.0
References: <20230122141428.115372-1-masahiroy@kernel.org> <20230122141428.115372-4-masahiroy@kernel.org>
In-Reply-To: <20230122141428.115372-4-masahiroy@kernel.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sun, 5 Feb 2023 21:02:26 +0900
Message-ID: <CAK7LNAQ-UCzDQ7QBUZosAKfiM3uj75fshdtEnXE7W=FNVjeMXQ@mail.gmail.com>
Subject: Re: [PATCH 4/7] setlocalversion: use only the correct release tag for git-describe
To:     linux-kbuild@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jan 22, 2023 at 11:14 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Currently, setlocalversion uses any annotated tag for git-describe.
> If we are at a tagged commit, it will not append the commit hash.
>
>   $ git checkout v6.2-rc1^
>   $ make -s defconfig prepare
>   $ make kernelrelease
>   6.1.0-14595-g292a089d78d3
>   $ git tag -a foo -m foo
>   $ make kernelrelease
>   6.1.0
>
> If a local tag 'foo' exists, it pretends to be a released version
> '6.1.0', while there are many commits on top of it.
>
> The output should be consistent irrespective of such a local tag.
> Pass the correct release tag to --match option of git-describe.
>
> In the mainline kernel, the SUBLEVEL is always '0' but it is omitted
> from the tag.
>
>   version         tag
>   6.1.0      ->   v6.1        (mainline)
>   6.2.0-rc5  ->   v6.2-rc5    (mainline, release candidate)
>   6.1.7      ->   v6.1.7      (stable)
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>


I will drop this patch,
and send an alternative one.


-- 
Best Regards
Masahiro Yamada