Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D26C636CD for ; Sun, 5 Feb 2023 13:16:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbjBENQP (ORCPT ); Sun, 5 Feb 2023 08:16:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjBENQN (ORCPT ); Sun, 5 Feb 2023 08:16:13 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40BB01E5FE for ; Sun, 5 Feb 2023 05:16:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CA40060BA5 for ; Sun, 5 Feb 2023 13:16:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C817C433D2; Sun, 5 Feb 2023 13:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675602971; bh=GAoViPlV0DElkM/IIZUXBqHgjdhbnm/i6oHg5gCEOBM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YujcZpKQMKvRihl79OF1uXyJLnMzVFZgtUc0FK/yGOCIaXSxR7OeYhqptmbpqqzZN wRjw7qBr/1WCsO3xGA8dwJKWsV/kOcNfmg+vY+G02vTNa435Kvuw84D48U2bxCo1HG m6Perjx3BjK0Lalr7g8b9G9I9xyfcS4l9+s1N8+4= Date: Sun, 5 Feb 2023 14:16:07 +0100 From: Greg Kroah-Hartman To: Guru Mehar Rachaputi Cc: Forest Bond , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: vt6655: Macro with braces issue change to inline function Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 05, 2023 at 02:08:02PM +0100, Guru Mehar Rachaputi wrote: > This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better > as '(iobase)' to avoid precedence issues" > > --- > Changes in v3: > - Whitespace error from checkpatch fixed > > Changes in v2: > - Macros with one statement that is to call 'iowrite8' function changed > to inline function as reviewed by gregkh@linuxfoundation.org. > In relation to this, names of the callers of macro are also modified > to call this function. > > Signed-off-by: Guru Mehar Rachaputi Try to take this patch and apply it to a tree, and see that everything below the --- line is thrown away, including your signed-off-by: line :(