From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        Frank Wunderlich <frank-w@public-files.de>
Subject: [PATCH net] net: dsa: mt7530: don't change PVC_EG_TAG when CPU port becomes VLAN-aware
Date:   Sun,  5 Feb 2023 16:07:13 +0200
Message-Id: <20230205140713.1609281-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?424KdFPL4lkEpiqAr2egW7yTREv8QTJlVKbwE2ClSfrmAJQKc3fr4G9n/csL?=
 =?us-ascii?Q?zLB03B7OU5hFn6z0vih2GMMTTzyxfFnIBKAa3wp0nPvaMkWm7Rm7GtqG68iu?=
 =?us-ascii?Q?8YAKchm6eMP2pcmt3aSOrmPB7ovGDCf9MIxxk4jpZA5ezeKaczGhRIHMR7AK?=
 =?us-ascii?Q?1oncKqO3CR8X5z99Z9BmEhu8IzDf7uFo2vke6/3YCilEgmkZEVxlXj+K8MfW?=
 =?us-ascii?Q?mCZvFSD72G2r6UVVbT1nF7oYm7R4dVvSzxdi3FUrKWfBrlMTjVHkr4K7Fpyg?=
 =?us-ascii?Q?BlE4IRqj+pMOoB8o2VrtTIkRvm2TboFX9SRGjxnY7aVU+eI5V0jEGpvFXlDM?=
 =?us-ascii?Q?aaAsNDcRhaR0RRm9gihxXTxNMeP5L+GM6ZpaCmgAOaH/m39NMjMhkt3EA8bz?=
 =?us-ascii?Q?GQV5kBQg+RfgiNYoNbH6frJZ476xWQFNRPVWEDjZV80pNkmJ2039Y1Iiaxbg?=
 =?us-ascii?Q?poNt/KjwYNpOHEw/SWaKcrVpae40SjLxFXyQm9VtlFbTRwzH/kIaZbssLS3x?=
 =?us-ascii?Q?hzLcbSX67uX3mrYsDWP2q+P3k84Jwkk2jktLkgcvurvWGiV+Wc5xBdtrxuVq?=
 =?us-ascii?Q?0Z35MHGhHnfpWk2tX2nSEu8rlzPTpP03Bp1K0pvtyHNrelOY17HrFmmh1AcX?=
 =?us-ascii?Q?OaYa68nSsXY05wD1Nszh13+8TLDgWcV5HnOhDp7R+Zb8NShuK/n0BXFebkKZ?=
 =?us-ascii?Q?z+Fgop8eq3uVVmg8yvv15oLGcG9pjeKL3HNIyZpsmtTcVvGA3bdJjK+2ttNS?=
 =?us-ascii?Q?r9kBx453TX8DKySykBaw22Z9U/JfcGAfyNgcAgT3zA9+DTYtgu0NhUAwq6uD?=
 =?us-ascii?Q?BLXSvEIB3Qddhevwtl2tSEIXc5ZwWbkhCMaGd+P8+uuQ0mheHE3PzYElhgSx?=
 =?us-ascii?Q?Rg2Y9FLfRu8iC/M2Q0thCt+0B+17dVXkDM5QOGi2xxPKIx+luLaF62pXjP64?=
 =?us-ascii?Q?Lxi+DNbsn63tZQbwTPe/ZUJp1EUq7eBg2hbbiponSVJLDd8sCmBi58RhSelo?=
 =?us-ascii?Q?cHJ+MuZP+Msrw6dVshrHNGfgrdUxCvPfeG/oUAubnr13PvJ51DkrAcT+Lcdo?=
 =?us-ascii?Q?de1LZZbCp7EaS5mZGmICiIY169pxTHNSSMObBCjGp40BELJKVpeBeR5HL2IF?=
 =?us-ascii?Q?0cSvy9IdttDDfcwsNSC5yE9Y8O2vE/tR9P4iAFZWF7Y1ZX1Svo9m557gwppa?=
 =?us-ascii?Q?r7g0URV3hHCfwrWbyooj2TASbaBhxixRUSwlPWVFDZ6uh3XhA//gTQBtcfoC?=
 =?us-ascii?Q?iyeeHEcLjRx8AR0IZNxFsEu0ren809NtVm9HDlu0gq3lEJpoyWWLU0nt6rO0?=
 =?us-ascii?Q?nI7jiyOTVYkMvbLhwnCcuapmj9Sx8CQEfCJPeLz4m5A3ZV87SCntCWdFEitQ?=
 =?us-ascii?Q?xs7PsoQc6dDEKv4kopzm4CbAeEZ9ayAcF7nEzHDxTPYTBELBlDORVsgSvOgC?=
 =?us-ascii?Q?aeyGu7wiTqm0AppmP2i0I8TUMTbftgFfBY61oNQwNRzpLrb7vvGpHCA0lvXD?=
 =?us-ascii?Q?03L/gQayczAS3gWXvpsCg549bY/n49eSClg9xjl1+DXGtVQL/nepykiSoZ2e?=
 =?us-ascii?Q?lRAntMwQnFmUNteTgueQZXni5WJZ9PkBVmHP58+Pj9NDTMUIuqVv+R4zzxts?=
 =?us-ascii?Q?jQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01156a90-22bf-4e7b-7613-08db07826787
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2023 14:08:06.9318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VRh21KfJ6BnixRAsjaUjbZqDNZTmGmVGC1WunK/LU22ljK2WRFEm+L5Rv6EdgKbWHTkjSQjFa4qVNhosnW9Ing==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9142
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Frank reports that in a mt7530 setup where some ports are standalone and
some are in a VLAN-aware bridge, 8021q uppers of the standalone ports
lose their VLAN tag on xmit, as seen by the link partner.

This seems to occur because once the other ports join the VLAN-aware
bridge, mt7530_port_vlan_filtering() also calls
mt7530_port_set_vlan_aware(ds, cpu_dp->index), and this affects the way
that the switch processes the traffic of the standalone port.

Relevant is the PVC_EG_TAG bit. The MT7530 documentation says about it:

EG_TAG: Incoming Port Egress Tag VLAN Attribution
0: disabled (system default)
1: consistent (keep the original ingress tag attribute)

My interpretation is that this setting applies on the ingress port, and
"disabled" is basically the normal behavior, where the egress tag format
of the packet (tagged or untagged) is decided by the VLAN table
(MT7530_VLAN_EGRESS_UNTAG or MT7530_VLAN_EGRESS_TAG).

But there is also an option of overriding the system default behavior,
and for the egress tagging format of packets to be decided not by the
VLAN table, but simply by copying the ingress tag format (if ingress was
tagged, egress is tagged; if ingress was untagged, egress is untagged;
aka "consistent). This is useful in 2 scenarios:

- VLAN-unaware bridge ports will always encounter a miss in the VLAN
  table. They should forward a packet as-is, though. So we use
  "consistent" there. See commit e045124e9399 ("net: dsa: mt7530: fix
  tagged frames pass-through in VLAN-unaware mode").

- Traffic injected from the CPU port. The operating system is in god
  mode; if it wants a packet to exit as VLAN-tagged, it sends it as
  VLAN-tagged. Otherwise it sends it as VLAN-untagged*.

*This is true only if we don't consider the bridge TX forwarding offload
feature, which mt7530 doesn't support.

So for now, make the CPU port always stay in "consistent" mode to allow
software VLANs to be forwarded to their egress ports with the VLAN tag
intact, and not stripped.

Link: https://lore.kernel.org/netdev/trinity-e6294d28-636c-4c40-bb8b-b523521b00be-1674233135062@3c-app-gmx-bs36/
Fixes: e045124e9399 ("net: dsa: mt7530: fix tagged frames pass-through in VLAN-unaware mode")
Reported-by: Frank Wunderlich <frank-w@public-files.de>
Tested-by: Frank Wunderlich <frank-w@public-files.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/dsa/mt7530.c | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 616b21c90d05..3a15015bc409 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -1302,14 +1302,26 @@ mt7530_port_set_vlan_aware(struct dsa_switch *ds, int port)
 		if (!priv->ports[port].pvid)
 			mt7530_rmw(priv, MT7530_PVC_P(port), ACC_FRM_MASK,
 				   MT7530_VLAN_ACC_TAGGED);
-	}
 
-	/* Set the port as a user port which is to be able to recognize VID
-	 * from incoming packets before fetching entry within the VLAN table.
-	 */
-	mt7530_rmw(priv, MT7530_PVC_P(port), VLAN_ATTR_MASK | PVC_EG_TAG_MASK,
-		   VLAN_ATTR(MT7530_VLAN_USER) |
-		   PVC_EG_TAG(MT7530_VLAN_EG_DISABLED));
+		/* Set the port as a user port which is to be able to recognize
+		 * VID from incoming packets before fetching entry within the
+		 * VLAN table.
+		 */
+		mt7530_rmw(priv, MT7530_PVC_P(port),
+			   VLAN_ATTR_MASK | PVC_EG_TAG_MASK,
+			   VLAN_ATTR(MT7530_VLAN_USER) |
+			   PVC_EG_TAG(MT7530_VLAN_EG_DISABLED));
+	} else {
+		/* Also set CPU ports to the "user" VLAN port attribute, to
+		 * allow VLAN classification, but keep the EG_TAG attribute as
+		 * "consistent" (i.o.w. don't change its value) for packets
+		 * received by the switch from the CPU, so that tagged packets
+		 * are forwarded to user ports as tagged, and untagged as
+		 * untagged.
+		 */
+		mt7530_rmw(priv, MT7530_PVC_P(port), VLAN_ATTR_MASK,
+			   VLAN_ATTR(MT7530_VLAN_USER));
+	}
 }
 
 static void
-- 
2.34.1