Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965501AbXIBLkk (ORCPT ); Sun, 2 Sep 2007 07:40:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756013AbXIBLk1 (ORCPT ); Sun, 2 Sep 2007 07:40:27 -0400 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:58324 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755702AbXIBLkZ (ORCPT ); Sun, 2 Sep 2007 07:40:25 -0400 Date: Sun, 2 Sep 2007 04:40:21 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Christoph Hellwig cc: Mingming Cao , linux-fsdevel@vger.kernel.org, adilger@clusterfs.com, sho@tnes.nec.co.jp, ext4 development , linux-kernel@vger.kernel.org Subject: Re: [RFC 1/2] JBD: slab management support for large block(>8k) In-Reply-To: <20070901183922.GA12907@infradead.org> Message-ID: References: <20070828190551.415127746@sgi.com> <20070828190735.292638294@sgi.com> <1188432669.3799.35.camel@localhost.localdomain> <1188434857.3799.76.camel@localhost.localdomain> <1188605538.3837.51.camel@localhost.localdomain> <20070901183922.GA12907@infradead.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 804 Lines: 20 On Sat, 1 Sep 2007, Christoph Hellwig wrote: > On Fri, Aug 31, 2007 at 05:12:18PM -0700, Mingming Cao wrote: > > >From clameter: > > Teach jbd/jbd2 slab management to support >8k block size. Without this, it refused to mount on >8k ext3. > > > But the real fix is to kill this code. We can't send down slab pages > down the block layer without breaking iscsi or aoe. And this code is > only used in so rare cases that all the normal testing won't hit it. > Very bad combination. We are doing what you describe right now. So the current code is broken? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/