Date:   Sun, 5 Feb 2023 22:39:06 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        Frank Wunderlich <frank-w@public-files.de>,
        erkin.bozoglu@xeront.com, richard@routerhints.com
Subject: Re: [PATCH net] net: dsa: mt7530: don't change PVC_EG_TAG when CPU
 port becomes VLAN-aware
Message-ID: <20230205203906.i3jci4pxd6mw74in@skbuf>
References: <20230205140713.1609281-1-vladimir.oltean@nxp.com>
 <3649b6f9-a028-8eaf-ac89-c4d0fce412da@arinc9.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3649b6f9-a028-8eaf-ac89-c4d0fce412da@arinc9.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmNYYm85dmpWQUxRTy9jemlUODQ4Zkp3SVhUdVJjVXorSGMwT0l3OGhhRy9y?=
 =?utf-8?B?ZW45b1ZiN2pUZlVidnRDV3NCNFh2WTBzU1pBeWhBNmlGSVJHUkZsamFhakdh?=
 =?utf-8?B?Szh0Mytsc0NJdkJDd2JZZFh2TjZza0JWbWxDczNhMEdUOHZ2dXFmQzJqOGNk?=
 =?utf-8?B?RXFNeUp3c0IvT0FTZHZST3hSQzdYSG9sa0NzT1JXRHpZMTN5TDcraCt2WVdV?=
 =?utf-8?B?MnYvZm1aV2F1MmtyMTc0WERSeS9vMlZEY1VuS3ZMUmZ1bmxxU3RMa2Q5NVkw?=
 =?utf-8?B?c1pTUFpzdS9NZkxwTUp5VmFyVWJVWlRWNGNtcjJScnZJbEJsU2RCaUZDVW1P?=
 =?utf-8?B?djU0VjRteFhrcTVHMlNESCs4Rm9pYTZDRHhQM2xzVjVjZlgrTEd2cld2WWFh?=
 =?utf-8?B?WGZMQXpzcmZrK1pvdmc3a0VSNmtVTXZRbHpYMkZGV00zRmpJdlAzVHhBaitK?=
 =?utf-8?B?NDZidzgwOEY3Q0p2Yk9mNlZUbW1RNE5HTnVuRUZuMGZRdDByTlJGaUdUUTNC?=
 =?utf-8?B?N1dQbnpmOXY4QlFmOGtwQWFzWWdGeXdNTmdIbzlva0dGdDVxcjM3aUM0L01p?=
 =?utf-8?B?Y05XRmloQVBFc214TjEwUGFlcitpV2syVlFObVc0dFNob2FMdWxzTHBzRXdy?=
 =?utf-8?B?TW85VllTdmlVTFQzUUZHNHRKOThpRUJ4a0ZYcmoxWDg5b2c1QUhEcmIxSUhs?=
 =?utf-8?B?dGNhQXN6SEhUczBtMmxRb1FpVVR6YlRDZndWZ2tLNldkQTZoMFV1VWFxTUlq?=
 =?utf-8?B?NlhCWnhuQjlERGc4Z28yMWhZWW0zNmxweDdBZVJQaENiVzJ2dmJaTkNSVDJY?=
 =?utf-8?B?NlkxeWxVZEJPTi9RUFliNjZHL0ErVWFDMEE0SDQ4ZTdTYmV3eEF0dmdjSCtn?=
 =?utf-8?B?ZmRPRHpCVGZxdXZpUGVLUlZ1eHBLRCt2enRSWXY0bkk2SzE3NmNvNWx2S2Ir?=
 =?utf-8?B?cXpVN0trRmtUMFZyS3dvZjAwWndTeXdpbExyeXg2cHk4UkRLZ2xSeEdkcm83?=
 =?utf-8?B?WUZZUXpPcEpqTmY1SGhqOEJlMGlTeHZRbkpJQkJXZzhLSnJKLzVLOGJzZFox?=
 =?utf-8?B?eFVQNTRTbjJPb3FIWDgyOHNiWlNERWErYzZoYVJ1QU90QkQ1Y29kd0NsQ1c0?=
 =?utf-8?B?dlZuYVRMMU9CMTBySHZ0RmFJbFgvMzczWldPVCtCd0V0SFc5SUp2YUJVR1ZI?=
 =?utf-8?B?OEwyZlVURnA5bnAyZEZYWVVqeWh2Q0ZLRFFtdy9vdkRxczNKTjRJTHE3Njdv?=
 =?utf-8?B?b0dNZUxsZ3d2ZEVvVEZzWHA0UEM0bnlROU16L0xXZ1lwWElLNjI1cU1tWEpU?=
 =?utf-8?B?Qjhja1pzZUZQTjJ4RlpaOE5NTTlBMDBxWExmbFpNcHgzSzlweGp2UkxPaEU2?=
 =?utf-8?B?NkVSNDMzVksxcktOaDYzbzZaaFpaaEFlMmwyUFFFSGVrTjBydEsxY0pQSENt?=
 =?utf-8?B?eE1Lc3VIOTNsN0VvQjlHeFovdUZrZ3dXL1dQWlBROWQ1M0VVRmhuTlRvV3l1?=
 =?utf-8?B?N1hvZHRLSDhJbElTZDhkbXhla3RYWGRLZU5KRVordVJTcVpsNGY3Z2pIQkwr?=
 =?utf-8?B?eC84cjdOekZkSnlDY0NCVWVzdW9oWFVWTDF0S2N0Tnh3VktoZy9oM09Ba0Uy?=
 =?utf-8?B?NFM5cXRlR05vQ0xGVysvL2xGcjQwSnZ1a3NqOHpEKzlBK2pUT1pqd3NnRzR1?=
 =?utf-8?B?ZWxCTTE1MDMweUp6b1V2YU9nY2E5T3p6ekc0NjMveGM2RjNMNzE1YkZGYWw2?=
 =?utf-8?B?QXo2VlB3RE9nSTl1N01wcWN2aHVqb2gwOUROSFhIaDFMbW9BN0taU3l0a3M1?=
 =?utf-8?B?RTRxZlZybmd5VFBlZTluQ04wY2czOWxWV1VHVG9CeFg1TzlvNHF2VTZwVkZS?=
 =?utf-8?B?Y2ZyZFp5OEQvM3oxMHlKdnRnUVVnTCtCSzZybU81Z0EydXIxODJLLzVuSzRR?=
 =?utf-8?B?ZFVXeUhNcTFnYVlSenNnUHY1cE9zQjRMZ0UvK1FoUlpDclZybWZIMkZVNURi?=
 =?utf-8?B?eFhGNHZjUVpsVjQwNXJwU21wR1JtTG5ncUZ6cmRyN3kxODVqNVFESkZ2aENL?=
 =?utf-8?B?cmxvVkxJSWd0Y3pLOTNRdVBsSkc5ajNINDZMbEZZU21YaE5may9IM0w3V29p?=
 =?utf-8?B?bHhWTWFZaTQ3VnBMN3Z3aERpblVsUlpUb2pVTitxYjhoaHJyWkgzRTFiUXMz?=
 =?utf-8?B?WEE9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0f2945d-ee50-4e43-6dd5-08db07b9091c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2023 20:39:10.9071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ufbXjgal/pyGFKdx6BQjw9IZcqKTMgqhFai2UWeiek2QUuAeg/kudD5+PLlTOg/L2gUPspQ7CBEJ38wd3s9F8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8953
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arınç,

On Sun, Feb 05, 2023 at 10:25:27PM +0300, Arınç ÜNAL wrote:
> Unrelated to this, as in it existed before this patch, port@0 hasn't been
> working at all on my MT7621AT Unielec U7621-06 board and MT7623NI Bananapi
> BPI-R2.
> 
> Packets are sent out from master eth1 fine, the computer receives them.
> Frames are received on eth1 but nothing shows on the DSA slave interface of
> port@0. Sounds like malformed frames are received on eth1.

I need to ask, how do the packets look like on the RX path of the DSA
master, as seen by tcpdump -i eth1 -e -n -Q in -XX? If they aren't
received, can you post consecutive outputs from ethtool -S eth1 | grep -v ': 0',
to see what (error) counter increments?