From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "Joel Fernandes (Google)" <joel@joelfernandes.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Frederic Weisbecker <frederic@kernel.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        Boqun Feng <boqun.feng@gmail.com>
Subject: RE: [PATCH] rcu/tree: Improve comments in rcu_report_qs_rdp()
Thread-Topic: [PATCH] rcu/tree: Improve comments in rcu_report_qs_rdp()
Thread-Index: AQHZOD9ejAi0bsndXU+9RwTFzHNkO67BPBpQ
Date:   Mon, 6 Feb 2023 03:09:35 +0000
Message-ID: <PH0PR11MB58800C6FD1C0DDF8EC67DB5DDADA9@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20230204022051.2737724-1-joel@joelfernandes.org>
In-Reply-To: <20230204022051.2737724-1-joel@joelfernandes.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nUpSKvbRuBlMUFglXLkjCXTdkbf9Gq9smIJjCRV8kL6PuvHI+sBfCrc4ZiSx?=
 =?us-ascii?Q?KzNkiUOcF7vLp2cYTrepQAFr1JCK4o3VRS1hQ/VPfMuzmglVkWetAWJT6RUf?=
 =?us-ascii?Q?s0M8T+DHIWf/QGS7yabd6VEy1J/QHFs5T5y1HCJCIE7I+5fyusvv3KzB0uFK?=
 =?us-ascii?Q?Y87n40V1QhDi2vV9reXttKD1Z0GBaq/Y+ldJ39aPlvyU7BvNUBCMHbRQl3Yk?=
 =?us-ascii?Q?Qv95LT6gSZ8rIKuduouw7Nety0AxBWt65eaOouEskMTLs1LnoarK5nCpLqPa?=
 =?us-ascii?Q?uG1Pjq4UPVgu+kxa8OtZx9dxqUmJf5lKymvncrBmI/NFDbUm1IiVVtB7CrLH?=
 =?us-ascii?Q?h7DRFFKr0XwsU8DVqhSntf2bI8hYLUEijdxuDWWxr7TyQJ8F00HS3SD/Phf1?=
 =?us-ascii?Q?axz4/EYxRxLqnivUX3CUHaSXLdSIUIOCVgix6+2SVTgoA/Si9JxzBLqYM/DF?=
 =?us-ascii?Q?K7rcw8Y2c1BYmVUXcE/2nhireLho+v3YLJI/UHsOUtI6B+sEL6q0mRXrIfDS?=
 =?us-ascii?Q?L4Lyy2A/1tjYcsWMMg4SlgZ89Q3Gvh7HgbFpHpj/aWqquJzeuetsr119xjTf?=
 =?us-ascii?Q?ibOfXRdhV5UIlP2FCT8mI9+2DmBkexC/K3J7JaUOciyL6R8oUbUZ+MK92SFO?=
 =?us-ascii?Q?F1kJoUsgnuGjHNuzNFFPTwKNC7YkXiNi8AGhV0cqqBAiAMppzQWS+m8wUeBK?=
 =?us-ascii?Q?QwfzM6SYPPJpsX9lGvkr06GMD4Jlrk1e0ExjH0pCROF4sie7b2a7bgFMGokR?=
 =?us-ascii?Q?Ux3v8lu79/mm58GeWg146sP7HZMM2DpUoiyqxoI6gW7rct1sDHzRRFG/2TZ/?=
 =?us-ascii?Q?PudS5Ju853P2N2sXO6qp6HJ+YbBbnvwpS8UnKnj2i9N9aNlBxDfo4VemmK6P?=
 =?us-ascii?Q?1yyU2CAONMW+IlHgnYNd9T7M+QZi/RuvlzRudlZ6dIt1PlKpcswQgB4JQ56O?=
 =?us-ascii?Q?ZX0MLg+qZJtm4pUCo+pSVQBw1FGhg2xfWh8J7E2DC1wY0E4fh+4M7kR4oDBY?=
 =?us-ascii?Q?zI430mrQQjuNAgkGaVFAL9mxbxcrMCScP1mSreNDYo/X4/RQIA2jUMncSOqz?=
 =?us-ascii?Q?vRkD2fTYEimpY81JBhnbG0GvgMmjDMluYXnAoFBdgxd9PWMbMrm+8sdTFTAu?=
 =?us-ascii?Q?TZyGssGJAgTplaCSNb5q5mbm391HZGYSgcqQowHAXUdSbiO/JSG6a6YSvuWZ?=
 =?us-ascii?Q?vND2A+hKIZC2TF5KiT1LfnV+FWZUowlkCU2fMkzDy3ihpKVasGhbEI4BUgbC?=
 =?us-ascii?Q?rGRkxdcJf65b/eppigFO1T/RHmAC6ZAW9mX+DwkJ0OgC6jgY+MPR+lTF3TV4?=
 =?us-ascii?Q?aEgH2FoOUhulxFKq1uereOACq6XsU90EemM1i0/K5sM/sh3OCTTtiVxjeNNc?=
 =?us-ascii?Q?lM6i4iweyNJj7MUfsZSNISpXaWvTCZ5N4iWRCebczYA8ozjyW2wlnXjjZ+dx?=
 =?us-ascii?Q?AWkznZtMCnKJ/cm/sfJX7w8N+5Nupt7ICnuCxfQ+dhQsmJhYUq8yalqvPh3H?=
 =?us-ascii?Q?I8to7Xz6Wy6XJrqtLnh7YsqlHQ30L96UOEP6TrGSZ6mlNKTmYox3DTeeXk/q?=
 =?us-ascii?Q?k+Temo6JAcbfCAe1To7UqQ1m8AS+Mxw1Y991amEb?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2603c9ac-1a8a-4d6d-186a-08db07ef93b0
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2023 03:09:35.9060
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lNASBW61MXXbqUvEnL4fkZrm8aq3BUhE6rureCg33G0tsIu5HySmUKE6PUaUoNg2sY80wKMHG2THWvq4SSDbXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7601
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>Recent discussion triggered due to a patch linked below, from Qiang,
>shed light on the need to accelerate from QS reporting paths.
>
>Update the comments to capture this piece of knowledge.
>
>Link: https://lore.kernel.org/all/20230118073014.2020743-1-qiang1.zhang@in=
tel.com/
>Cc: Qiang Zhang <Qiang1.zhang@intel.com>
>Cc: Frederic Weisbecker <frederic@kernel.org>
>Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
>
>---
> kernel/rcu/tree.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
>index 93eb03f8ed99..713eb6ca6902 100644
>--- a/kernel/rcu/tree.c
>+++ b/kernel/rcu/tree.c
>@@ -1983,7 +1983,12 @@ rcu_report_qs_rdp(struct rcu_data *rdp)
> 	} else {
> 		/*
> 		 * This GP can't end until cpu checks in, so all of our
>-		 * callbacks can be processed during the next GP.
>+		 * callbacks can be processed during the next GP. Do
>+		 * the acceleration from here otherwise there may be extra
>+		 * grace period delays, as any accelerations from rcu_core()


Does the extra grace period delays means that if not accelerate callback,=20
the grace period will take more time to end ? or refers to a delay in the
start time of a new grace period?

Thanks
Zqiang

>+		 * or note_gp_changes() may happen only after the GP after the
>+		 * current one has already started. Further, rcu_core()
>+		 * only accelerates if RCU is idle (no GP in progress).
> 		 *
> 		 * NOCB kthreads have their own way to deal with that...
> 		 */
>@@ -1993,6 +1998,12 @@ rcu_report_qs_rdp(struct rcu_data *rdp)
> 			/*
> 			 * ...but NOCB kthreads may miss or delay callbacks acceleration
> 			 * if in the middle of a (de-)offloading process.
>+			 *
>+			 * Such missed acceleration may cause the callbacks to
>+			 * be stranded until RCU is fully de-offloaded, as
>+			 * acceleration from rcu_core() and note_gp_changes()
>+			 * cannot happen for fully/partially offloaded mode due
>+			 * to ordering dependency between rnp lock and nocb_lock.
> 			 */
> 			needacc =3D true;
> 		}
>--=20
>2.39.1.519.gcb327c4b5f-goog
>