From:   <Shravan.Chippa@microchip.com>
To:     <sakari.ailus@iki.fi>
CC:     <paul.j.murphy@intel.com>, <daniele.alessandrelli@intel.com>,
        <mchehab@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
        <festevam@gmail.com>, <kernel@pengutronix.de>, <linux-imx@nxp.com>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH RESEND v10 5/5] media: i2c: imx334: update pixel and link
 frequency
Thread-Topic: [PATCH RESEND v10 5/5] media: i2c: imx334: update pixel and link
 frequency
Thread-Index: AQHZLUnPWr0eVsa9dkWYdFRaw/UsYa6sow+AgABq7FCAAdoPAIACfu1wgBAIoiA=
Date:   Mon, 6 Feb 2023 04:43:42 +0000
Message-ID: <PH0PR11MB561174CA61F9C858577F726781DA9@PH0PR11MB5611.namprd11.prod.outlook.com>
References: <20230121033713.3535351-1-shravan.chippa@microchip.com>
 <20230121033713.3535351-6-shravan.chippa@microchip.com>
 <Y88SG5ndXjQ9AjZg@valkosipuli.retiisi.eu>
 <PH0PR11MB56119C93EB4A19FEFC03778F81C99@PH0PR11MB5611.namprd11.prod.outlook.com>
 <Y9D5eG8PP/qYPk40@valkosipuli.retiisi.eu>
 <PH0PR11MB5611880BB2141A73B2D67D7181CC9@PH0PR11MB5611.namprd11.prod.outlook.com>
In-Reply-To: <PH0PR11MB5611880BB2141A73B2D67D7181CC9@PH0PR11MB5611.namprd11.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N7y6agNp0ziLg3uZJyHFs/E9L7tp6vWx2d1OBOec6HVh2CpxFzuY7NNW/Fzz?=
 =?us-ascii?Q?FQ3OqiY1eme4czGkGVF/9J5o49BIAwZjFBoeXJuI9ZzRyKPg0Usiad1snx7N?=
 =?us-ascii?Q?BznncKWUQOK4BV2xiTNdOL32QVnANLSCTAa+BNsygLQgqcDJf4sPLHZHkLXX?=
 =?us-ascii?Q?uD+fJF5SEL+94SRQmgDjc8/RDQpIHXUE8I1VTz/2HF8SvwmfMzU3sImxE8FB?=
 =?us-ascii?Q?OldPAnEDvsLMRSjRNzJPvWcJw2HJwNolrXnlXQZHFILn91NSfX6M7XnlUghq?=
 =?us-ascii?Q?2KuKSeaREXB0uFymuapLwLtPf3pQBbdqrm8RRt8uzk2SQbWW3C/QVy3WlfgW?=
 =?us-ascii?Q?7c8a5nnwkltXDyaBxKJ9B5BNW/okD89saYLhg5PrTNS+egAt7PqxWbxaxFw7?=
 =?us-ascii?Q?Cw7HUm6RrREoidXnukH6io5bpUu8lpZqD5UoEofWYaIORH/iDXHHu717cfGQ?=
 =?us-ascii?Q?d9kGK+lgntYPVM99a6x1cr6ByMU1vEK7DsMHdJbG8o51rAylZYl+S6PuwrAe?=
 =?us-ascii?Q?NNPZepfre/00O8/CZwX5NfK/W8V+wziMpaZwe3sWovX0/lJLv37wpYvOcKsD?=
 =?us-ascii?Q?vzxk5tSdF26f5D+oGXnmh/jYgM0b+kNTAgiiJ4+JCK48plmIU5M2X8GwBfS/?=
 =?us-ascii?Q?wPLp+niRGCGQKnqIK4LNWKB6hgGoKnRgvQpX9x8NJCTGGqm7KmPKs+bAdL6G?=
 =?us-ascii?Q?kZs9J6EhwdSeBUPJaBGadaJ0W19Ou5ovaoGsgahwZ+lAnymvDyxlcbvPLgca?=
 =?us-ascii?Q?qoIuA3Two61yEUQ+iYGkISOFDKjRi5JbPm4JRMQNqzvFkz6os1HDofHYdLLz?=
 =?us-ascii?Q?1WI1PMZUqoqBjPHl8jRTOKuZJiZ3d56t1z09hEyX9XvfMboIrDdT9h/kzSzs?=
 =?us-ascii?Q?SaKJ1ZhjPqPgJnkW4OH7ca8h46dk3kf9s3ITl2QmtopLCRJlDw4f6tBqkAhC?=
 =?us-ascii?Q?Hkb2WJZ/no9FAOo1TIJrMNMWZkbTTCOpboBp6JvNnLnJ+TsD/A37muFjs8/w?=
 =?us-ascii?Q?qtB2xJtf4U/VzDuWrvLnwbvddlPx24XbOCgmb2rT/t9j7HPpSwX1BjN1fNBj?=
 =?us-ascii?Q?G5vGKkEiORyZQTUlbbrABxXj272BfBAB2mStSQTXa+8Z+K33vP55QbuX30Un?=
 =?us-ascii?Q?A4KFguwcsfVkW12BgoM6EO6VemDyC6EckeKDXQHGqH5ByvaaHoR/KaNkuU6O?=
 =?us-ascii?Q?5cdhl42mVzNWrwT37/ZIqN3nBEN7YtU8KIHwq/8Z71RM8zuwSBg4ZvjT3e4y?=
 =?us-ascii?Q?9NnxprStucxMTsx5xY2c0GeO1ZzrsWXp3RAuUqiURRCZhA/BTd53NKyKCqR5?=
 =?us-ascii?Q?69gkS+ARr+ya6zXOrd2fF5hLNBdg3Koc5YwmkyC9EBztM+VLG6pxhrkOYS2O?=
 =?us-ascii?Q?Ry4PNH7otFRjorMmQ/q+26RWZVuqqevSjls58zjYTadsNL+2ttpgS7gatbRR?=
 =?us-ascii?Q?5sH7IKM2LRvWdlDx+MQDgDvTxb6A0ZtJkanqGYI11FwNYGBv0v+c9blCeLIH?=
 =?us-ascii?Q?5QmZx2PX3c7BlhKp9ZqpDe2zR+zyHX8pMk33q54RwryJhEIIFz5vQ/iHWejw?=
 =?us-ascii?Q?LAB9g8SRXB3x3Z6PazsAg4+iqBZjlNQBqA0y+4/wE4nNXKiTllu1pHWYwQAf?=
 =?us-ascii?Q?4A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5611.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f23ab27-cbae-418e-e635-08db07fcb934
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2023 04:43:42.2992
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: we+oyS+vlpz4tCrene6e7G2xgTxjUXm5VM/79QtA4/Ozyi4yRLRqmxHJ51kbI7ADDJr5HcrQvAmqe5k8fnv8ubSD0Xii/IdRRK+XbaeQSrA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5908
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sakari,


> -----Original Message-----
> From: shravan Chippa - I35088
> Sent: 27 January 2023 05:40 AM
> To: Sakari Ailus <sakari.ailus@iki.fi>
> Cc: paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
> mchehab@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; festevam@gmail.com;
> kernel@pengutronix.de; linux-imx@nxp.com; linux-media@vger.kernel.org;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org
> Subject: RE: [PATCH RESEND v10 5/5] media: i2c: imx334: update pixel and
> link frequency
>=20
> Hi Sakari,
>=20
> > -----Original Message-----
> > From: Sakari Ailus <sakari.ailus@iki.fi>
> > Sent: 25 January 2023 03:12 PM
> > To: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>
> > Cc: paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
> > mchehab@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > shawnguo@kernel.org; s.hauer@pengutronix.de; festevam@gmail.com;
> > kernel@pengutronix.de; linux-imx@nxp.com; linux-
> media@vger.kernel.org;
> > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org
> > Subject: Re: [PATCH RESEND v10 5/5] media: i2c: imx334: update pixel
> > and link frequency
> >
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > the content is safe
> >
> > Hi Shravan,
> >
> > On Tue, Jan 24, 2023 at 05:34:02AM +0000, Shravan.Chippa@microchip.com
> > wrote:
> > > Hi Sakari,
> > >
> > > > -----Original Message-----
> > > > From: Sakari Ailus <sakari.ailus@iki.fi>
> > > > Sent: 24 January 2023 04:33 AM
> > > > To: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>
> > > > Cc: paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
> > > > mchehab@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> > > > shawnguo@kernel.org; s.hauer@pengutronix.de;
> festevam@gmail.com;
> > > > kernel@pengutronix.de; linux-imx@nxp.com;
> > > > linux-media@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > > devicetree@vger.kernel.org; linux-arm- kernel@lists.infradead.org
> > > > Subject: Re: [PATCH RESEND v10 5/5] media: i2c: imx334: update
> > > > pixel and link frequency
> > > >
> > > > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > > > know the content is safe
> > > >
> > > > Hi Shravan,
> > > >
> > > > On Sat, Jan 21, 2023 at 09:07:13AM +0530, shravan kumar wrote:
> > > > > From: Shravan Chippa <shravan.chippa@microchip.com>
> > > > >
> > > > > Update pixel_rate and link frequency for 1920x1080@30 while
> > > > > changing mode.
> > > > >
> > > > > Add dummy ctrl cases for pixel_rate and link frequency to avoid
> > > > > error while changing the modes dynamically.
> > > > >
> > > > > Add support to handle multiple link frequencies.
> > > > >
> > > > > Suggested-by: Sakari Ailus <sakari.ailus@iki.fi>
> > > > > Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
> > > > > ---
> > > > >  drivers/media/i2c/imx334.c | 41
> > > > > ++++++++++++++++++++++++++++----------
> > > > >  1 file changed, 30 insertions(+), 11 deletions(-)
> > > > >
> > > > > diff --git a/drivers/media/i2c/imx334.c
> > > > > b/drivers/media/i2c/imx334.c index 309c706114d2..62b104eaa437
> > > > > 100644
> > > > > --- a/drivers/media/i2c/imx334.c
> > > > > +++ b/drivers/media/i2c/imx334.c
> > > > > @@ -49,7 +49,8 @@
> > > > >  #define IMX334_INCLK_RATE    24000000
> > > > >
> > > > >  /* CSI2 HW configuration */
> > > > > -#define IMX334_LINK_FREQ     891000000
> > > > > +#define IMX334_LINK_FREQ_891M        891000000
> > > > > +#define IMX334_LINK_FREQ_445M        445500000
> > > > >  #define IMX334_NUM_DATA_LANES        4
> > > > >
> > > > >  #define IMX334_REG_MIN               0x00
> > > > > @@ -139,12 +140,14 @@ struct imx334 {
> > > > >       u32 vblank;
> > > > >       const struct imx334_mode *cur_mode;
> > > > >       struct mutex mutex;
> > > > > +     unsigned long menu_skip_mask;
> > > > >       u32 cur_code;
> > > > >       bool streaming;
> > > > >  };
> > > > >
> > > > >  static const s64 link_freq[] =3D {
> > > > > -     IMX334_LINK_FREQ,
> > > > > +     IMX334_LINK_FREQ_891M,
> > > > > +     IMX334_LINK_FREQ_445M,
> > > > >  };
> > > > >
> > > > >  /* Sensor mode registers for 1920x1080@30fps */ @@ -468,7
> > > > > +471,7 @@ static const struct imx334_mode supported_modes[] =3D {
> > > > >               .vblank_min =3D 45,
> > > > >               .vblank_max =3D 132840,
> > > > >               .pclk =3D 297000000,
> > > > > -             .link_freq_idx =3D 0,
> > > > > +             .link_freq_idx =3D 1,
> > > > >               .reg_list =3D {
> > > > >                       .num_of_regs =3D ARRAY_SIZE(mode_1920x1080_=
regs),
> > > > >                       .regs =3D mode_1920x1080_regs, @@ -598,6
> > > > > +601,11 @@ static int imx334_update_controls(struct imx334
> > > > > +*imx334,
> > > > >       if (ret)
> > > > >               return ret;
> > > > >
> > > > > +     ret =3D __v4l2_ctrl_modify_range(imx334->pclk_ctrl, mode->p=
clk,
> > > > > +                                    mode->pclk, 1, mode->pclk);
> > > > > +     if (ret)
> > > > > +             return ret;
> > > > > +
> > > > >       ret =3D __v4l2_ctrl_modify_range(imx334->hblank_ctrl, mode-
> >hblank,
> > > > >                                      mode->hblank, 1, mode->hblan=
k);
> > > > >       if (ret)
> > > > > @@ -698,6 +706,8 @@ static int imx334_set_ctrl(struct v4l2_ctrl *=
ctrl)
> > > > >               pm_runtime_put(imx334->dev);
> > > > >
> > > > >               break;
> > > > > +     case V4L2_CID_PIXEL_RATE:
> > > > > +     case V4L2_CID_LINK_FREQ:
> > > > >       case V4L2_CID_HBLANK:
> > > > >               ret =3D 0;
> > > > >               break;
> > > > > @@ -1047,7 +1057,7 @@ static int imx334_parse_hw_config(struct
> > > > > imx334
> > > > *imx334)
> > > > >       struct fwnode_handle *ep;
> > > > >       unsigned long rate;
> > > > >       int ret;
> > > > > -     int i;
> > > > > +     int i, j;
> > > >
> > > > unsigned int would be nicer.
> > > I will change.
> > > >
> > > > >
> > > > >       if (!fwnode)
> > > > >               return -ENXIO;
> > > > > @@ -1097,11 +1107,20 @@ static int imx334_parse_hw_config(struct
> > > > > imx334
> > > > *imx334)
> > > > >               goto done_endpoint_free;
> > > > >       }
> > > > >
> > > > > -     for (i =3D 0; i < bus_cfg.nr_of_link_frequencies; i++)
> > > > > -             if (bus_cfg.link_frequencies[i] =3D=3D IMX334_LINK_=
FREQ)
> > > > > +     for (i =3D 0; i < bus_cfg.nr_of_link_frequencies; i++) {
> > > > > +             for (j =3D 0; j < ARRAY_SIZE(link_freq); j++) {
> > > > > +                     if (bus_cfg.link_frequencies[i] =3D=3D link=
_freq[j]) {
> > > > > +                             set_bit(j,
> > > > > + &imx334->menu_skip_mask);
> > > >
> > > > Is there a guarantee that you'll only be using the modes with the
> > > > listed frequencies? I don't see one but I might have missed it.
> > >
> > > If I understand it correctly, the question here is, the listed
> > > freqeunceis and modes are one to one mapped? Then yes.
> >
> > I don't see this being checked in imx334_set_pad_format(), for instance=
.
> >
> > If a frequency isn't in DT, the driver isn't supposed to be using it ei=
ther.
>=20
> Yes, there is no check.
>=20
> But, if a frequency is not in DT, the driver will not add in menu items.
> So, the function imx334_set_pad_format() -> imx334_update_controls()
> fails, if we set the frequencies which are not there in the DT or menu it=
ems.
>=20

Are you ok with the above explanation or any changes you are expecting?
Please do let me know if there are any changes needed.
I am planning to send the next version.

Thanks,
Shravan

>=20
> Thanks,
> Shravan
>=20
> >
> > >
> > > Thanks.
> > > shravan
> > > >
> > > > > +                             break;
> > > > > +                     }
> > > > > +             }
> > > > > +
> > > > > +             if (j =3D=3D ARRAY_SIZE(link_freq)) {
> > > > > +                     ret =3D dev_err_probe(imx334->dev, -EINVAL,
> > > > > +                                         "no supported link
> > > > > + freq found\n");
> > > > >                       goto done_endpoint_free;
> > > > > -
> > > > > -     ret =3D -EINVAL;
> > > > > +             }
> > > > > +     }
> > > > >
> > > > >  done_endpoint_free:
> > > > >       v4l2_fwnode_endpoint_free(&bus_cfg);
> > > > > @@ -1232,10 +1251,10 @@ static int imx334_init_controls(struct
> > > > > imx334
> > > > *imx334)
> > > > >       imx334->link_freq_ctrl =3D v4l2_ctrl_new_int_menu(ctrl_hdlr=
,
> > > > >                                                       &imx334_ctr=
l_ops,
> > > > >                                                       V4L2_CID_LI=
NK_FREQ,
> > > > > -                                                     ARRAY_SIZE(=
link_freq) -
> > > > > -                                                     1,
> > > > > -                                                     mode->link_=
freq_idx,
> > > > > +
> > > > > + __fls(imx334->menu_skip_mask),
> > > > > +
> > > > > + __ffs(imx334->menu_skip_mask),
> > > > >
> > > > > link_freq);
> > > > > +
> > > > >       if (imx334->link_freq_ctrl)
> > > > >               imx334->link_freq_ctrl->flags |=3D
> > > > > V4L2_CTRL_FLAG_READ_ONLY;
> >
> > --
> > Kind regards,
> >
> > Sakari Ailus