Date:   Mon, 6 Feb 2023 06:40:17 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Xinghui Li <korantwork@gmail.com>
Cc:     peterz@infradead.org, jpoimboe@redhat.com, tglx@linutronix.de,
        stable@vger.kernel.org, linux-kernel@vger.kernel.org,
        x86@kernel.org, alexs@kernel.org
Subject: Re: [bug report]warning about entry_64.S from objtool in v5.4 LTS
Message-ID: <Y+CSwTDESQjTzS8S@kroah.com>
References: <CAEm4hYXr28O8TOmZWEKfp-00Y9R7Ky7C6X3JTtfm-0AD42KbrA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAEm4hYXr28O8TOmZWEKfp-00Y9R7Ky7C6X3JTtfm-0AD42KbrA@mail.gmail.com>
Precedence: bulk

On Mon, Feb 06, 2023 at 11:09:48AM +0800, Xinghui Li wrote:
> Hi all
> We found a warning from objtool:
> arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x1d1:
> unsupported intra-function call
> 
> and if we enable retpoline in config:
> arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0x1c1:
> unsupported intra-function call
> arch/x86/entry/entry_64.o: warning: objtool: If this is a retpoline,
> please patch it in with alternatives and annotate it with
> ANNOTATE_NOSPEC_ALTERNATIVE.
> 
> I found this issue has been introduced since “x86/speculation: Change
> FILL_RETURN_BUFFER to work with objtool( commit 8afd1c7da2)”backported
> in v5.4.217.
> Comparing with the upstream version(commit 089dd8e53):
> There is no “ANNOTATE_INTRA_FUNCTION_CALL” in v5.4 for missing
> dependency patch. When the “ANNOTATE_NOSPEC_ALTERNATIVE” is removed,
> this issue just occurs.
> 
> I tried to backport “ANNOTATE_INTRA_FUNCTION_CALL”and its dependency
> patchs in v5.4, but I met the CFA miss match issue from objtool.
> So, please help check this issue in v5.4 LTS version.

If you rely on the 5.4.y kernel tree, and you need this speculation
fixes and feel this is a real problem, please provide some backported
patches to resolve the problem.

It's been reported many times in the past, but no one seems to actually
want to fix this bad enough to send in a patch :(

Usually people just move to a newer kernel, what is preventing you from
doing that right now?

thanks,

greg k-h