Message-ID: <0b8551a2-1d46-8ac8-5073-5b094507975a@fujitsu.com>
Date:   Mon, 6 Feb 2023 14:45:53 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v9 1/3] xfs: fix the calculation of length and end
To:     Matthew Wilcox <willy@infradead.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
        <nvdimm@lists.linux.dev>, <linux-mm@kvack.org>,
        <linux-fsdevel@vger.kernel.org>, <djwong@kernel.org>,
        <dan.j.williams@intel.com>, <david@fromorbit.com>,
        <hch@infradead.org>, <jane.chu@oracle.com>
References: <1675522718-88-1-git-send-email-ruansy.fnst@fujitsu.com>
 <1675522718-88-2-git-send-email-ruansy.fnst@fujitsu.com>
 <Y9+WHXyA2GufLWpw@casper.infradead.org>
From:   Shiyang Ruan <ruansy.fnst@fujitsu.com>
In-Reply-To: <Y9+WHXyA2GufLWpw@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/2/5 19:42, Matthew Wilcox 写道:
> On Sat, Feb 04, 2023 at 02:58:36PM +0000, Shiyang Ruan wrote:
>> @@ -222,8 +222,8 @@ xfs_dax_notify_failure(
>>   		len -= ddev_start - offset;
>>   		offset = 0;
>>   	}
>> -	if (offset + len > ddev_end)
>> -		len -= ddev_end - offset;
>> +	if (offset + len - 1 > ddev_end)
>> +		len -= offset + len - 1 - ddev_end;
> 
> This _looks_ wrong.  Are you sure it shouldn't be:
> 
> 		len = ddev_end - offset + 1;
> 

It is to make sure the range won't beyond the end of device.

But actually, both of us are rgiht.
   Mine: len -= offset + len - 1 - ddev_end;
      => len = len - (offset + len - 1 - ddev_end);
      => len = len - offset - len + 1 + ddev_end;
      => len = ddev_end - offset + 1;          --> Yours

I forgot to simplify it.  Will fix.


--
Thanks,
Ruan.