Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966519AbXIBM7W (ORCPT ); Sun, 2 Sep 2007 08:59:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965317AbXIBM7P (ORCPT ); Sun, 2 Sep 2007 08:59:15 -0400 Received: from x346.tv-sign.ru ([89.108.83.215]:60892 "EHLO mail.screens.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965449AbXIBM7O (ORCPT ); Sun, 2 Sep 2007 08:59:14 -0400 Date: Sun, 2 Sep 2007 17:02:34 +0400 From: Oleg Nesterov To: Davide Libenzi Cc: Linux Kernel Mailing List , Benjamin Herrenschmidt , Andrew Morton , Linus Torvalds , Michael Kerrisk Subject: Re: [RFC + PATCH] signalfd simplification Message-ID: <20070902130234.GA183@tv-sign.ru> References: <20070902121943.GA141@tv-sign.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070902121943.GA141@tv-sign.ru> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 19 On 09/02, Oleg Nesterov wrote: > > Small problem: unless I missed something, signalfd_deliver() and sys_signalfd() > should use wake_up_all(), not wake_up() which implies nr_exclusive == 1. > > It is possible that we have multiple threads waiting on ->signalfd_wqh with > the the different ->sigmask. In this case, the first woken thread can ignore > the signal, we should wake up all of them. Oops, sorry for noise. I forgot about WQ_FLAG_EXCLUSIVE, we don't set it by default. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/