Date:   Mon, 6 Feb 2023 08:38:47 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Linus Torvalds <torvalds@linux-foundation.org>,
        George Kennedy <george.kennedy@oracle.com>
Cc:     Jiri Slaby <jslaby@suse.cz>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [GIT PULL] TTY/Serial driver fixes for 6.2-rc7
Message-ID: <Y+Cuh3LmsF9PGO6z@kroah.com>
References: <Y9+Yv1CQKNP0Bwqq@kroah.com>
 <CAHk-=whSQFHVzgQ+s8cbCSyE_yrd+BFuYktHe2=0h-nLXBi__Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHk-=whSQFHVzgQ+s8cbCSyE_yrd+BFuYktHe2=0h-nLXBi__Q@mail.gmail.com>
Precedence: bulk

On Sun, Feb 05, 2023 at 12:17:05PM -0800, Linus Torvalds wrote:
> On Sun, Feb 5, 2023 at 3:53 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > George Kennedy (1):
> >       vc_screen: move load of struct vc_data pointer in vcs_read() to avoid UAF
> 
> Hmm.
> 
> I think the "goto unlock_out" should be a "break". A partial read
> should return the partial success, not an error.
> 
> That situation didn't exist when the check was outside the loop, but does now.
> 
> Now, I don't think this matters for any sane situation, but since I
> looked at this patch I thought I'd mention it.

Fair enough, George, can you send a follow-on patch to fix this up?

thanks,

greg k-h