Subject: Re: [PATCH] ASoC: codecs: es8326: Fix DTS properties reading
To:     Alexey Firago <a.firago@yadro.com>, <linux-kernel@vger.kernel.org>
CC:     <alsa-devel@alsa-project.org>, <zhuning0077@gmail.com>,
        <yangxiaohua@everest-semi.com>, <broonie@kernel.org>,
        <tiwai@suse.com>
References: <20230204195106.46539-1-a.firago@yadro.com>
From:   Yang Yingliang <yangyingliang@huawei.com>
Message-ID: <96c99731-a5e9-778d-24f5-cb42a5c2d840@huawei.com>
Date:   Mon, 6 Feb 2023 16:42:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20230204195106.46539-1-a.firago@yadro.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hi,

On 2023/2/5 3:51, Alexey Firago wrote:
> Seems like properties parsing and reading was copy-pasted,
> so "everest,interrupt-src" and "everest,interrupt-clk" are saved into
> the es8326->jack_pol variable. This might lead to wrong settings
> being saved into the reg 57 (ES8326_HP_DET).
>
> Fix this by using proper variables while reading properties.
>
> Signed-off-by: Alexey Firago <a.firago@yadro.com>

Fix tag is needed, it should be 5c439937775d ("ASoC: codecs: add support 
for ES8326")

Reviewed-by: Yang Yingliang <yangyingliang@huawei.com