From:   <Tharunkumar.Pasumarthi@microchip.com>
To:     <gregkh@linuxfoundation.org>, <Kumaravel.Thiagarajan@microchip.com>
CC:     <arnd@arndb.de>, <linux-kernel@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
        <lkp@intel.com>
Subject: RE: [PATCH v3 char-misc-next] misc: microchip: pci1xxxx: Add
 OTP/EEPROM driver for the pci1xxxx switch
Thread-Topic: [PATCH v3 char-misc-next] misc: microchip: pci1xxxx: Add
 OTP/EEPROM driver for the pci1xxxx switch
Thread-Index: AQHZKXdRTqU9jy+mxk+hberHdhxKbq6nKH0AgBqbxPA=
Date:   Mon, 6 Feb 2023 09:20:51 +0000
Message-ID: <PH7PR11MB59587A0639FE44245A68312B9BDA9@PH7PR11MB5958.namprd11.prod.outlook.com>
References: <20230116192908.2980862-1-kumaravel.thiagarajan@microchip.com>
 <Y8pzIgeMyf2oNCn4@kroah.com>
In-Reply-To: <Y8pzIgeMyf2oNCn4@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YXFV+vOYyTz+IpmEpWfgTOtma4VLH4O/ERG7ceXatOsXngW6s4PQVP8QQTyc?=
 =?us-ascii?Q?ZPsFtDuukXnjpVTCQwPrQ5A++hxxXrC8eMbAw4bT6o2RkJ8UGUhisLd5AsET?=
 =?us-ascii?Q?4Z02SFQdZeM6mZrXSD6QsAlbyRgutc6KG/c7hY3/nLkYsO0nnJP1IqfMvWtF?=
 =?us-ascii?Q?pl16sQuvxCIkuVdNGDyov4S7OzVhv+8AW+kh16TYkBsTH/VLGH0PgVq740Fg?=
 =?us-ascii?Q?MLlPsRfvC3dKDXP5BtGPpz7rRNNBziBV4IU/YjTAbNtHYQkyX58dh1iJdzrE?=
 =?us-ascii?Q?jA4l08LB1j0aojKub1wkSla0fdv+rGCVd1opfxoqj7skdfnFIexcMRcGYE7+?=
 =?us-ascii?Q?DbYMdhUIfNQ5ngUUuqCdmMqACo2lpHSg4z/PR5vX9/0EXhemfEPmDw8V6tU6?=
 =?us-ascii?Q?9gmnhZmBvXN1lNUHUwLXhLffNofKa/bUt2yZVef6QyI0zooQvdQPp09sVnjt?=
 =?us-ascii?Q?Ud046a3m7SZcDdvbs0kp/T6gD39f3FU9BpgyOUyb1gtNF0WtdDDMlui2ZAaG?=
 =?us-ascii?Q?V4FeOYFOQwxO7mGmTPL5bhvea5MtnHp/x1FcFSgUqc+HXY9r/AIz5LHkE8Ky?=
 =?us-ascii?Q?Lpjafh2MAjEjL27sWup/qWjYMMTI/e3DME7NmdogYB830bO9ySwU+adwyzsV?=
 =?us-ascii?Q?c7ENPyqfWjKBGKJuym+RiiUd3zoJVezPV6p0M5cVPgnKZMN6lu4aK6WKRZNm?=
 =?us-ascii?Q?4N3ZnhXtmLVgtu2zLDYEqREDypY6a8ThmOSN5oIEaC8S78ROjizeXCnP0Btt?=
 =?us-ascii?Q?0rmpdx88ui04l1KxTRKkjdtoH3ZII7VEtfbbsGQ1zanXpRF+dSw9T1hirgIm?=
 =?us-ascii?Q?HwBCHm0YUlO6KNAmm4cqK1iKWgI9ZUcoIQI7hkJR7lFmar9AvE5CZAsp6WpD?=
 =?us-ascii?Q?Vc+a/oirELKPzWrcN0byMHNL4R+ZwBFWQaGfkU2TD4yK31Gj4M9XhyLVbDtm?=
 =?us-ascii?Q?Vs653EZCmnW2c0Objm94+pVM+qGqY4SvroOSQdBkdiQMBXvLGtXmV6KEN20y?=
 =?us-ascii?Q?HvusKiN0xkUuXhhGk5vkWA/VAY4mQyIWaHIwQv6RMGwLGoD5xHYR5uCrwR/O?=
 =?us-ascii?Q?87qSGabaJ9ZK/364fM3eaTcnsevJSkLkqyAbJSExpugz3qTfdnJvTsMP8sDI?=
 =?us-ascii?Q?HASqGS18E1sQvLjtELWZo/FD25VbCGCPNOZXW5tuzrRZp7Sleyv36WEnrAgT?=
 =?us-ascii?Q?FbkXKjK7jvKBJii+sujxixrHaChZXcsaqK9mmt75+LOOQBbcIiDuTKJc+9Fm?=
 =?us-ascii?Q?PebBqutRmTl9W+3rhjKtjLjIucnpIXxFvzN+aCO4KIPilQPYJF2VvuAp2ELf?=
 =?us-ascii?Q?7Dlmp69T483WE3ew6xo9eUYtK7bT0popK2lKig6hNLkENFS3abmCIHD7qDmM?=
 =?us-ascii?Q?e2lfsnC4DKg3Ncy4BU2i3zNgrzKmvBVr7HQApmL0G5FuFY1hVqB2FyK0FGIN?=
 =?us-ascii?Q?Q8T/V+qIiRAsOLYwb74bIf41lLOA53DWoR76aqw4STjvlk3oknWa2xSo0Bkl?=
 =?us-ascii?Q?cq72HKS7+M58UzW4I/WD5AOv4N0mRRFjCyCFvzhhyZaOgHfH/dKqkDtCEtiy?=
 =?us-ascii?Q?IMPqqQLGwHECuxsqY1CyIY4JZolrmDrzGqqa641nz5G8IM90y/VcU2wTKR0B?=
 =?us-ascii?Q?FeAiggL/AkIK1S4fFxG6asA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5958.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c2f1d97-292b-4482-3dcd-08db082370eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2023 09:20:51.3931
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: amn0+spys4H5ZA8Uk9POEM+boFxSSXwE26yKszuGrgoJigzBG2UvvnoTsxdIuV+0yaas+pjdQEh/P3OkvMJOtfT4+fI2cvGE8nWgJHQvMBdnkuSYR3DAnry/0ExIZBVG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6040
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Friday, January 20, 2023 4:26 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>
> > +             dev_err(&priv->pdev->dev,
> > +                     "EPC_Timeout, EEPROM is unresponsive: %x\n",
> > + data);
>=20
> Can this spam the kernel logs?  If so, please rate limit it.

This print will only come once at max and will not spam logs.

> > +     delay =3D msecs_to_jiffies(OTP_RW_TIMEOUT_MILLISECONDS);
> > +     j0 =3D jiffies;
> > +     j1 =3D j0 + delay;
>=20
> Are you sure this math works out?  Please use the jiffies math functions
> instead so you can handle wrapping properly.

You suggest using any existing APIs to add jiffies to handle wrapping? I am=
 not able=20
to find any such API. Can you please point out API name.=20

Thanks,
Tharun Kumar P