From:   "Katakam, Harini" <harini.katakam@amd.com>
To:     Jonas Suhr Christensen <jsc@umbraculum.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Haoyue Xu <xuhaoyue1@hisilicon.com>,
        huangjunxian <huangjunxian6@hisilicon.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Esben Haabendal <esben@geanix.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net v2 2/2] net: ll_temac: Reset buffer on
 dma_map_single() errors
Thread-Topic: [PATCH net v2 2/2] net: ll_temac: Reset buffer on
 dma_map_single() errors
Thread-Index: AQHZOZ4gD82bQ5NIJEahfbNEw7bub67Brbnw
Date:   Mon, 6 Feb 2023 09:59:39 +0000
Message-ID: <BYAPR12MB4773DD0FE03A6DDE1B1B36D29EDA9@BYAPR12MB4773.namprd12.prod.outlook.com>
References: <20230205201130.11303-1-jsc@umbraculum.org>
 <20230205201130.11303-3-jsc@umbraculum.org>
In-Reply-To: <20230205201130.11303-3-jsc@umbraculum.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OND2A2n1EuZzfJk8L+//snDoEKtUehT6l1Rd/R5j6enEBB9eSslew8/0UvhP?=
 =?us-ascii?Q?whcXh89czHnuUlCYoTt72cctrIgYWS/4FhAc/303UwcP9sBztWuy+mHezgkB?=
 =?us-ascii?Q?kq2YFGj7V9u4AkVY701BsT6dgCh2bmQRlWnsHpNfabPf3mrC9w3iaBkBlaLG?=
 =?us-ascii?Q?xC8Gqzl66+4THRJSJSs2/oHXkS9CP7aSVufcQj/uzY9eB6gYXfDVPbEo2kLY?=
 =?us-ascii?Q?FpBcXf/tFbuFuPvOrAL/qUM5n3GDiC9tSlWZIlYi6114z6iQFuHYJJNfd2sw?=
 =?us-ascii?Q?7toedHcW6SLb/B3GrQrwPwoQczKncIIrcpn0q/EC6ejnIS/LZdd4m88xXXlZ?=
 =?us-ascii?Q?QdHB3/8ErlvW2OTn0M8HUaEFQOVsVT/ksrpT+Iu+Zo5iMrRsGqSbePVEYlH1?=
 =?us-ascii?Q?rNVeG+cyEPng/kHjp33WYAhkwrodgio3Pj4E8tex2+o+JE2Z9qEDlvQSF9Go?=
 =?us-ascii?Q?KjtMsxylGddYSjRxAKvskd5U9FQTLm9tHcfLsJ6A9hbe4DeGXtfnos0dZVU6?=
 =?us-ascii?Q?UdQx/xym+D/Krw6CQfBbea3LCQxNY2vhSfky3qtv8BWoHoN3Qtff5CIqxo6A?=
 =?us-ascii?Q?ccFLv8wipy4L80EJlYbawsIrY+1fZds5SF8fBjsbgdyDA0Y3DVLOblJzzxjO?=
 =?us-ascii?Q?/0x8GwqeZtisG1SJvEMrkPbtgqDWoJBDAXTvdJfqGIEGWtUy2gRRyhgp3S/6?=
 =?us-ascii?Q?ysDMu3LXo+6lYE1kkfhGe2VPfWhBuF8ZW4M2YLRvLMdCYtYk+ETcXm+WDqqE?=
 =?us-ascii?Q?S2onApe0MC7ZZDxwAfNMKv1BH8rgynLYefryunHiM2O1Igs48EZgZi2B3r5b?=
 =?us-ascii?Q?8x6WdgAwjYmResk5fdtiIjq77lJsfXI8yz9VpFhv011udGGR5ELZrwuD4ajN?=
 =?us-ascii?Q?VzgxblOlMllqliF+Ki3YFP+6rvFwT9Aa6reoly/yfs6vtXp5R2cdZWJEhUeQ?=
 =?us-ascii?Q?RIpoXD60JX+7n1HktsJKREfhbqDvex1jDGJJnxf1poPJLf8wifDOyCksrCnr?=
 =?us-ascii?Q?5JSOz6Ggq+7IUAfhBGqE7hHmY5v+Cb1nQ7HZfjJZdTBL05m2VKh1fQqzrDUw?=
 =?us-ascii?Q?SO6IdZTVh+zvtNT2uifR3fktKXerWGHlQ2mKXsCWzg83krkxUL1nTrOUxaVI?=
 =?us-ascii?Q?QtyMy5ZxvLXxTlEM1K/CNW9NU9xFKx6Gj2QSxiSqj+EaAskklP8WCm5sNO4D?=
 =?us-ascii?Q?MAvERJICsKLrvrQXB2kOS1aUxhe9Ysr3o9Qwz74wJEQVnWeazWzGFDitUMMm?=
 =?us-ascii?Q?nIXi54+c1tiQuiFZF2QGdZcWEIXu0X0gd5I4adLaHqFNKku/FfntEH/JL85T?=
 =?us-ascii?Q?Gj5p/BLhG7sUJVFGtC3MisWmqJh8hokPN7sxCvWnNqI2OPzonavO05q39gkT?=
 =?us-ascii?Q?jR3EAcGZbrps8kT00UOcrZOXst7SkQCdnCatUX9PppmFfWIXLiRASKUnEvBN?=
 =?us-ascii?Q?QOjpmeHJDbX1bnwikHv9hSVPk2Gbxk3vxN6SuVN9M46LKUQBplAJuKe3xbbJ?=
 =?us-ascii?Q?JXkhyk3pfCsx89CVJecRzXSh/r5YVKj/mQbi6mvr/HodSIVZ+k9IjUsnkPV/?=
 =?us-ascii?Q?Kua8wDuWPbPiFcbLtLM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4773.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8110370b-e0e6-45a5-d6ff-08db0828dc71
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2023 09:59:39.2750
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HYzG3MeSB1s2xxiqkWt7wweTuPYj3Arpf+pO5r11IIXHLKfJsXXtodm/4H41WHCu
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4261
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jonas,

> -----Original Message-----
> From: Jonas Suhr Christensen <jsc@umbraculum.org>
> Sent: Monday, February 6, 2023 1:41 AM
> To: netdev@vger.kernel.org
> Cc: jsc@umbraculum.org; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Michal Simek
> <michal.simek@xilinx.com>; Katakam, Harini <harini.katakam@amd.com>;
> Haoyue Xu <xuhaoyue1@hisilicon.com>; huangjunxian
> <huangjunxian6@hisilicon.com>; Christophe JAILLET
> <christophe.jaillet@wanadoo.fr>; Yang Yingliang
> <yangyingliang@huawei.com>; Esben Haabendal <esben@geanix.com>;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: [PATCH net v2 2/2] net: ll_temac: Reset buffer on dma_map_single=
()
> errors
>=20
> To avoid later calls to dma_unmap_single() on address'
> that fails to be mapped, free the allocated skb and
> set the pointer of the address to NULL. Eg. when a mapping
> fails temac_dma_bd_release() will try to call dma_unmap_single()
> on that address if the structure is not reset.
>=20
> Fixes: d07c849cd2b9 ("net: ll_temac: Add more error handling of
> dma_map_single() calls")
>=20
> Signed-off-by: Jonas Suhr Christensen <jsc@umbraculum.org>

Thanks for the patch
Reviewed-by: Harini Katakam <harini.katakam@amd.com>

Regards,
Harini