Date:   Mon, 6 Feb 2023 11:04:52 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Bo Liu <liubo03@inspur.com>
Cc:     johannes@sipsolutions.net, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] rfkill: Use sysfs_emit() to instead of
 sprintf()
Message-ID: <Y+DQxN9ybYqfozRr@corigine.com>
References: <20230206081641.3193-1-liubo03@inspur.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230206081641.3193-1-liubo03@inspur.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tetVxN9iIxGleSMmZ7nIiYLq0U8vVqX3uSqH/V6lqK2BK/7GEROTXq+kVefY?=
 =?us-ascii?Q?a+Cc35HU7t3bx2k4XcaMMsDn+dz33mtPAh5kW7NXuy+MOPJtvy86JAqB+sLn?=
 =?us-ascii?Q?IMHLZwHJoeqYEjSjIau5hadWHz9NcS5rrUB3mQMRlGYrjf2+EWzMP2o2ZnoA?=
 =?us-ascii?Q?OfIq3f1uM80Q4ITXC8vqcyALyuTiOiZ8aOklNrpKFQDP9wD64m0aFKp/0El9?=
 =?us-ascii?Q?RjmCw0aSZ3s/orjGSf/AI3fVPUn9LsFudZ/YJSzTEQzkUuxkpzGgSOAmXgI9?=
 =?us-ascii?Q?j7YdPvz81GGf4HQ42NtSplKBUhTMLLGiEYblS8+W387Eri8ENd03PMW978tG?=
 =?us-ascii?Q?9IMsUAyBQ4nJUjgCf6o6bGQU31koa6+Jy53HbtiCVnmJK9MinAUCH7ZFD3gV?=
 =?us-ascii?Q?bJUXvMNfRbdIoDmiHY11XXwnwcjWR7oWG9YsU5D63gYSqYJYZo7m709Khmr6?=
 =?us-ascii?Q?rI2gFKc0oaamIv7nrLI1o/kbou8/+ehuMEMqLYCnwx0n7xD7oOdkj16jWLrE?=
 =?us-ascii?Q?WSX1XTI7LnY18PTGRQu783CLC85bCaEXmh7vxDx/wyZz6aEtZL7QzsU5gx55?=
 =?us-ascii?Q?3vAlZ2ROuRfUttW8ItGcsxTAKMkFTEyDaTAwTY/Re7N3YQd9DGxns/C/u/ED?=
 =?us-ascii?Q?QBLKQiP83+KETyBYRADNdHqSdd0t/YBIhAL9BmezQEVgX4na1EtcEuvLKKwA?=
 =?us-ascii?Q?/ASL+i3xpZ6BAJAco/pq48ZsdEG0VgNzcz3fGADxpqw0CzdDg1BL3WsVscpP?=
 =?us-ascii?Q?H3ZyFQZgHV+3KcRIc2m9bWicMj9dKmfPqWhZql1M1OjBsu2NwQKziKiLJNSZ?=
 =?us-ascii?Q?UM4KULzakbiKmmN6ji1GeJcY5UerHKZ0F+pmJxSglRHiP781PYTxzdHC6W4U?=
 =?us-ascii?Q?8vFl9oA18oIkBCAFzF9CMjRoxNhENiB5nnafly3tjjQbEyiykhI3lJPDvsW1?=
 =?us-ascii?Q?FlRwJC//c8U4uAoJQBoSW7uxhciz+st0XDjSPCagSxaM1hh5hfPPiNDKO7m4?=
 =?us-ascii?Q?+LLe0NMUnkkf83Rpz5jQf7MUmn3h+aIXanlFr3qFMPVU280qcq8u2GWwtnKU?=
 =?us-ascii?Q?TCQZ9zWRII8XcwiRCXU2MgLr3YSb1MN7dVJNnZ6HoSvntuB9eqO9IFoh3LFF?=
 =?us-ascii?Q?WO0xbTPwmFBf07gGf6edKVFs5NhoIW/rOepEjY5jq21eRVC1BM8Yn6IC4WNc?=
 =?us-ascii?Q?RvkAgyHxtSSYZ3tY0SS98Ghad84OFOqyNyyqt5IUvaJ6jq+ypLjW5cVdBURc?=
 =?us-ascii?Q?fYoeoxEd+YykwYzkLBmq60ZJdggTjDPSnLHMD0HQ56J2fpJ2Vph4XTuQW6TN?=
 =?us-ascii?Q?YYZ16HhsM3DLiTLJkeAoVwyWrees/vAZ7XYQGD5aArxJQo004tY/oh/49c22?=
 =?us-ascii?Q?k8PG50XM7eXfI4pdo8YHyKPiFXFJvCwxJifuX1iAUk9FPhiV9bTA4oCVbw9Z?=
 =?us-ascii?Q?EHF3zjw8xP3lHWW3dJpooYlyTee5X1JFbCQnNoZCE4bg8dZJ854dyX9BNXX9?=
 =?us-ascii?Q?mqRmyBXlet/ufpW/+8kSSo8FQZ4o2RGH/keoss4nMRXUnQeAiliJ9WADQgB2?=
 =?us-ascii?Q?Qei9QDvQ20Md0t0zBDoqLbOVbjZsAsVJZwTKgz+oPa+ACzwdrR9yDen3d/Ql?=
 =?us-ascii?Q?5oFAeZYGYW/sqzOxsi8HxutfrLiN3UuYaBSweP3K14ZzKG9C6Nm5cpQhkk3U?=
 =?us-ascii?Q?b95nqQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89c439cb-4356-4b1e-b7ec-08db08299af0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 10:04:59.1093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AOOd/RD1uSQeQeCtsPELsn5J+Zfq2f+xmMBtFu4nkeuCtJxf0OpPCy5rg1vkS2Wcdx5PG47gIwLKUpKh9wJAytC3dVgVGMriGflP4LJ8z2M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3900
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 06, 2023 at 03:16:41AM -0500, Bo Liu wrote:
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: Bo Liu <liubo03@inspur.com>
> ---
>  net/rfkill/core.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Hi Bo Liu,

A brief summary of changes since v1 should go here.

Comparing v1 and v2 manually, I see that you have addressed the minor
issues raised in the review of v1:
* the checkpatch warning regarding ' )'
* Including target tree, net-next, in subject

Ref: https://lore.kernel.org/netdev/Y91bc2LWMl+DsjcW@corigine.com/

So, FWIIW, I am happy with this patch now.

Reviewed-by: Simon Horman <simon.horman@corigine.com>