From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [RFC PATCH net-next 08/11] net: enetc: increment rx_byte_cnt for XDP data path
Date:   Mon,  6 Feb 2023 12:08:34 +0200
Message-Id: <20230206100837.451300-9-vladimir.oltean@nxp.com>
In-Reply-To: <20230206100837.451300-1-vladimir.oltean@nxp.com>
References: <20230206100837.451300-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uziW7g463TYMk/bNb0TDAEJm9xVQoW6+vzbhHKlm/CKSjdEboiFrRUBVRgAH?=
 =?us-ascii?Q?6vjiBtHklID7pxjrIm67dNOMnO4x9FAdzUIaRSwh3sZzYRDHR1gWGQuKfcKm?=
 =?us-ascii?Q?aGySuDqzI08jOT8n3S7g/x5UvMhbcQiKLShvPLhSTuzp2elREvk1rhiAtBiu?=
 =?us-ascii?Q?PAnktOGheU7LMunVusGZINozxTiclA+dhdzVC0ICqi+bQs4rVo6uIq3URUxY?=
 =?us-ascii?Q?4YL7Ykg75zxRlXUuOjLuzhQYXkvO5Fe1vRghOnUyQPvwnv4shv+IdxHQKECg?=
 =?us-ascii?Q?RJWRXmLGX/59RuwvDEARxIwKl090Ci3uG8ArtoWSZ/6rTBAUnSLMSwW84qTH?=
 =?us-ascii?Q?3ld0Tca6zwc6Htn/TrMdxP0pIhZMbqQhepxMbUsQRjRe8CeXxM+taB9cDN95?=
 =?us-ascii?Q?iw+XfsLsMbE47YNogp3d4jw/aM3Re6+90/FheSXf93WtojcLa8llXqeyiIyP?=
 =?us-ascii?Q?JXRv4OaESEI8I8gz7LoO9q9AzDX/gVMPI10CepfXxa4scFgdGgIqSesy/sC4?=
 =?us-ascii?Q?eT78HiOSKwDlVsjTPHK55DjFFzBt90yaBu0g0cU5UYBzciIyJdzwLl9YFRB+?=
 =?us-ascii?Q?UnQRyhCvWb4nZbFuPIjjPabgpW0lGgUQfJme5uxgSN4oLn/BmcgNe8xDs2Bk?=
 =?us-ascii?Q?YbiFkAymCQCAtpaX56X1d0Mdb90LXcEtcx0rXs6uqUJXA/6a+yP4eqR+98XS?=
 =?us-ascii?Q?CLhhMUYTC8IaxFjcPn1fVpKvcJUiD0SSi5z8cCBiWDVy/+r29wpPK08FmFzM?=
 =?us-ascii?Q?JT0G3cHuBadJ8f1MuUong7WxmfHouEnGrq3XXiIgtfwm5RA8YeNMvsebv/P9?=
 =?us-ascii?Q?3rFWspJsaylyXZHN4P0X5GBALjkkSgTgGl2g+w16UBjhwXK7Tauc80fvh30x?=
 =?us-ascii?Q?xdu5kuWARHJ6dU8k50FfHnfC0tRMGYob31rpY0nMwhdH0KgU7DpAwKk65mj/?=
 =?us-ascii?Q?ryuaA3lVOQpsiwkyTMNGG6zLaoQ1Gu+EwDNsWzJzg0zh+mhCXS4CaozSN6Ce?=
 =?us-ascii?Q?zJeF4v0mCiJ70rsn/5A+NNCiX/9wWSlblHMkB7t8MBEji07Bu5D0V0YNvYhV?=
 =?us-ascii?Q?s0dZ3LOSLYs82Ec/5An6+cj1Crnyi+ImYpTBxLEmB/P5PUfAEipzMcV3T3UC?=
 =?us-ascii?Q?UZOWStglkCFj7biqnRp17ileoYL1SAz6vg87GSI05FhBBKkszN7QhCZJB+4D?=
 =?us-ascii?Q?5xeBUJqrwRM3RbmdFUfMGXmCrdmLunEply1FDqzJ4H43H/keyujwE7dtOr7i?=
 =?us-ascii?Q?14Ewd2Oz7RdSMNiWNaaxAjTvlJPwlVgO/tOTWj8sc0spo625WR0EH2unwMtj?=
 =?us-ascii?Q?FFg2KjiB4BS6aiuX1QEFhxJhB4lO7zi/3qfoN3UV6IKQJzpfx49/2oSGee0X?=
 =?us-ascii?Q?lptHXGXBYuy33g4OJoNJR74YOi3wGhBUpqDmpPILGcd9cftZxgtmcsevGZDw?=
 =?us-ascii?Q?rTfpS4whG6cILvdk9WLEVVW68j6S6/XMViHdXk4r8AeWjRcuJ24qB6ImHKen?=
 =?us-ascii?Q?KsKU23iEy0SD1Tl7Mz42eLhH9ifoqlHwZfEraFufnTYbaqO7vpvLBHlRcQqB?=
 =?us-ascii?Q?submiwj5jdljg6mjP+DtiYtHi6ben/xPiCvsfScSNxIslXFcwPkpj+FvxTtQ?=
 =?us-ascii?Q?pA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af5c78fa-d000-4a21-9c92-08db082a30cd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 10:09:10.5518
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /wBWapCzUu+UfS/NPDKOAko4UyOd67Vjcl+Jx3XHhAN3QZSlK8zM5aM0UcspF0os1TwJsy9BSLtV5mpz7PTDlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7735
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

v->rx_ring.stats.bytes is apparently only used for interrupt coalescing,
not for printing to ethtool -S. I am unable to find a functional problem
caused by the lack of updating this counter, but it is updated from the
stack NAPI poll routine, so update it from the XDP one too.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/freescale/enetc/enetc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index fe6a3a531a0a..e4552acf762c 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -1461,7 +1461,8 @@ static void enetc_add_rx_buff_to_xdp(struct enetc_bdr *rx_ring, int i,
 
 static void enetc_build_xdp_buff(struct enetc_bdr *rx_ring, u32 bd_status,
 				 union enetc_rx_bd **rxbd, int *i,
-				 int *buffs_missing, struct xdp_buff *xdp_buff)
+				 int *buffs_missing, struct xdp_buff *xdp_buff,
+				 int *rx_byte_cnt)
 {
 	u16 size = le16_to_cpu((*rxbd)->r.buf_len);
 
@@ -1469,6 +1470,7 @@ static void enetc_build_xdp_buff(struct enetc_bdr *rx_ring, u32 bd_status,
 
 	enetc_map_rx_buff_to_xdp(rx_ring, *i, xdp_buff, size);
 	(*buffs_missing)++;
+	(*rx_byte_cnt) += size;
 	enetc_rxbd_next(rx_ring, rxbd, i);
 
 	/* not last BD in frame? */
@@ -1483,6 +1485,7 @@ static void enetc_build_xdp_buff(struct enetc_bdr *rx_ring, u32 bd_status,
 
 		enetc_add_rx_buff_to_xdp(rx_ring, *i, size, xdp_buff);
 		(*buffs_missing)++;
+		(*rx_byte_cnt) += size;
 		enetc_rxbd_next(rx_ring, rxbd, i);
 	}
 }
@@ -1571,7 +1574,7 @@ static int enetc_clean_rx_ring_xdp(struct enetc_bdr *rx_ring,
 		orig_i = i;
 
 		enetc_build_xdp_buff(rx_ring, bd_status, &rxbd, &i,
-				     &buffs_missing, &xdp_buff);
+				     &buffs_missing, &xdp_buff, &rx_byte_cnt);
 
 		xdp_act = bpf_prog_run_xdp(prog, &xdp_buff);
 
-- 
2.34.1