Date:   Mon, 6 Feb 2023 11:18:23 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Daniel.Machon@microchip.com
Cc:     netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, Lars.Povlsen@microchip.com,
        Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com,
        joe@perches.com, richardcochran@gmail.com, casper.casan@gmail.com,
        Horatiu.Vultur@microchip.com, shangxiaojing@huawei.com,
        rmk+kernel@armlinux.org.uk, nhuck@google.com, error27@gmail.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 03/10] net: microchip: sparx5: add support for
 Service Dual Leacky Buckets
Message-ID: <Y+DT78lbinHKcxvb@corigine.com>
References: <20230202104355.1612823-1-daniel.machon@microchip.com>
 <20230202104355.1612823-4-daniel.machon@microchip.com>
 <Y95VRJWV4NfSDYUR@corigine.com>
 <Y+ANVTMT7jgV0i0l@DEN-LT-70577>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+ANVTMT7jgV0i0l@DEN-LT-70577>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CeIggitKQVOdLLvvbZwRSQiiKStt4QmZR8btJZ58kg3iZO+FoohR9Mn0+Gmo?=
 =?us-ascii?Q?ARJgnjkYQkQJ2Fr1w2VwRmgHUWGewxr7JOeShKOJSWlZ4oehEXwQMWYvCk/5?=
 =?us-ascii?Q?mI/0ZaV9IUQGq20jfE/HL1kC6NWjjFUEzFGAa5v4gnDjvdn5y6KZxRCtivGR?=
 =?us-ascii?Q?3RsaFLCaX672TEaspx4hvOMrXG+Q2bN2+LQ3nhoOwYpk1pHBi59M1FlpO8V7?=
 =?us-ascii?Q?KR+Tw1xQ2W0Yiy8U/fOc81CIfDym5Ogr/TxkBz4rurDXTiHDmrwqajYciqO9?=
 =?us-ascii?Q?8CvGA3dEgrSFYOOUfp4xE9Vwn4AXipQQBJaoEu23NpgrsgMLHUk8Xy41kjLQ?=
 =?us-ascii?Q?Q5KUqWeITr5n9GEbRpmfgZezXGdh9cg4X5puIaJ2Dp28LPT+C5dVlyD5cgjG?=
 =?us-ascii?Q?dmjgLdz97k0dJrWTKVzOnDQpAGhRayxau5xuxbqs3X/Z050VuCYBu60IlZOQ?=
 =?us-ascii?Q?vMN3c3s03cFcPazrnNFZEBOa9WKbpqjx82MS0/M3pFpf6Dg8nPib6uVKX2IV?=
 =?us-ascii?Q?pTP49IqIsdD5dNCoZAG0bFtUG1e9yXWFO+BosI3EDFBwtmxkCU8i4F77+aGc?=
 =?us-ascii?Q?Xg77NuksgWQJ5n1Y3DgBLVEJPUE19RWZEr9EEur8mW04STnpJG9bfTQ6XTxZ?=
 =?us-ascii?Q?NnrSkM0I7FncgKiiP4pyqTZng9FnriCn0NlQ1lJMG9nOGqL17V1kBUITYslC?=
 =?us-ascii?Q?oP1eAAOmhaaIY3taWNYUsDmOmCVukR5dsRtbgQ+WgpmPgX60QQhNy5hX9TjQ?=
 =?us-ascii?Q?+AamlSgn5sJWCrtGvWfScfHbpx5mcXHNU9Rlk00bD3pffgpbs3mUB3JzN8fI?=
 =?us-ascii?Q?d5pqjgQOWfIlJJHw4bnkWipTsP4IXVmHJlPPJ1cjpJH1QJWdIjirE2o6BJpz?=
 =?us-ascii?Q?s7R2GvBW1lF4tCOjlBbXDfLUailaByh9H2o9NAODb8i717eg8FF9L0LSkdH8?=
 =?us-ascii?Q?wttglI0daIqUXvG6Uob16Sr42LpLmhLLFnu9z5iutCFHS+easgAOWcIstp0a?=
 =?us-ascii?Q?2+/w4oXBDchY5fRe/pvvKjwZiQ7YhAhxaTbhN2tyh8ILbkBjwNwBSHg1zWvM?=
 =?us-ascii?Q?FogObXJ6t6hOYkK375q+qPSM+E3MIpbagfYXr6xTk58xp44CZu11U0WBoSsI?=
 =?us-ascii?Q?XZA579xLIM6gUI0uYV0gWU+TCkjFesh2krb6fxK8YQE/iqbEWkBbf4Gecn6s?=
 =?us-ascii?Q?R31xD+La1jk9jZgyChLXVSNRynflu+tpl44dR0xIJh/pmDlMlMGDEl1W/hNO?=
 =?us-ascii?Q?IF3V4QGfU9VVCKGALwYBG3sS+gVgBuNe8IW6HdZPECfCph/hHj97ueAkaCQ3?=
 =?us-ascii?Q?aeW/hthhT+qmeooLx0bR6F/BC4fcbcZ+AevYxj53MI96PbdsC8vPmGahAIzI?=
 =?us-ascii?Q?nS+YT7Fn9ohb525LFtixmaXqMxAZwrTYGPU3CDcq2soiE5DR2uKR7ZR01Xnq?=
 =?us-ascii?Q?6tXXNIqw+qxlmguzAPVdqfHd5bNJuNbslWrpV+lFBBxeVs2fGBNYu7r2PHdc?=
 =?us-ascii?Q?xxHxY2WwasMiKFsbMUrF9ncgXcnC9IgsGyZSKCyGQoBMcj2xamf06mc109Tu?=
 =?us-ascii?Q?6AJ2v0LZbQxJXrij702wBWLxJslXgTnCgevh+Nyt1disKDm9s5EhEca2/CkQ?=
 =?us-ascii?Q?mUVhgw40Qpxq+WOSWM3mUXBZJ87bTMZdgVokzoyeu5Qme1Sor+oIgVgSxTCN?=
 =?us-ascii?Q?I7SB4Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c19e344f-0aa4-405f-de2a-08db082b7ec7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 10:18:30.9669
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oglx6gtkWQaOJ9dhRjacCxzNls3PRWMs/TiVnWlMBrwffS6haG9UVO+Ey1/hNqYRd/2ijCnCi716mTW0TH16vZKQSoLeu41PcOa2CDQmcdM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3800
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Feb 05, 2023 at 08:11:02PM +0000, Daniel.Machon@microchip.com wrote:
> Hi Simon,
> 
> Thanks for reviewing my patches, appreciate it!
> 
> > > +static u32 sparx5_sdlb_group_get_last(struct sparx5 *sparx5, u32 group)
> > > +{
> > > +     u32 itr, next;
> > > +
> > > +     itr = sparx5_sdlb_group_get_first(sparx5, group);
> > > +
> > > +     for (;;) {
> > 
> > Unbounded loops like this give me some apprehension.
> > Will they always terminate?
> 
> Yes, it will always terminate - unless the add() del() functions are
> buggy to begin with.
> 
> The end of the leak chain is marked by an index pointing to itself, and
> this is the exit condition I am looking for in the unbounded loop.

Thanks for confirming, much appreciated.