From:   "Katakam, Harini" <harini.katakam@amd.com>
To:     Jonas Suhr Christensen <jsc@umbraculum.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Haoyue Xu <xuhaoyue1@hisilicon.com>,
        huangjunxian <huangjunxian6@hisilicon.com>,
        Wang Qing <wangqing@vivo.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Esben Haabendal <esben@geanix.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak
Thread-Topic: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak
Thread-Index: AQHZOZ4bIaLXD56kTU6BDUgiXUw8vK7BtXBw
Date:   Mon, 6 Feb 2023 10:19:26 +0000
Message-ID: <BYAPR12MB477319ABC35AF5A73B5D5D0B9EDA9@BYAPR12MB4773.namprd12.prod.outlook.com>
References: <20230205201130.11303-1-jsc@umbraculum.org>
 <20230205201130.11303-2-jsc@umbraculum.org>
In-Reply-To: <20230205201130.11303-2-jsc@umbraculum.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ilrGgngpzzIZiD/wrT93BIc2JoP6w5aSAbVwO8tBfvEBVnd5Ym7pNqNMdOaq?=
 =?us-ascii?Q?4t8vL2DyJMSWUW0NUzTk6Re170NGCTRs13nBYhmYtEB5I8fAAC9+9Roho9JW?=
 =?us-ascii?Q?X23C8WIyRFlOJ7nb4F7zfEwjqqV4ieONB59QracCZmAlTUahU0gcYADloTZ3?=
 =?us-ascii?Q?ckz5s8IAIGTIJepicTcfOwr3nWNBEuN4SCKD1iRNPUlIKNszFdSbfjQmUb4n?=
 =?us-ascii?Q?sfJQcuRTDutQLDE6YJro0DoWqglS8FfZpNneWXWhfnQTJtyD88ZjbrAg5l67?=
 =?us-ascii?Q?Iq1Gm0G/iX6HuLl1GWRZaLvkpPV4Zt4uqRimusu7xkpoCqu4X6+6kWOPFmNN?=
 =?us-ascii?Q?0coazr38YHCXBjap/3ZjBtPWD+Tw2zaie4OQLh7UXVOQrz/RZfgvdjmR3rhb?=
 =?us-ascii?Q?9qSGgIJZwUhgNCGax96Dtp5dTUtsiAs9tfghR20aUIvcMnqANWiSmx13s3Zq?=
 =?us-ascii?Q?8eigcMdKorFM18HVKap9sP3xoPz0BzjivbYQjybCWaqRmC1bhCFSJyPO6sIO?=
 =?us-ascii?Q?rUKsTV7mac6/+Y9Clh4ylrhMfLmqoL2gyn2rjruoIYSzHEv21I7Q383w1Lvf?=
 =?us-ascii?Q?YhbN57EXR/1HhLcAJEcYBN8IyxUrDNkNcDY4li9IgspHlyDvTOchL3mgZvTH?=
 =?us-ascii?Q?75/m7LGiInk8bjFqFWkiaxR7UxS65xrwvPJiaB9uT4zCEpgIKepif5PMJNqk?=
 =?us-ascii?Q?ZYc53Sp9/46XUKtZ8z4B0jhDmOdlWtRaN4DxJCzCzPIY+JlZY4wmcbuhR5tP?=
 =?us-ascii?Q?dkChoaWcVIhYIZFihBcYldmFdqf23BPIicyGMmlZ1myVL/h90fNXhCsiGZ5x?=
 =?us-ascii?Q?GBKxyg2M35rDdHtMzLLhNX87aMaUGHUWAARxinRXUeu3OmJaRTsCKKeMlARs?=
 =?us-ascii?Q?ZoFkIyHAlUKW1aLqkipJro+8+0/hFuYILUWWpZhnSsiAoUBYTSWKO3Iu/8Qe?=
 =?us-ascii?Q?3p2xUO34LiQ/GoSIT3l0Rz6VIRLms6Yt0F7fSOoulFV3mIRhpTEOjsQ8JrdW?=
 =?us-ascii?Q?rSdbeYjRbYdan7FgNq4H7gTGWncvVKxXCdKVZHMEE3cORMMPFXmlKfiRWlo9?=
 =?us-ascii?Q?wS1EtTp8ZImPbGwucYlTlQUFDonSMmFoVWlk0Z98IeIh7B7WaEdDSy+HC/3s?=
 =?us-ascii?Q?LoEImgj4kObH8UGW8oy2e0H1w0uLFN5vxEnh7ywONu81fquh3b5Sb2VnmlFV?=
 =?us-ascii?Q?cWuN51FgQudMZOMyszo//jYLTyMhloPDZMvr+sJOsTJHkssBmUAAx/nfEi81?=
 =?us-ascii?Q?2y69IT4bZfq8saWdCEP+3e7yDDSdOwp8fkuqc4PnJFgBQKI8TvwZ9c3M7t6Z?=
 =?us-ascii?Q?HYxTaai+y3dvL/qTujiOfxAB3Bm/nZrk8OgDsjWUyRWXFuqQts7Z04FmKcBI?=
 =?us-ascii?Q?H/BCvgTWAeI7IDYhJ6AX2xQP6rb6ECJTqomPEOrojhlyQKEeDoYTAz+PtSUj?=
 =?us-ascii?Q?9wOqeL3MC+uGZC7Qd/FO6TY3uu+TQl6sgTE/lLD4doKgaACz2Zd6o+Jl9AMq?=
 =?us-ascii?Q?Bgsdec6kA/qV7Nl6DFkfk1PmuGbJTatCKsoZjLIpU7XDCg9CsNtdQSUipISJ?=
 =?us-ascii?Q?fj9Xa+8rg7Fhiq1hoKo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4773.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54ce492d-6558-4074-5dc8-08db082ba018
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2023 10:19:26.5155
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jzTjH7jGQD9RloKMCF/IomLFjBmRprHuJFMVABruDvi3x+2ZBhDjPi0QvEaUqGoK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4462
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jonas Suhr Christensen <jsc@umbraculum.org>
> Sent: Monday, February 6, 2023 1:41 AM
> To: netdev@vger.kernel.org
> Cc: jsc@umbraculum.org; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; Michal Simek
> <michal.simek@xilinx.com>; Katakam, Harini <harini.katakam@amd.com>;
> Haoyue Xu <xuhaoyue1@hisilicon.com>; huangjunxian
> <huangjunxian6@hisilicon.com>; Wang Qing <wangqing@vivo.com>; Yang
> Yingliang <yangyingliang@huawei.com>; Esben Haabendal
> <esben@geanix.com>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak
>=20
> Add missing conversion of address when unmapping dma region causing
> unmapping to silently fail. At some point resulting in buffer
> overrun eg. when releasing device.
>=20
> Fixes: fdd7454ecb29 ("net: ll_temac: Fix support for little-endian platfo=
rms")
>=20
> Signed-off-by: Jonas Suhr Christensen <jsc@umbraculum.org>

Thanks for the patch.
Reviewed-by: Harini Katakam <harini.katakam@amd.com>

Regards,
Harini