Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD26C61DA4 for ; Mon, 6 Feb 2023 10:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230364AbjBFK0X (ORCPT ); Mon, 6 Feb 2023 05:26:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbjBFK0V (ORCPT ); Mon, 6 Feb 2023 05:26:21 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DBE2974F; Mon, 6 Feb 2023 02:26:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 03FB960DFE; Mon, 6 Feb 2023 10:26:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E23C7C433D2; Mon, 6 Feb 2023 10:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675679179; bh=hofFteh/cFa0t9JuQJU5c688q+YXS0ej76e1fu9jJZA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ixuvhrmy+LdVwCf/jTRpAOixnwIarEcv8DYZ6QTNtSD4ccuKuNj23jRmAvtZ1s3K6 L9UpxxgSi3rYhEA6c/JOyuZ33zJW6WY/0bGbNos7uyaPmJX+ra0aL//q/7SwUD06ZQ 5FCbQb+ejFXO3T0lVEAHdma9os5a+UlrAxnHz56M= Date: Mon, 6 Feb 2023 11:26:16 +0100 From: Greg KH To: Zhou Furong Cc: Martin =?utf-8?B?WmHFpW92acSN?= , linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, martin.petersen@oracle.com, beanhuo@micron.com, arnd@arndb.de, avri.altman@wdc.com, iwona.winiarska@intel.com, fmdefrancesco@gmail.com, dipenp@nvidia.com, ogabbay@kernel.org, bvanassche@acm.org, mathieu.poirier@linaro.org, yangyicong@hisilicon.com, dan.j.williams@intel.com, devicetree@vger.kernel.org, linus.walleij@linaro.org Subject: Re: [PATCHv2 2/4] wiegand: add Wiegand bus driver Message-ID: References: <20230202143305.21789-1-m.zatovic1@gmail.com> <20230202143305.21789-3-m.zatovic1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 06, 2023 at 05:49:44PM +0800, Zhou Furong wrote: > > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > please order headers Why? What order? For what gain?