Date:   Mon, 6 Feb 2023 11:32:52 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next] net: lan966x: Add support for TC flower filter
 statistics
Message-ID: <20230206103252.xxqd5zvhvfdium4a@soft-dev3-1>
References: <20230203135349.547933-1-horatiu.vultur@microchip.com>
 <Y96R+oEaZijtdaFH@corigine.com>
 <20230206095227.25jh3cpix5k55qv3@soft-dev3-1>
 <Y+DPbbqPyskMBsSJ@corigine.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <Y+DPbbqPyskMBsSJ@corigine.com>
Precedence: bulk

The 02/06/2023 10:59, Simon Horman wrote:
> 
> > > Also, not strictly related, but could you consider, as a favour to
> > > reviewers, fixing the driver so that the following doesn't fail:
> > >
> > > $ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > >   DESCEND objtool
> > >   CALL    scripts/checksyscalls.sh
> > >   CC      drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > > In file included from drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c:3:
> > > drivers/net/ethernet/microchip/lan966x/lan966x_main.h:18:10: fatal error: vcap_api.h: No such file or directory
> > >    18 | #include <vcap_api.h>
> > >       |          ^~~~~~~~~~~~
> > > compilation terminated.
> >
> > I will try to have a look at this.
> 
> Thanks, much appreciated.

Sorry for coming back to this, but it seems that I can't reproduce the
issue:

$ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  CC      drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o

I have tried different configurations without any luck. Any suggestion
on how to reproduce the issue?

-- 
/Horatiu