Date:   Mon, 6 Feb 2023 11:42:03 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next] net: lan966x: Add support for TC flower filter
 statistics
Message-ID: <Y+DZe7uglZqNWu+b@corigine.com>
References: <20230203135349.547933-1-horatiu.vultur@microchip.com>
 <Y96R+oEaZijtdaFH@corigine.com>
 <20230206095227.25jh3cpix5k55qv3@soft-dev3-1>
 <Y+DPbbqPyskMBsSJ@corigine.com>
 <20230206103252.xxqd5zvhvfdium4a@soft-dev3-1>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230206103252.xxqd5zvhvfdium4a@soft-dev3-1>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8aZ9ASGph/uydqarK0csXtDmg3ArutylR7Z+z1P0lC9wp2DQCPT2Wi2iRvG4?=
 =?us-ascii?Q?yogQNatmrc+VqjxrIPeAqPG1udyHm2g6zgjP+C7phffh1GP3khn05M52ubIQ?=
 =?us-ascii?Q?FdILy4AEzBerUHg9DZmOHiTpEnaJQ9cwpmZxHeWpHZm8nsWuLZ2vaQsytlen?=
 =?us-ascii?Q?e9c+CIZkCgvCfeWEdqJT1G78/agYW7wqPRZ6sQLZo4eYzQZPJrcVdgUX+9aS?=
 =?us-ascii?Q?PXbvOpbleObVvHekw+HL6AniByKvTpi+TUXXyqUEoGCu0vigOAiAA/gfWiQY?=
 =?us-ascii?Q?Q5lLx/bn/oiNKxEHk9fKs3P2FEs4Aa0+jRBNRgHJO44Qpw68IXWqA0VQe7F8?=
 =?us-ascii?Q?Ev7KIfiVD0QRfVY0uQac4Flr5DfrYkygUNn85f7Mu1vpxirvTwm2yBm7rKnE?=
 =?us-ascii?Q?/eyatyx00o4Ee+CG/7XPM8eiXJavy3bKMaMvPYYZnmx351CFKCj81wyWo2Pt?=
 =?us-ascii?Q?/VmzBvghDdYUaverWV60Om0yS5m3uBDCjd/sKziyKu7tbfHgoM4blbEmJpOm?=
 =?us-ascii?Q?wpM2WYjm322Asn14X6mTx4pYRKXRXcV5IujwLG3wzJPDLNHodhbgAssrOaAF?=
 =?us-ascii?Q?l1Mwq+dKBAD7Y6mUv2Cw16iyv/pGNXiq2p+QJKz93mHStsdoO8ntNGfOTUbj?=
 =?us-ascii?Q?4VekVvtGrNNEdKLcZJkRFCO1IVFoZRiPsVqDT7bj9ZiymzEjzlZlbadYV7Rt?=
 =?us-ascii?Q?fNHn6A+Rx5l4Y0cRUqoD/puCtzifRL6tsyB6K6PPl5bLYnjl5KxycNypsin9?=
 =?us-ascii?Q?lC+CI8jIsFiGxVUYrAO76sheQbjNgXnOPYASz5MGEmzIZ3+Gx3zPp0Ag1dn9?=
 =?us-ascii?Q?ScBOS6SFQsBU9IBan/lEbd5XebgbxcM88/TzjPi2fOYkUmJRC2nTiCeywKKO?=
 =?us-ascii?Q?HAiZ42iNHAtwqcuPgSSivKNC6RLbF1pHjxIL711Rp3W8ILWNKlJpscJJWtwi?=
 =?us-ascii?Q?E2rFh4ioGL1bqFHzy6EwTAba51zpEu3j2VtbnurXp9CLcse9KZDhSCrfeGIJ?=
 =?us-ascii?Q?Hv1axB74FdV1ss9DMrY9aTX9UzaMN8DjwyTKNKW+aqjIfdbmOHh6Wbzt/qZ9?=
 =?us-ascii?Q?rNvmPuRiwtkAql29S2r2st33EX3yKvZIZnXGCxc45Ssc6rITyBykzNKR/WrZ?=
 =?us-ascii?Q?PEMzEguqrKW+JZD2pRq+s06gq8hk2OcCEukEMgNI7rXpS7wDWGwLw6TcWASX?=
 =?us-ascii?Q?3d156ZVQZc1h0u8rOAMBCE4K/ebmPlLY/O3/yTBzh/aOscf1cz3irOWJ8NpW?=
 =?us-ascii?Q?bS876Ai6k7e3Tff3as+6OaRrR5TXz42T6pHf3I7P7DrD8/hY6rFKslrGwdHj?=
 =?us-ascii?Q?8JX1MIv9mbtSwL//+TVaqyPf9k6AGbZWtZAMFUguPUhXvAsEpJsBuHDy801Q?=
 =?us-ascii?Q?G9EpcTu5stnRyW9V4WL/wOOR44/IFR0oYdLii7wYx3OH1n4jhOkukxVsIr3d?=
 =?us-ascii?Q?MaIB1qwpJRFwXqdTd3aTub7V4Ie846aLP+kPPxEBjiBCo2wGq7MtgWizuyMs?=
 =?us-ascii?Q?a9OZ9KUouz5nEHcXdxnenOIISaIo2LcrhmDnHd450VJ3bMgoGF3+Sw+9ClXb?=
 =?us-ascii?Q?9mP8K34QQTTEwb8kZ2GithVXsSxJUGk7ihSpGKCePNwd4A9i5qmz9XodRMZM?=
 =?us-ascii?Q?uOKu8yw0RZG7D2LRRdWCrEgtrA/Rbcwqxh9wdkW+0QFPk80mCSUzH5EhfE+D?=
 =?us-ascii?Q?HZGQTQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d5e276e-33af-4279-5fa9-08db082ecca8
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2023 10:42:09.9879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iI5U7Lo1FQSAV6Fo2p5ljpW1ZIj/q+ePBfw8XGOGn415D735Lvrt61KxSRXnVisWoJqLJtz/CfCzHftq88JA0xCk1lomPznkBJbHMJiXUew=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB4830
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 06, 2023 at 11:32:52AM +0100, Horatiu Vultur wrote:
> The 02/06/2023 10:59, Simon Horman wrote:
> > 
> > > > Also, not strictly related, but could you consider, as a favour to
> > > > reviewers, fixing the driver so that the following doesn't fail:
> > > >
> > > > $ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > > >   DESCEND objtool
> > > >   CALL    scripts/checksyscalls.sh
> > > >   CC      drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> > > > In file included from drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c:3:
> > > > drivers/net/ethernet/microchip/lan966x/lan966x_main.h:18:10: fatal error: vcap_api.h: No such file or directory
> > > >    18 | #include <vcap_api.h>
> > > >       |          ^~~~~~~~~~~~
> > > > compilation terminated.
> > >
> > > I will try to have a look at this.
> > 
> > Thanks, much appreciated.
> 
> Sorry for coming back to this, but it seems that I can't reproduce the
> issue:
> 
> $ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
>   CALL    scripts/checksyscalls.sh
>   DESCEND objtool
>   CC      drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o
> 
> I have tried different configurations without any luck. Any suggestion
> on how to reproduce the issue?

Sorry, perhaps it is something on my side.

I tried running through the steps below, which is what I assume
I had done last time, but I don't see the problem any more.

I'll let you know if it shows up again.
But in the meantime sorry for the false reporting.

$ git checkout net-next/main
$ make allmodconfig
$ make prepare
$ make drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.o