Message-ID: <b1809500e4d55564a1084a3014fb9603ba3d1438.camel@xry111.site>
Subject: Re: [PATCH] LoongArch: Make -mstrict-align be configurable
From:   Xi Ruoyao <xry111@xry111.site>
To:     Jianmin Lv <lvjianmin@loongson.cn>,
        WANG Xuerui <kernel@xen0n.name>,
        Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Huacai Chen <chenhuacai@kernel.org>
Cc:     loongarch@lists.linux.dev, linux-arch@vger.kernel.org,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Guo Ren <guoren@kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        linux-kernel@vger.kernel.org
Date:   Mon, 06 Feb 2023 19:18:47 +0800
In-Reply-To: <5303aeda-5c66-ede6-b3ac-7d8ebd73ec70@loongson.cn>
References: <20230202084238.2408516-1-chenhuacai@loongson.cn>
         <5fc85453-1e2c-1f00-7879-1b5fa318c78a@xen0n.name>
         <5303aeda-5c66-ede6-b3ac-7d8ebd73ec70@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-02-06 at 18:24 +0800, Jianmin Lv wrote:
> Hi, Xuerui
>=20
> I think the kernels produced with and without -mstrict-align have mainly=
=20
> following differences:
> - Diffirent size. I build two kernls (vmlinux), size of kernel with=20
> -mstrict-align is 26533376 bytes and size of kernel without=20
> -mstrict-align is 26123280 bytes.
> - Diffirent performance. For example, in kernel function jhash(), the=20
> assemble code slices with and without -mstrict-align are following:

But there are still questions remaining:

(1) Is the difference contributed by a bad code generation of GCC?  If
true, it's better to improve GCC before someone starts to build a distro
for LA264 as it would benefit the user space as well.

(2) Is there some "big bad unaligned access loop" on a hot spot in the
kernel code?  If true, it may be better to just refactor the C code
because doing so will benefit all ports, not only LoongArch.  Otherwise,
it may be unworthy to optimize for some cold paths.

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University