Date:   Mon, 6 Feb 2023 13:02:31 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     linux-kernel@vger.kernel.org, Michael Walle <michael@walle.cc>
Subject: Re: [RESEND PATCH 23/37] nvmem: layouts: add sl28vpd layout
Message-ID: <Y+DsV3C1M0c/IZta@kroah.com>
References: <20230206102759.669838-1-srinivas.kandagatla@linaro.org>
 <20230206102759.669838-24-srinivas.kandagatla@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230206102759.669838-24-srinivas.kandagatla@linaro.org>
Precedence: bulk

On Mon, Feb 06, 2023 at 10:27:45AM +0000, Srinivas Kandagatla wrote:
> From: Michael Walle <michael@walle.cc>
> 
> This layout applies to the VPD of the Kontron sl28 boards. The VPD only
> contains a base MAC address. Therefore, we have to add an individual
> offset to it. This is done by taking the second argument of the nvmem
> phandle into account. Also this let us checking the VPD version and the
> checksum.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/nvmem/layouts/Kconfig   |   9 ++
>  drivers/nvmem/layouts/Makefile  |   2 +
>  drivers/nvmem/layouts/sl28vpd.c | 153 ++++++++++++++++++++++++++++++++
>  3 files changed, 164 insertions(+)
>  create mode 100644 drivers/nvmem/layouts/sl28vpd.c
> 
> diff --git a/drivers/nvmem/layouts/Kconfig b/drivers/nvmem/layouts/Kconfig
> index 9ad3911d1605..75082f6b471d 100644
> --- a/drivers/nvmem/layouts/Kconfig
> +++ b/drivers/nvmem/layouts/Kconfig
> @@ -2,4 +2,13 @@
>  
>  menu "Layout Types"
>  
> +config NVMEM_LAYOUT_SL28_VPD
> +	bool "Kontron sl28 VPD layout support"
> +	select CRC8
> +	help
> +	  Say Y here if you want to support the VPD layout of the Kontron
> +	  SMARC-sAL28 boards.
> +
> +	  If unsure, say N.

Why are we going back to "custom-built" kernel configurations?  Why can
this not be a loadable module?  Distros are now forced to enable these
layout and all kernels will have this dead code in the tree without any
choice in the matter?

That's not ok, these need to be auto-loaded based on the hardware
representation like any other kernel module.  You can't force them to be
always present, sorry.

So I'm not going to take this series, sorry.  Srinivas, can you
regenerate it without the layout code and resend?

thanks,

greg k-h