Date:   Mon, 6 Feb 2023 13:39:48 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     linux-kernel@vger.kernel.org,
        =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Michael Walle <michael@walle.cc>
Subject: Re: [RESEND PATCH 30/37] nvmem: core: fix
 nvmem_layout_get_match_data()
Message-ID: <Y+D1FN0rXwCPJtBz@kroah.com>
References: <20230206102759.669838-1-srinivas.kandagatla@linaro.org>
 <20230206102759.669838-31-srinivas.kandagatla@linaro.org>
 <Y+Dst2V9mfJbVrzD@kroah.com>
 <b16d137b-56ee-5aa2-346d-8ab02d590bf8@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b16d137b-56ee-5aa2-346d-8ab02d590bf8@linaro.org>
Precedence: bulk

On Mon, Feb 06, 2023 at 12:08:09PM +0000, Srinivas Kandagatla wrote:
> 
> 
> On 06/02/2023 12:04, Greg KH wrote:
> > On Mon, Feb 06, 2023 at 10:27:52AM +0000, Srinivas Kandagatla wrote:
> > > From: Rafał Miłecki <rafal@milecki.pl>
> > > 
> > > This function was trying to match wrong OF node (parent device's)
> > > against an of_match_table. It was always returning NULL.
> > > 
> > > Make it match layout's OF node against layout's of_match_table.
> > > 
> > > Note: __maybe_unused is needed to avoid:
> > > warning: variable 'layout_np' set but not used [-Wunused-but-set-variable]
> > > (of_match_node() is no-op without CONFIG_OF).
> > > 
> > > Fixes: 61a093b4a0e0 ("nvmem: core: introduce NVMEM layouts")
> > 
> > Nit, how can you have a git commit id if you are sending me patches to
> > be applied to my tree?
> > 
> How should I deal with this situation?
> I apply patches to nvmem-next tree and developers fix issues on top of it.
> On the other hand I send patches as list to you to go via char-misc, so the
> fixes tag is really not relevant to char-misc.
> 
> Should I drop those fixes tag before sending it out?

Probably as the git commit id makes no sense anymore.

thanks,

greg k-h